Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resizing support to CSI volumes #556

Open
gnufied opened this Issue Apr 12, 2018 · 29 comments

Comments

Projects
None yet
@gnufied
Copy link
Member

gnufied commented Apr 12, 2018

Feature Description

  • Add resizing support for CSI volumes
  • Primary contact (assignee): @gnufied
  • Responsible SIGs: sig-storage
  • Design proposal link (community repo): #780
  • Link to e2e and/or unit tests:
  • Reviewer(s) - @jsafrane @saad-ali
  • Approver (likely from SIG/area to which feature belongs): @jsafrane @saad-ali
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.12
    • Beta release target (x.y) 1.13
    • Stable release target (x.y) 1.14
@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Apr 12, 2018

/assign

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Apr 12, 2018

/sig storage

@idvoretskyi idvoretskyi added this to the v1.11 milestone Apr 12, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Apr 29, 2018

/kind feature

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented May 30, 2018

We should move this to 1.12. We still have CSI spec change under discussion.

@justaugustus justaugustus modified the milestones: v1.11, v1.12 May 31, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 18, 2018

@gnufied @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Jul 26, 2018

This is still on target for 1.12. We are working on various aspects of code and specs to meet that goal.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 26, 2018

Thanks for the update! This has been added to the 1.12 Tracking sheet.

@zparnold

This comment has been minimized.

Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @gnufied I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

justaugustus pushed a commit to justaugustus/enhancements that referenced this issue Sep 3, 2018

Merge pull request kubernetes#556 from ahmetb/pr-arc
Fix broken link in architecture.md
@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 5, 2018

@gnufied --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are overdue.
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Sep 5, 2018

We will have to move this to next milestone.

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 5, 2018

Got it. Thanks for the update!

@justaugustus justaugustus added tracked/no and removed tracked/yes labels Sep 5, 2018

@justaugustus justaugustus removed this from the v1.12 milestone Sep 5, 2018

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Oct 8, 2018

Hi @gnufied
This enhancement has been tracked before, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.13. This release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Please take a moment to update the milestones on your original post for future tracking and ping @kacole2 if it needs to be included in the 1.13 Enhancements Tracking Sheet

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

Thanks!

@fejta-bot

This comment has been minimized.

Copy link

fejta-bot commented Jan 6, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Jan 8, 2019

/remove-lifecycle stale

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 16, 2019

@gnufied Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Jan 16, 2019

@claurence this feature is on track for 1.14 yes!

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 17, 2019

Thanks @gnufied based on the label is it still alpha or is it graduating in 1.14. Also are there any associated open PRs for this issue or have they all been merged?

@thcyron thcyron referenced this issue Jan 18, 2019

Open

Resizing PVC #8

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 25, 2019

@gnufied checking in on this feature? Is this planning to graduate or is it planning to be alpha in 1.14? The label on it indicates alpha. Additionally is there a KEP for this issue?

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Jan 26, 2019

This feature will release as an alpha feature in 1.14. As such we weren't planning for a KEP because it does not require a major redesign in existing internals. It builds on feature that already exists in k8s.

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 29, 2019

@gnufied I think we'd still want a KEP - is there a testing plan for this enhancement? graduation criteria?

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Jan 30, 2019

@claurence added a KEP for csi volume resizing.

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 30, 2019

@gnufied Thanks - since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019

@claurence claurence added tracked/no and removed tracked/yes labels Jan 30, 2019

@claurence claurence added this to the v1.14 milestone Feb 5, 2019

@claurence claurence added tracked/yes and removed tracked/no labels Feb 5, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 5, 2019

Adding back to 1.14 milestone. Thanks for getting the KEP merged

@cody-clark

This comment has been minimized.

Copy link
Member

cody-clark commented Feb 19, 2019

Hi @gnufied! I'm one of the v1.14 docs release shadows.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@lachie83

This comment has been minimized.

Copy link
Member

lachie83 commented Feb 25, 2019

Hello @gnufied, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Feb 28, 2019

@lachie83 @cody-clark The feature is on track. Most of work is externally done in https://github.com/kubernetes-csi/external-resizer/ , however I will have a PR for main k/k repo as well.

I will open docs PR by docs window.

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Mar 1, 2019

@gnufied

This comment has been minimized.

Copy link
Member Author

gnufied commented Mar 4, 2019

Code PR for main k/k repo - kubernetes/kubernetes#74863

@jimangel

This comment has been minimized.

Copy link
Member

jimangel commented Mar 5, 2019

Hey @gnufied, thanks for the docs ref. Would you mind rebasing it off of the dev-1.14 branch instead of master? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.