New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide environment variables expansion in sub path mount #559

Open
kevtaylor opened this Issue Apr 13, 2018 · 35 comments

Comments

Projects
None yet
9 participants
@kevtaylor

kevtaylor commented Apr 13, 2018

Feature Description

  • One-line feature description (can be used as a release note): Provide environment variables expansion in sub path mount
  • Primary contact (assignee): @kevtaylor
  • Responsible SIGs: kubernetes/sig-storage
  • Design proposal link (community repo):
    kubernetes/kubernetes#48677
  • Link to e2e and/or unit tests:
    kubernetes/kubernetes#49388
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @msau42 @jsafrane
  • Approver (likely from SIG/area to which feature belongs): @msau42
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.11)
    • Beta release target (1.12)
    • Stable release target (1.13)
@msau42

This comment has been minimized.

Member

msau42 commented Apr 13, 2018

Assignee should be @kevtaylor ;-)

@kevtaylor

This comment has been minimized.

kevtaylor commented Apr 13, 2018

Related to this issue kubernetes/kubernetes#48677 not the one above

@jsafrane

This comment has been minimized.

Member

jsafrane commented Apr 16, 2018

"Design proposal link" leads to "taint node 'shutdown' condition"

@kevtaylor

This comment has been minimized.

kevtaylor commented Apr 16, 2018

@jsafrane Sorry, I corrected it in the comment above - but I didn't know how to edit the original

@kevtaylor

This comment has been minimized.

kevtaylor commented Apr 16, 2018

@jsafrane Actually - forget that - I just did it

@kevtaylor

This comment has been minimized.

kevtaylor commented Apr 16, 2018

@jsafrane I also update the assignee as per @msau42 comments

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

@kevtaylor
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

/assign @kevtaylor

cc @idvoretskyi

@kevtaylor

This comment has been minimized.

kevtaylor commented Apr 17, 2018

/sig storage

@kevtaylor

This comment has been minimized.

kevtaylor commented Apr 17, 2018

/kind feature

@justaugustus justaugustus added this to the v1.11 milestone Apr 17, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Apr 17, 2018

Thanks for the update, @kevtaylor!

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 4, 2018

@kevtaylor --
We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@kevtaylor

This comment has been minimized.

kevtaylor commented Jun 4, 2018

@justaugustus I didn't have edit rights - I have requested them

@kevtaylor

This comment has been minimized.

kevtaylor commented Jun 4, 2018

@justaugustus Should be up to date now.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 4, 2018

@kevtaylor yup, just saw it. Thanks for the update!

@kevtaylor

This comment has been minimized.

kevtaylor commented Jun 9, 2018

@justaugustus Hi. I wanted to update the test status of the feature in the spreadsheet but it no longer seems to allow me to edit it. Is that intentional?

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 9, 2018

@kevtaylor definitely intentional. We locked up permissions on the sheet, but feel free to drop comments in the relevant cells, tag me, and I'll get it updated.

@kevtaylor

This comment has been minimized.

kevtaylor commented Jun 9, 2018

@justaugustus Thanks, I saw that you can add a comment, so I have added one.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Jul 23, 2018

@kevtaylor This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12 as mentioned in your original post.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@kevtaylor

This comment has been minimized.

kevtaylor commented Jul 24, 2018

@kacole2 The intention was to do a simple migration to beta, but this has been blocked by @liggitt and @thockin who want to revamp the api instead so I don't know what the future plans are. Discussion is here kubernetes/kubernetes#65769

@msau42

This comment has been minimized.

Member

msau42 commented Jul 25, 2018

Hi @kevtaylor sorry I missed the discussion earlier. The points that were brought up make sense from an API backwards compatibility view, sorry I didn't think about it when reviewing the alpha design :( Given that, then the first approach outlined in #48677 would make more sense.

@kevtaylor

This comment has been minimized.

kevtaylor commented Jul 25, 2018

@msau42 Okay. Fine. I will leave it in your hands then to schedule an API implementation change as you see fit. Thanks

@msau42

This comment has been minimized.

Member

msau42 commented Jul 25, 2018

@kevtaylor there's no need to schedule. If anyone is interested in driving this then we can track for this release.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 25, 2018

Sounds like this might not make it in. Let me know if that changes.
Pinging @kubernetes/sig-storage-misc to see if anyone is interested in taking this on.

/help

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Jul 25, 2018

@justaugustus:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Sounds like this might not make it in. Let me know if that changes.
Pinging @kubernetes/sig-storage-misc to see if anyone is interested in taking this on.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus removed this from the v1.11 milestone Jul 25, 2018

@kevtaylor

This comment has been minimized.

kevtaylor commented Jul 25, 2018

@justaugustus Yes, that is likely as the proposed change is a large scale change involving the api and that is beyond my expertise in the product.

@cbluth

This comment has been minimized.

cbluth commented Aug 23, 2018

I have enabled the feature gate VolumeSubpathEnvExpansion, are there usage examples?
@kevtaylor

@bungder

This comment has been minimized.

bungder commented Oct 19, 2018

I have already run a cluster using kubeadm v1.11 and I don't want to reset and re-init it. How can I enable VolumeSubpathEnvExpansion without stopping my cluster? I searched kubernetes documentations and found no way to do it. It would be great if you know how to do so. Thanks a lot.
@kevtaylor @cbluth

@kevtaylor

This comment has been minimized.

kevtaylor commented Oct 19, 2018

@bungder It is a feature gate that needs to be enabled --feature-gates as it is only alpha - it is also being reshaped for future releases, so is subject to change - you would need to restart the server components to enable any feature-gate

@bungder

This comment has been minimized.

bungder commented Oct 19, 2018

@kevtaylor I found 2 commands that can be followed by --feature-gates:

  • kubeadm init --feature-gates
  • kubeadm config upload from-flags --feature-gates

The 1st one is used to init cluster so it doesn't fit this situation.
The 2nd one doesn't support this feature, it returns unrecognized feature-gate key: VolumeSubpathEnvExpansion

So is there any command that could enable VolumeSubpathEnvExpansion feature without stopping cluster?

@bungder

This comment has been minimized.

bungder commented Oct 19, 2018

@kevtaylor I did not see "you would need to restart the server components to enable any feature-gate" just now. Rolling update is acceptable. But where should I place this feature config?

@kevtaylor

This comment has been minimized.

kevtaylor commented Oct 19, 2018

@bungder I don't use kubeadm so unfortunately, I don't know how feature gates get into your cluster using that tool - probably better to go down into one of the slack channels and ask

@bungder

This comment has been minimized.

bungder commented Oct 19, 2018

@kevtaylor Still, thanks a lot

@kobozo

This comment has been minimized.

kobozo commented Oct 26, 2018

@bungder Did you found a solution to this? I have the same issue

@bungder

This comment has been minimized.

bungder commented Oct 29, 2018

@kobozo Sorry, I didn't. I gave up using this feature. If you find any way to solve this, please add a comment to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment