Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide environment variables expansion in sub path mount #559

Closed
kevtaylor opened this issue Apr 13, 2018 · 102 comments
Closed

Provide environment variables expansion in sub path mount #559

kevtaylor opened this issue Apr 13, 2018 · 102 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@kevtaylor
Copy link
Contributor

kevtaylor commented Apr 13, 2018

Feature Description

@msau42
Copy link
Member

msau42 commented Apr 13, 2018

Assignee should be @kevtaylor ;-)

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Apr 13, 2018

Related to this issue kubernetes/kubernetes#48677 not the one above

@jsafrane
Copy link
Member

jsafrane commented Apr 16, 2018

"Design proposal link" leads to "taint node 'shutdown' condition"

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Apr 16, 2018

@jsafrane Sorry, I corrected it in the comment above - but I didn't know how to edit the original

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Apr 16, 2018

@jsafrane Actually - forget that - I just did it

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Apr 16, 2018

@jsafrane I also update the assignee as per @msau42 comments

@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

@kevtaylor
Any plans for this in 1.11?

If so, can you please ensure the feature is up-to-date with the appropriate:

  • Description
  • Milestone
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

/assign @kevtaylor

cc @idvoretskyi

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Apr 17, 2018

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Apr 17, 2018
@kevtaylor
Copy link
Contributor Author

kevtaylor commented Apr 17, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 17, 2018
@justaugustus justaugustus added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 17, 2018
@justaugustus justaugustus added this to the v1.11 milestone Apr 17, 2018
@justaugustus
Copy link
Member

justaugustus commented Apr 17, 2018

Thanks for the update, @kevtaylor!

@justaugustus
Copy link
Member

justaugustus commented Jun 4, 2018

@kevtaylor --
We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Jun 4, 2018

@justaugustus I didn't have edit rights - I have requested them

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Jun 4, 2018

@justaugustus Should be up to date now.

@justaugustus
Copy link
Member

justaugustus commented Jun 4, 2018

@kevtaylor yup, just saw it. Thanks for the update!

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Jun 9, 2018

@justaugustus Hi. I wanted to update the test status of the feature in the spreadsheet but it no longer seems to allow me to edit it. Is that intentional?

@justaugustus
Copy link
Member

justaugustus commented Jun 9, 2018

@kevtaylor definitely intentional. We locked up permissions on the sheet, but feel free to drop comments in the relevant cells, tag me, and I'll get it updated.

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Jun 9, 2018

@justaugustus Thanks, I saw that you can add a comment, so I have added one.

@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 18, 2018
@kacole2
Copy link
Member

kacole2 commented Jul 23, 2018

@kevtaylor This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12 as mentioned in your original post.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Jul 24, 2018

@kacole2 The intention was to do a simple migration to beta, but this has been blocked by @liggitt and @thockin who want to revamp the api instead so I don't know what the future plans are. Discussion is here kubernetes/kubernetes#65769

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Oct 2, 2019

@palnabarun yes this is graduating in 1.17

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Oct 2, 2019

@palnabarun
KEP Graduation update: #1255
Code PR: kubernetes/kubernetes#82578
Docs PR: kubernetes/website#16547

@palnabarun palnabarun added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 2, 2019
@palnabarun
Copy link
Member

palnabarun commented Oct 2, 2019

@kevtaylor Awesome. 🎉 Thank you for the updates. I have updated the tracking sheet with the details.

@palnabarun
Copy link
Member

palnabarun commented Oct 2, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 2, 2019
@irvifa
Copy link
Member

irvifa commented Oct 21, 2019

Hello @kevtaylor I'm one of the v1.17 docs shadows.
Does this enhancement for (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Oct 21, 2019

@irvifa Docs PR: kubernetes/website#16547

@irvifa
Copy link
Member

irvifa commented Oct 21, 2019

Awesome... Thanks a lot @kevtaylor !

@palnabarun
Copy link
Member

palnabarun commented Nov 5, 2019

Hi @kevtaylor

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. I see that kubernetes/kubernetes#82578 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Nov 5, 2019

@palnabarun No further PRs other than those already mentioned here

@palnabarun
Copy link
Member

palnabarun commented Nov 5, 2019

@kevtaylor Thank you for the updates! :)

@palnabarun
Copy link
Member

palnabarun commented Nov 13, 2019

Hi @kevtaylor , tomorrow is code freeze for the 1.17 release cycle. It looks like the k/k PRs have not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Nov 13, 2019

@palnabarun the issue that was added is not an essential enhancement but merely to switch the tests to conformance. The original PR is not blocked by this and is merged. If @msau42 approves today, this new test suite can also go in

@palnabarun
Copy link
Member

palnabarun commented Nov 13, 2019

@kevtaylor

Thank you for the updates. In that case, shall I remove kubernetes/kubernetes#85128 from 1.17 tracking due to its non-blocking nature and flip back the status to Tracked?

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Nov 13, 2019

@palnabarun I would do that in case 85128 doesnt get approved in time. Sorry to confuse everything! If it gets merged today we can put it in the release if that's not going to cause pain.

@palnabarun
Copy link
Member

palnabarun commented Nov 13, 2019

@kevtaylor Now worries! That sounds good to me.

Do reach out in case you have any queries. 😃

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Nov 15, 2019

@palnabarun it appears that the ga feature has been removed from the milestone in the spreadsheet tracker.

@guineveresaenger
Copy link

guineveresaenger commented Nov 15, 2019

We're putting it back in, sorry for all the confusion! :shipit:

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 3, 2020

Hey @kevtaylor , Happy New Year! 1.18 Enhancements lead here 👋 Thanks for getting this across the line in 1.17!!

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the KEP is still marked as implementable. Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

@kevtaylor
Copy link
Contributor Author

kevtaylor commented Jan 3, 2020

@jeremyrickard Hi. Thanks for that. I'll sort the KEP out and ping back when I've submitted it.

@jeremyrickard jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020
@justaugustus
Copy link
Member

justaugustus commented Jan 3, 2020

@kevtaylor -- You can feel free to come back and /close this once the KEP has been flipped to implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests