New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topology aware dynamic provisioning #561

Closed
lichuqiang opened this Issue Apr 17, 2018 · 24 comments

Comments

Projects
None yet
9 participants
@lichuqiang
Member

lichuqiang commented Apr 17, 2018

Feature Description

  • One-line feature description (can be used as a release note): Topology aware dynamic provisioning
  • Primary contact (assignee): @msau42 @lichuqiang
  • Responsible SIGs: sig-storage
  • Design proposal link (community repo): kubernetes/community#1857
  • Link to e2e and/or unit tests:
  • Reviewer(s): @msau42 @jsafrane
  • Approver (likely from SIG/area to which feature belongs): @jsafrane @saad-ali
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.11
    • Beta release target (x.y) 1.12
    • Stable release target (x.y) 1.13
@lichuqiang

This comment has been minimized.

Member

lichuqiang commented Apr 17, 2018

/assign

@msau42

This comment has been minimized.

Member

msau42 commented Apr 17, 2018

/assign

@justaugustus justaugustus added this to the v1.11 milestone Apr 17, 2018

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this issue May 25, 2018

Merge pull request #63232 from lichuqiang/provision_plumbing
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Volume topology aware dynamic provisioning: basic plumbing

**What this PR does / why we need it**:

Split PR #63193 for better review
part 1: basic scheduler and controller plumbing

Next: #63233

**Which issue(s) this PR fixes** 
Feature: kubernetes/enhancements#561
Design: kubernetes/community#2168

**Special notes for your reviewer**:
/sig storage
/sig scheduling
/assign @msau42 @jsafrane @saad-ali @bsalamat


**Release note**:

```release-note
Basic plumbing for volume topology aware dynamic provisioning
```
@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 4, 2018

@msau42 @lichuqiang -- We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@msau42

This comment has been minimized.

Member

msau42 commented Jun 4, 2018

We've only partially completed the feature for 1.11, so we will defer to 1.12.

@saad-ali saad-ali modified the milestones: v1.11, v1.12 Jun 4, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jun 4, 2018

Thanks for the update, @msau42!

li-ang pushed a commit to li-ang/kubernetes that referenced this issue Jun 5, 2018

Merge pull request kubernetes#63233 from lichuqiang/provision_api
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

API change for volume topology aware dynamic provisioning

**What this PR does / why we need it**:

Split PR kubernetes#63193 for better review
part 2: API change

Previous: kubernetes#63232
Next: kubernetes#63193

**Which issue(s) this PR fixes** 
Feature: kubernetes/enhancements#561
Design: kubernetes/community#2168

**Special notes for your reviewer**:
/sig storage
/sig scheduling
/assign @msau42 @jsafrane @thockin 


**Release note**:

```release-note
API change for volume topology aware dynamic provisioning
```

k8s-publishing-bot added a commit to kubernetes/api that referenced this issue Jun 5, 2018

Merge pull request #63233 from lichuqiang/provision_api
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

API change for volume topology aware dynamic provisioning

**What this PR does / why we need it**:

Split PR kubernetes/kubernetes#63193 for better review
part 2: API change

Previous: kubernetes/kubernetes#63232
Next: kubernetes/kubernetes#63193

**Which issue(s) this PR fixes**
Feature: kubernetes/enhancements#561
Design: kubernetes/community#2168

**Special notes for your reviewer**:
/sig storage
/sig scheduling
/assign @msau42 @jsafrane @thockin

**Release note**:

```release-note
API change for volume topology aware dynamic provisioning
```

Kubernetes-commit: 77d996b27883bed9d8b9015b608f9a0f0c60fd23

dims pushed a commit to dims/kubernetes that referenced this issue Jun 5, 2018

Merge pull request kubernetes#63193 from lichuqiang/provision_0425
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Volume topology aware dynamic provisioning: work based on new API

**What this PR does / why we need it**:

The PR has been split to 3 parts:

Part1: kubernetes#63232 for basic scheduler and PV controller plumbing
Part2: kubernetes#63233 for API change

and the PR itself includes work based on the API change:

- Dynamic provisioning allowed topologies scheduler work
- Update provisioning interface to be aware of selected node and topology

**Which issue(s) this PR fixes** 
Feature: kubernetes/enhancements#561
Design: kubernetes/community#2168

**Special notes for your reviewer**:
/sig storage
/sig scheduling
/assign @msau42 @jsafrane @saad-ali @bsalamat

@kubernetes/sig-storage-pr-reviews
@kubernetes/sig-scheduling-pr-reviews

**Release note**:

```release-note
Volume topology aware dynamic provisioning
```
@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@msau42 @lichuqiang @kubernetes/sig-storage-feature-requests --

This feature was removed from the previous milestone, so we'd like to check in and see if there are any plans for this in Kubernetes 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38

@lichuqiang

This comment has been minimized.

Member

lichuqiang commented Jul 18, 2018

@justaugustus Thanks for your reminding!

One thing I'm not sure is the feature target. In 1.11, because of the fact that we were lack of some downside implementation, we didn't officially claim it alpha.
But it's indeed there. And we might wanna aim to Beta in 1.12.

Would like to wait for @msau42 for confirmation.

@msau42

This comment has been minimized.

Member

msau42 commented Jul 18, 2018

Correct, goal is 1.12 beta once we have a plugin implementation with e2e tests.

@msau42

This comment has been minimized.

Member

msau42 commented Jul 18, 2018

Plugin implementations are being tracked in:
#567
#558

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

Thanks for the update, @lichuqiang @msau42!
/remove-stage alpha
/stage beta

@msau42

This comment has been minimized.

Member

msau42 commented Aug 20, 2018

Doc placeholder: kubernetes/website#9939

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@msau42 @lichuqiang --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are overdue.
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@msau42

This comment has been minimized.

Member

msau42 commented Sep 5, 2018

Yes this feature will be beta in 1.12. According to the 1.12 release schedule, docs PRs are not due until the 7th: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.12

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

Got it. Thanks for the update!

@zparnold

This comment has been minimized.

Member

zparnold commented Sep 10, 2018

@msau42 I didn't see a PR in k/website for this, but I could be mistaken. Could you please link it here for me?

@msau42

This comment has been minimized.

Member

msau42 commented Sep 10, 2018

It's the placeholder PR mentioned above that you have also reviewed. kubernetes/website#9939

@zparnold

This comment has been minimized.

Member

zparnold commented Sep 10, 2018

@ameukam

This comment has been minimized.

Contributor

ameukam commented Oct 5, 2018

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP

@msau42

This comment has been minimized.

Member

msau42 commented Oct 5, 2018

Yes, we plan to move this to GA in 1.13.

@saad-ali saad-ali modified the milestones: v1.12, v1.13 Oct 5, 2018

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@msau42 is there a list of pending PRs or issues you are tracking for this feature to go to GA? Is this dependent on #611 is any way for GA?

@msau42

This comment has been minimized.

Member

msau42 commented Oct 17, 2018

This feature is a subset of #490, but doesn't have any separate tasks that aren't already covered. Would it be easier to close this and just track #490?

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 17, 2018

@msau42 i like this idea. @AishSundar do you have any concerns about following #490 ?

@AishSundar

This comment has been minimized.

AishSundar commented Oct 18, 2018

+1 on closing this issue if there are no more specific tasks. Thanks @msau42

@lichuqiang

This comment has been minimized.

Member

lichuqiang commented Oct 18, 2018

Let's track with #490. Closing this.

@lichuqiang lichuqiang closed this Oct 18, 2018

@kacole2 kacole2 removed this from the v1.13 milestone Oct 18, 2018

@kacole2 kacole2 removed the tracked/yes label Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment