Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod priority and preemption #564

Closed
bsalamat opened this issue Apr 24, 2018 · 22 comments
Closed

Add pod priority and preemption #564

bsalamat opened this issue Apr 24, 2018 · 22 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@bsalamat
Copy link
Member

bsalamat commented Apr 24, 2018

Feature Description

/stage beta
/sig scheduling
/kind feature

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 24, 2018
@bsalamat bsalamat added this to the v1.11 milestone Apr 24, 2018
@justaugustus justaugustus added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Apr 24, 2018
@justaugustus
Copy link
Member

/assign @bsalamat

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 29, 2018
@justaugustus
Copy link
Member

@bsalamat --
We're doing one more sweep of the 1.11 Features tracking spreadsheet.
Would you mind filling in any incomplete / blank fields for this feature's line item?

@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 18, 2018
@kacole2
Copy link
Contributor

kacole2 commented Jul 23, 2018

@bsalamat This feature was worked on in the previous milestone, so we'd like to check in and see if there are any plans for this to graduate stages in Kubernetes 1.12.

If there are any updates, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@bsalamat
Copy link
Member Author

This feature is built and graduated to Beta in 1.11. We don't have a clear milestone for GA at this point as we have not received enough feedback about it yet.

@justaugustus justaugustus removed this from the v1.11 milestone Jul 31, 2018
@justaugustus justaugustus added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Jul 31, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2018
@bsalamat
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2018
@luxas
Copy link
Member

luxas commented Dec 4, 2018

When will this feature graduate to stable?

@bsalamat
Copy link
Member Author

bsalamat commented Dec 8, 2018

We recently encountered an issue with the new scheduling queue (which is needed for this feature to work correctly). We are addressing the issue. If we don't see further issues and once we have confidence in the feature, we can graduate it to stable. That could possibly be as early as 1.14 if things go well.

@claurence
Copy link

@bsalamat Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP

@bsalamat
Copy link
Member Author

@claurence We want to move this feature to GA in 1.14. This feature is not new though. It has design docs/proposals merged a long time ago (here and here).

@claurence claurence added this to the v1.14 milestone Feb 1, 2019
@claurence claurence added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 1, 2019
@liggitt liggitt self-assigned this Feb 5, 2019
@liggitt
Copy link
Member

liggitt commented Feb 5, 2019

I'll take the API review for this one

@liggitt liggitt added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Feb 5, 2019
@liggitt liggitt removed the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Feb 5, 2019
@liggitt liggitt added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 15, 2019
@liggitt
Copy link
Member

liggitt commented Feb 15, 2019

@apelisse to shadow

@liggitt liggitt added this to Assigned in API Reviews Feb 15, 2019
@liggitt liggitt moved this from Assigned to In progress in API Reviews Feb 15, 2019
@liggitt liggitt removed this from In progress in API Reviews Feb 20, 2019
@claurence
Copy link

@bsalamat looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

@bsalamat
Copy link
Member Author

@claurence Could you please elaborate or refer me to an example of needed testing plans? This feature existed and already has unit, integration, and e2e tests and graduation to stable comes with no functionality change. So, there is no need to specifically add tests for the stable version.

@lachie83
Copy link
Member

Hello @bsalamat, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

@bsalamat
Copy link
Member Author

Hi @lachie83, The only remaining PR is kubernetes/kubernetes#74465 which is actually just a comment update to mark older versions of the API deprecated. Other changes are already merged.

@claurence
Copy link

@bsalamat if the tests exist can you PR a link to them into the KEP so they are easy for CI Signal and others to find?

@lachie83
Copy link
Member

lachie83 commented Mar 6, 2019

@bsalamat can you please provide an update on the @claurence comment regarding tests?

@bsalamat
Copy link
Member Author

bsalamat commented Mar 6, 2019

@claurence @lachie83 I just sent a PR to add testing plan to the KEP.

@bsalamat
Copy link
Member Author

Pod priority and preemption is in GA in 1.14. With that, we can close this enhancement request.

@RehanSaeed
Copy link

The docs still mention scheduling.k8s.io/v1beta1 as the apiVersion. Can we now switch to v1?

@bsalamat
Copy link
Member Author

@RehanSaeed Yes. I will send a PR to change the example to v1. Thanks for reporting it.

@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests

10 participants