Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI Block storage support #565

Closed
vladimirvivien opened this issue Apr 27, 2018 · 103 comments
Closed

CSI Block storage support #565

vladimirvivien opened this issue Apr 27, 2018 · 103 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@vladimirvivien
Copy link
Member

vladimirvivien commented Apr 27, 2018

Feature Description

  • One-line feature description (can be used as a release note):
    • Support for raw block storage in CSI
  • Kubernetes Enhancement Proposal: CSI Raw Block Support
  • Primary contact (assignee): @bswartz
  • Responsible SIGs: sig-storage
  • Reviewer(s): @saad-ali @jsafrane @vladimirvivien
  • Approvers (likely from SIG/area to which feature belongs): @saad-ali @jsafrane
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.11
    • Beta release target (x.y) 1.13
    • Stable release target (x.y) 1.18 (target)
@vladimirvivien
Copy link
Member Author

vladimirvivien commented Apr 27, 2018

/assign

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Apr 27, 2018

/milestone 1.11

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Apr 27, 2018

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Apr 27, 2018
@vladimirvivien
Copy link
Member Author

vladimirvivien commented Apr 27, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 27, 2018
@vladimirvivien
Copy link
Member Author

vladimirvivien commented Apr 27, 2018

/stage alpha

@saad-ali saad-ali added this to the v1.11 milestone Apr 27, 2018
@justaugustus justaugustus added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 29, 2018
@justaugustus
Copy link
Member

justaugustus commented Jun 1, 2018

@vladimirvivien -- What's the current status of this feature?
As we haven't heard from you with regards to some items, this feature has been moved to the Milestone risks sheet within the 1.11 Features tracking spreadsheet.

Please update the line item for this feature on the Milestone risks sheet ASAP AND ping myself and @idvoretskyi, so we can assess the feature status or we will need to officially remove it from the milestone.

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Jun 4, 2018

@justaugustus and @idvoretskyi working to get PR doc for this feature today. I will update the tracking spreadsheet accordingly.

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Jun 4, 2018

@justaugustus @idvoretskyi decided not to do documentation for this feature yet.

@justaugustus
Copy link
Member

justaugustus commented Jun 4, 2018

@vladimirvivien I'm not sure that we've officially decided where our bar is for accepting alpha features without documentation, but I'm fairly sure we'll need something to allow this feature in.

I'll let @jberkus & @mistyhacks weigh in.

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Jun 5, 2018

@justaugustus @mistyhacks forgive my ignorance in the feature acceptance process. The raw volume block support is an existing alpha volume spec feature that is already documented. I looked at other internal drivers that support that feature and they don't seem to specifically document it at this point. That is what I based my decision on.

If some verbiage is needed for feature to be accepted, I will create a PR right now.

@idvoretskyi
Copy link
Member

idvoretskyi commented Jun 5, 2018

If some verbiage is needed for feature to be accepted, I will create a PR right now.

@vladimirvivien, please!

PS. Some of the current procedures need to be enhanced, but let's move now in the right direction.

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Jun 5, 2018

@idvoretskyi @justaugustus @mistyhacks PR kubernetes/website#8927

@justaugustus
Copy link
Member

justaugustus commented Jun 5, 2018

Thanks for the updates, @vladimirvivien! Moving this back into the main tracking tab.

@wenjiaswe
Copy link

wenjiaswe commented Jun 20, 2018

@vladimirvivien This feature is not in 1.11 Features tracking spreadsheet now. Is this dropped from 1.11?

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Jun 29, 2018

@wenjiaswe this feature is alpha in 1.11. Not sure why it was removed from feature sheet.

@justaugustus
Copy link
Member

justaugustus commented Jun 29, 2018

@wenjiaswe @vladimirvivien -- I definitely moved the feature back into the 1.11 milestone, so I think its' absence on the tracking sheet is due to an accidental deletion prior to my locking permissions down.

Was there a specific reason you needed to reference the 1.11 sheet?
Kubernetes 1.11 was released this week and from a planning perspective, we'd now be looking towards tracking 1.12. The 1.12 Features tracking sheet can be found here: http://bit.ly/k8s112-features

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Jun 30, 2018

@justaugustus thanks for the clarification. Looking to go beta with this in 1.12.

@justaugustus justaugustus removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 18, 2018
@kacole2
Copy link
Member

kacole2 commented Jul 23, 2018

@vladimirvivien This feature was worked on in the previous milestone, so we'd like to check in and see if you are still targeting this feature to be beta in 1.12.

If so, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@vladimirvivien
Copy link
Member Author

vladimirvivien commented Jul 25, 2018

@kacole2 Yes, this issue is being worked on for 1.12. I will update with the requested info ASAP.

@justaugustus justaugustus modified the milestones: v1.11, v1.12 Jul 26, 2018
@justaugustus
Copy link
Member

justaugustus commented Jul 26, 2018

@vladimirvivien -- Sounds good. Ping us when you've got everything up-to-date!

@justaugustus
Copy link
Member

justaugustus commented Jul 26, 2018

/remove-stage alpha
/stage beta

@kcmartin
Copy link

kcmartin commented Oct 14, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 14, 2019
@VineethReddy02
Copy link

VineethReddy02 commented Oct 21, 2019

@jsafrane @vladimirvivien @bswartz

I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks!

@jsafrane
Copy link
Member

jsafrane commented Oct 25, 2019

@kcmartin, with the number of changes required, we've decided to wait one more release with GA. This feature stays as beta in 1.17.

@jsafrane
Copy link
Member

jsafrane commented Oct 25, 2019

See #1335

@daminisatya
Copy link
Member

daminisatya commented Nov 5, 2019

@jsafrane That means, we do not need any new docs for this enhancement?

@mrbobbytables
Copy link
Member

mrbobbytables commented Nov 5, 2019

Thanks @jsafrane we'll bump it to the next release 👍
/milestone v1.18

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 5, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Nov 5, 2019
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 7, 2020

Hey @jsafrane,

1.18 enhancement team checking in! Are you still planning on graduating this in 1.18? Enhancement Freeze will be January 28th and the Code Freeze will be March 5th!

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 22, 2020

Hey @jsafrane,

1.18 enhancement team checking in! Are you still planning on graduating this in 1.18? Enhancement Freeze is about a week away and we currently are not tracking this item.

Thanks!

@msau42
Copy link
Member

msau42 commented Jan 22, 2020

Yes this should be tracked

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 29, 2020
@sethmccombs
Copy link

sethmccombs commented Feb 6, 2020

Hey @jsafrane @vladimirvivien @bswartz - I'm a Docs shadow on the 1.18 release team.

Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs?

If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th.

Let me know if you have any questions!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Feb 10, 2020

Hi @jsafrane @vladimirvivien @bswartz @msau42 !

As a reminder that the Code Freeze is Thursday 5th March. Can you please link all the k/k PRs or any other PRs that should be tracked for this enhancement?

Thanks!
The 1.18 Enhancements Team

@jsafrane
Copy link
Member

jsafrane commented Feb 11, 2020

For the record, as our KEP says, I did "Disruptive testing with block devices in /dev reordered after reboot" with GCE PD CSI driver.

Scenario:

  1. Node with 6 pods, each using a different PV.
  2. Stop the node.
  3. Force-delete 2 pods, delete 2 pods, keep 2 pods running.
  4. Start the node.
  5. Checked that all 4 pods were correctly deleted and cleaned up (see below).
    6 .Checked that devices for the two running pods changed names (sdd -> sdb, sde -> sdc) and the pods were restarted by Deployment and were running. I checked that the pods god the right devices and data before node shutdown were present.

I found kubernetes/kubernetes#87977 along the way, CSI block volume plugin left some leftover files / directories after pod cleanup. It's being fixed, see the issue. It's not related to disruptive tests.

@jsafrane
Copy link
Member

jsafrane commented Feb 27, 2020

Doc PR: kubernetes/website#19338

@jsafrane
Copy link
Member

jsafrane commented Feb 27, 2020

We track all issues/PR for GA in this board: https://github.com/orgs/kubernetes-csi/projects/4

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Mar 25, 2020

Hi @jsafrane @vladimirvivien @bswartz

As a reminder, please open a PR to update your KEP status to implemented.

Thanks!

The 1.18 Enhancements Team

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 27, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/close

(closing this since the KEP has been implemented)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 29, 2020

@palnabarun: Closing this issue.

In response to this:

/close

(closing this since the KEP has been implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests