Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting of Custom Resources #575

Closed
nikhita opened this issue Jun 21, 2018 · 49 comments
Closed

Defaulting of Custom Resources #575

nikhita opened this issue Jun 21, 2018 · 49 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@nikhita
Copy link
Member

nikhita commented Jun 21, 2018

Feature Description

@nikhita
Copy link
Member Author

nikhita commented Jun 21, 2018

@justaugustus @idvoretskyi this is for 1.12.

/assign @sttts

original CRD feature: #95 (this is a sub-feature)
PR open: kubernetes/kubernetes#63604 (defaulting) and kubernetes/kubernetes#64558 (pruning)

/sig api-machinery
/kind feature
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 21, 2018
@mbohlool
Copy link
Contributor

mbohlool commented Jun 21, 2018

Is there any design doc or discussion on this feature that I can read before diving into the code?

@nikhita
Copy link
Member Author

nikhita commented Jun 21, 2018

Is there any design doc

It wasn't written originally but we plan to write a small design doc for this 👍

discussion on this feature

This was discussed in the sig api-machinery 31 January 2018 meeting: https://docs.google.com/document/d/1x9RNaaysyO0gXHIr1y50QFbiL1x8OWnk2v3XnrdkT5Y/edit#heading=h.l54g1ses43w1 (to those who want to read this, you might need to join the sig-api-machinery google group).

Defaulting was discussed in: kubernetes/kubernetes#55885, kubernetes/kubernetes#63604, go-openapi/validate#81

Pruning: kubernetes/kubernetes#59151, kubernetes/kubernetes#64558

@justaugustus
Copy link
Member

justaugustus commented Jul 18, 2018

@nikhita --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 29, 2018
@justaugustus
Copy link
Member

justaugustus commented Jul 29, 2018

@sttts -- This has been added to the 1.12 Tracking sheet. Apologies for missing it before!

@zparnold
Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @nikhita I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@jimangel
Copy link
Member

jimangel commented Aug 27, 2018

@sttts Bump for docs ☝️

@justaugustus
Copy link
Member

justaugustus commented Sep 5, 2018

@sttts --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@AishSundar
Copy link

AishSundar commented Oct 17, 2018

@sttts is this feature still on track to go to Alpha in 1.13? could you let us know what work is pending for this in k/k eg: list of PRs or issues, status of docs etc. do we feel confident this will hit the deadlines for 1.13 (code freeze 11/15)

@sttts sttts modified the milestones: v1.13, v1.14 Oct 17, 2018
@sttts
Copy link
Contributor

sttts commented Oct 17, 2018

As this lacks concensus, it won't be in 1.13. Updated the milestone.

@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 17, 2018
@AishSundar
Copy link

AishSundar commented Oct 17, 2018

@sttts thanks for making an early decision in favor of release stability

@fejta-bot
Copy link

fejta-bot commented Jan 15, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@kacole2
Copy link
Member

kacole2 commented Aug 26, 2019

@sttts @liggitt assuming there are no more PRs to be merged here and we're ready to go Stable?

@liggitt
Copy link
Member

liggitt commented Aug 26, 2019

pruning is going to stable in 1.16 and has no remaining PRs.

defaulting is going to beta in 1.16, and has only the feature gate promotion PR left to merge kubernetes/kubernetes#81872

@kacole2
Copy link
Member

kacole2 commented Aug 26, 2019

Thanks @liggitt i guess we should have created two separate issues but we are pretty far along now so let's just keep running with it.

@liggitt
Copy link
Member

liggitt commented Sep 3, 2019

docs ready for review in kubernetes/website#15982

@liggitt liggitt changed the title Defaulting and Pruning for Custom Resources Defaulting of Custom Resources Sep 19, 2019
@liggitt
Copy link
Member

liggitt commented Sep 19, 2019

Pruning released as stable in v1.16.0

Defaulting targeted for stable in v1.17.0

@liggitt liggitt modified the milestones: v1.16, v1.17 Sep 19, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 23, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Sep 23, 2019

@liggitt @sttts @nikhita -- Enhancement lead for 1.17 here. Looks like you're ahead of the game :)

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@VineethReddy02
Copy link

VineethReddy02 commented Oct 21, 2019

@liggitt @sttts @nikhita

I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, can you please update the 1.17 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks!

@sttts
Copy link
Contributor

sttts commented Oct 21, 2019

@VineethReddy02 it only needs the small changes replacing "beta" with GA.

@daminisatya
Copy link
Member

daminisatya commented Nov 2, 2019

Awesome! @sttts We still need a placeholder PR before Nov 8th.

@mrbobbytables
Copy link
Member

mrbobbytables commented Nov 5, 2019

Hey there @sttts 1.17 Enhancement lead here. 👋 Code Freeze is right around the corner (November 14th).

It looks like the only outstanding PR is kubernetes/kubernetes#84713. Do you think this will make in? Only release-blocking issues and PRs will be allowed in the milestone after the freeze 😬

Thanks!

@sttts
Copy link
Contributor

sttts commented Nov 6, 2019

It looks like the only outstanding PR is kubernetes/kubernetes#84713. Do you think this will make in?

I hope so :)

@sttts
Copy link
Contributor

sttts commented Nov 6, 2019

@VineethReddy02 here is the docs PR kubernetes/website#17450

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 3, 2020

Hey @sttts , Happy New Year! 1.18 Enhancements lead here 👋

I'm going though and doing some cleanup for the milestone and checking on things that graduated in the last release. Since this graduated to GA in 1.17, I'd like to close this issue out but the defaulting KEP is still marked as implementable (the pruning KEPis as well). Could you submit a PR to update the KEP to implemented and then we can close this issue out?

Thanks so much!

@jeremyrickard jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020
@sttts
Copy link
Contributor

sttts commented Jan 7, 2020

@jeremyrickard #1436

@fejta-bot
Copy link

fejta-bot commented Apr 6, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 6, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 9, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 9, 2020

Thank you @liggitt @sttts @nikhita for working on this enhancement. 👍

I'm going ahead and closing this since the corresponding KEPs are implemented.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 9, 2020

@palnabarun: Closing this issue.

In response to this:

Thank you @liggitt @sttts @nikhita for working on this enhancement. 👍

I'm going ahead and closing this since the corresponding KEPs are implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests