New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaulting and Pruning for Custom Resources #575

Open
nikhita opened this Issue Jun 21, 2018 · 11 comments

Comments

Projects
None yet
9 participants
@nikhita
Member

nikhita commented Jun 21, 2018

Feature Description

  • One-line feature description (can be used as a release note): Support for defaulting and pruning for Custom Resources.
  • Primary contact (assignee): @sttts
  • Responsible SIGs: SIG API Machinery
  • Design proposal link (community repo): https://docs.google.com/document/d/1rBn6SZM7NsWxzBN41J2kO2Odf07PeGPygatM_1RwofY/edit#
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (1.12)
    • Beta release target (TBD)
    • Stable release target (TBD)
@nikhita

This comment has been minimized.

Member

nikhita commented Jun 21, 2018

@justaugustus @idvoretskyi this is for 1.12.

/assign @sttts

original CRD feature: #95 (this is a sub-feature)
PR open: kubernetes/kubernetes#63604 (defaulting) and kubernetes/kubernetes#64558 (pruning)

/sig api-machinery
/kind feature
/stage alpha

@mbohlool

This comment has been minimized.

Member

mbohlool commented Jun 21, 2018

Is there any design doc or discussion on this feature that I can read before diving into the code?

@nikhita

This comment has been minimized.

Member

nikhita commented Jun 21, 2018

Is there any design doc

It wasn't written originally but we plan to write a small design doc for this 👍

discussion on this feature

This was discussed in the sig api-machinery 31 January 2018 meeting: https://docs.google.com/document/d/1x9RNaaysyO0gXHIr1y50QFbiL1x8OWnk2v3XnrdkT5Y/edit#heading=h.l54g1ses43w1 (to those who want to read this, you might need to join the sig-api-machinery google group).

Defaulting was discussed in: kubernetes/kubernetes#55885, kubernetes/kubernetes#63604, go-openapi/validate#81

Pruning: kubernetes/kubernetes#59151, kubernetes/kubernetes#64558

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@nikhita --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 29, 2018

@sttts -- This has been added to the 1.12 Tracking sheet. Apologies for missing it before!

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @nikhita I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@jimangel

This comment has been minimized.

Member

jimangel commented Aug 27, 2018

@sttts Bump for docs ☝️

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@sttts --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@sttts is this feature still on track to go to Alpha in 1.13? could you let us know what work is pending for this in k/k eg: list of PRs or issues, status of docs etc. do we feel confident this will hit the deadlines for 1.13 (code freeze 11/15)

@sttts sttts modified the milestones: v1.13, v1.14 Oct 17, 2018

@sttts

This comment has been minimized.

Contributor

sttts commented Oct 17, 2018

As this lacks concensus, it won't be in 1.13. Updated the milestone.

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Oct 17, 2018

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@sttts thanks for making an early decision in favor of release stability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment