New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIServer DryRun #576

Open
apelisse opened this Issue Jun 21, 2018 · 21 comments

Comments

Projects
None yet
9 participants
@apelisse
Member

apelisse commented Jun 21, 2018

Feature Description

  • One-line feature description (can be used as a release note):
    Add apiserver "dry-run" query-parameter so that requests can be validated and "processed" without actually being persisted.
  • Primary contact (assignee): @apelisse
  • Responsible SIGs: @kubernetes/sig-api-machinery-feature-requests
  • Design proposal link (community repo): 0015-dry-run.md
  • Link to e2e and/or unit tests: None yet
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @deads2k @lavalamp
  • Approver (likely from SIG/area to which feature belongs): @lavalamp
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.12
    • Beta release target (x.y): 1.13
    • Stable release target (x.y): 1.14

@apelisse apelisse added this to the v1.12 milestone Jun 21, 2018

@apelisse apelisse self-assigned this Jun 21, 2018

@apelisse

This comment has been minimized.

Member

apelisse commented Jun 25, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@apelisse --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38
/kind feature
/stage alpha

@apelisse

This comment has been minimized.

Member

apelisse commented Jul 18, 2018

@justaugustus I think we're good!

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

Thanks for the update, @apelisse!

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @apelisse I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@phillipao

This comment has been minimized.

phillipao commented Aug 27, 2018

Design proposal link is invalid. Looks like it has moved to https://github.com/kubernetes/community/blob/master/keps/sig-api-machinery/0015-dry-run.md.

@justaugustus

This comment has been minimized.

Member

justaugustus commented Aug 29, 2018

@phillipao -- thanks for pointing that out! I've updated the link in the description. :)

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@apelisse @jennybuckley --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).

cc: @zparnold @jimangel @tfogo

@apelisse

This comment has been minimized.

Member

apelisse commented Sep 5, 2018

Still on track, fixing and pushing the doc PR (kubernetes/website#10033), thanks for the ping!

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

Thanks for the update, @apelisse !

@apelisse

This comment has been minimized.

Member

apelisse commented Sep 12, 2018

@apelisse

This comment has been minimized.

Member

apelisse commented Sep 12, 2018

@apelisse apelisse modified the milestones: v1.12, v1.13 Oct 4, 2018

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 8, 2018

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta and removed stage/alpha labels Oct 8, 2018

@spiffxp

This comment has been minimized.

Member

spiffxp commented Oct 17, 2018

@apelisse @deads2k @lavalamp what work needs to be done to move this to beta? are there any issues or PR's we can link to track this?

@spiffxp

This comment has been minimized.

Member

spiffxp commented Oct 17, 2018

🤦‍♂️ right, I just noticed kubernetes/kubernetes#68514 but since one of those items is Beta/GA I can't tell if this is just "make docs look good" or if there is code that needs to be written for this

@apelisse

This comment has been minimized.

Member

apelisse commented Oct 17, 2018

Yeah, the Beta/GA means that it'd be nice if we have it for beta, not mandatory. So it's basically just docs I think.

@tfogo

This comment has been minimized.

Member

tfogo commented Nov 3, 2018

Hi @apelisse, could you please open a placeholder PR for the docs for this enhancement against the dev-1.13 branch of k/website and send me a link? If you already have a docs PR open, or if this doesn't require docs in k/website, please let me know.

The deadline for placeholder PRs for the 1.13 release is November 8. So it's important to make a docs PR as soon as possible.

If you have any questions about any of this, I'm happy to help. You can also message me on slack (I'm tfogo there too). 😀

Thanks!

@apelisse

This comment has been minimized.

Member

apelisse commented Nov 4, 2018

Thanks @tfogo, there it is: kubernetes/website#10881

@tfogo

This comment has been minimized.

Member

tfogo commented Nov 4, 2018

Thanks!

@AishSundar

This comment has been minimized.

AishSundar commented Nov 12, 2018

@apelisse can we consider this enhancement complete w.r.t for Beta in 1.13? Is documentation the only open PR?

@apelisse

This comment has been minimized.

Member

apelisse commented Nov 12, 2018

@AishSundar Correct!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment