Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIServer DryRun #576

Closed
apelisse opened this issue Jun 21, 2018 · 56 comments
Closed

APIServer DryRun #576

apelisse opened this issue Jun 21, 2018 · 56 comments

Comments

@apelisse
Copy link
Member

@apelisse apelisse commented Jun 21, 2018

Feature Description

  • One-line feature description (can be used as a release note):
    Add apiserver "dry-run" query-parameter so that requests can be validated and "processed" without actually being persisted.
  • Primary contact (assignee): @apelisse
  • Responsible SIGs: @kubernetes/sig-api-machinery-feature-requests
  • Design proposal link (community repo)/KEP:
    https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/0015-dry-run.md
  • Link to e2e and/or unit tests: None yet
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @deads2k @lavalamp
  • Approver (likely from SIG/area to which feature belongs): @lavalamp
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.12
    • Beta release target (x.y): 1.13
    • Stable release target (x.y): 1.18
@apelisse apelisse added this to the v1.12 milestone Jun 21, 2018
@apelisse apelisse self-assigned this Jun 21, 2018
@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Jun 25, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

@justaugustus justaugustus commented Jul 18, 2018

@apelisse --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

/cc @justaugustus @kacole2 @robertsandoval @rajendar38
/kind feature
/stage alpha

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Jul 18, 2018

@justaugustus I think we're good!

@justaugustus

This comment has been minimized.

Copy link
Member

@justaugustus justaugustus commented Jul 18, 2018

Thanks for the update, @apelisse!

@zparnold

This comment has been minimized.

Copy link
Member

@zparnold zparnold commented Aug 20, 2018

Hey there! @apelisse I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@phillipao

This comment has been minimized.

Copy link

@phillipao phillipao commented Aug 27, 2018

Design proposal link is invalid. Looks like it has moved to https://github.com/kubernetes/community/blob/master/keps/sig-api-machinery/0015-dry-run.md.

@justaugustus

This comment has been minimized.

Copy link
Member

@justaugustus justaugustus commented Aug 29, 2018

@phillipao -- thanks for pointing that out! I've updated the link in the description. :)

@justaugustus

This comment has been minimized.

Copy link
Member

@justaugustus justaugustus commented Sep 5, 2018

@apelisse @jennybuckley --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).

cc: @zparnold @jimangel @tfogo

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Sep 5, 2018

Still on track, fixing and pushing the doc PR (kubernetes/website#10033), thanks for the ping!

@justaugustus

This comment has been minimized.

Copy link
Member

@justaugustus justaugustus commented Sep 5, 2018

Thanks for the update, @apelisse !

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Sep 12, 2018

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Sep 12, 2018

@apelisse apelisse modified the milestones: v1.12, v1.13 Oct 4, 2018
@kacole2

This comment has been minimized.

Copy link
Member

@kacole2 kacole2 commented Oct 8, 2018

/stage beta

@k8s-ci-robot k8s-ci-robot added stage/beta and removed stage/alpha labels Oct 8, 2018
@spiffxp

This comment has been minimized.

Copy link
Member

@spiffxp spiffxp commented Oct 17, 2018

@apelisse @deads2k @lavalamp what work needs to be done to move this to beta? are there any issues or PR's we can link to track this?

@spiffxp

This comment has been minimized.

Copy link
Member

@spiffxp spiffxp commented Oct 17, 2018

🤦‍♂️ right, I just noticed kubernetes/kubernetes#68514 but since one of those items is Beta/GA I can't tell if this is just "make docs look good" or if there is code that needs to be written for this

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Oct 17, 2018

Yeah, the Beta/GA means that it'd be nice if we have it for beta, not mandatory. So it's basically just docs I think.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Sep 9, 2019

@apelisse: Reopened this issue.

In response to this:

/reopen
/lifecycle frozen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot

This comment has been minimized.

Copy link

@fejta-bot fejta-bot commented Sep 9, 2019

Enhancement issues opened in kubernetes/enhancements should never be marked as frozen.
Enhancement Owners can ensure that enhancements stay fresh by consistently updating their states across release cycles.

/remove-lifecycle frozen

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Oct 1, 2019

Hey there @apelisse -- 1.17 Enhancements shadow here 👋 . I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancements). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@julianvmodesto julianvmodesto mentioned this issue Nov 26, 2019
7 of 8 tasks complete
@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Nov 26, 2019

We are planning on promoting this feature to GA in 1.18.

@apelisse apelisse mentioned this issue Nov 26, 2019
@johnbelamaric

This comment has been minimized.

Copy link
Contributor

@johnbelamaric johnbelamaric commented Jan 14, 2020

@apelisse thanks Antoine, I will add it to 1.18 release tracking

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

@johnbelamaric johnbelamaric commented Jan 14, 2020

/milestone v1.18

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Jan 29, 2020

Updated the issue description to the correct KEP.

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Jan 31, 2020

Looks like the KEP here was missing some section, we just merged #1535 to address the problem. Thanks

@palnabarun

This comment has been minimized.

Copy link
Member

@palnabarun palnabarun commented Jan 31, 2020

Thank you @apelisse for addressing this. :)

@jeremyrickard

This comment has been minimized.

Copy link

@jeremyrickard jeremyrickard commented Jan 31, 2020

This received an exception to enhancement freeze.

@sethmccombs

This comment has been minimized.

Copy link

@sethmccombs sethmccombs commented Feb 6, 2020

Hello, @apelisse - I'm a Docs shadow on the 1.18 release team.

Does this enhancement work planned for 1.18 require any new docs or modifications to existing docs?

If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If doc updates are required, reminder that the placeholder PRs against k/website (branch dev-1.18) are due by Friday, Feb 28th.

Let me know if you have any questions!

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Feb 6, 2020

Thanks for the reminder, we're already actively working on documentation for this feature. @zhouya0

@johnbelamaric

This comment has been minimized.

Copy link
Contributor

@johnbelamaric johnbelamaric commented Feb 11, 2020

Hi @apelisse, code freeze is March 5. Please list out/link to any PRs you are working on toward this enhancement, so we can track it in the release team. Thanks!

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Feb 11, 2020

That PR is the last piece of work that needs to go in before code-freeze, thanks!

@VineethReddy02

This comment has been minimized.

Copy link

@VineethReddy02 VineethReddy02 commented Feb 24, 2020

Hi @apelisse
We are close to the docs placeholder PR deadline against the dev-1.18 branch. Having a placeholder PR in place will definitely help us in tracking enhancements much better.
Could you please share the link to docs placeholder PR?

Thanks! :)

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Feb 24, 2020

I've created the empty PR: kubernetes/website#19287

@apelisse

This comment has been minimized.

Copy link
Member Author

@apelisse apelisse commented Mar 23, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

You can’t perform that action at this time.