New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side printing in kubectl #578

Closed
juanvallejo opened this Issue Jun 26, 2018 · 21 comments

Comments

Projects
None yet
8 participants
@juanvallejo
Member

juanvallejo commented Jun 26, 2018

Feature Description

  • One-line feature description (can be used as a release note): kubectl get should get columns back from the server, not the client, and be able to handle this type of server response under all use-cases.
  • Primary contact (assignee): juanvallejo
  • Responsible SIGs: sig-cli
  • Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/server-get.md
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: pwittrock, soltysh
  • Approver (likely from SIG/area to which feature belongs): pwittrock, soltysh
  • Feature target (which target equals to which milestone): 1.12
    • Stable release target (x.y) 1.12

Continuation of the work proposed in #515. This feature focuses on updating the client to completely support Table responses (containing human-readable output) from the server. This would involve updating the kubectl sorter, as well as the custom-columns printer.

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Jun 26, 2018

/sig cli

cc @soltysh

@soltysh soltysh added this to the v1.12 milestone Jul 5, 2018

@soltysh soltysh added the kind/feature label Jul 5, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@juanvallejo @soltysh --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!
/stage stable

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @juanvallejo I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@soltysh

This comment has been minimized.

Contributor

soltysh commented Aug 28, 2018

@zparnold sorry for the late reply but I can't modify the tracking spreadsheet. This feature won't have any doc updates.

@zparnold

This comment has been minimized.

Member

zparnold commented Sep 1, 2018

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 28, 2018

@juanvallejo @soltysh Is this feature considered complete? From the comments, it has graduated to stable and docs are complete. Let me know if we can close the issue. Thanks!

@soltysh

This comment has been minimized.

Contributor

soltysh commented Sep 28, 2018

There are some minor issue we'll be working with @juanvallejo during 1.13 release, so I think it's best leave it open until that is all addressed.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Sep 28, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.12, v1.13 Sep 28, 2018

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@soltysh is there a list of pending PRs or issues you are tracking for this feature to go to GA?

@soltysh

This comment has been minimized.

Contributor

soltysh commented Oct 19, 2018

@juanvallejo and I will be working on improving the performance of sorting in kubectl with server-side printing as well as watching resources. There are no PRs yet.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 22, 2018

@soltysh I have this at "At Risk" for not making the v1.13 milestone. Can you give a brief explanation of the work being done for 1.13 since there are no PRs to track? Enhancement freeze is COB tomorrow and we are trying to nail down everything that needs to be tracked going into code slush. thanks!

@AishSundar

This comment has been minimized.

AishSundar commented Oct 23, 2018

@soltysh I am not very clear what the exact status of this enhancement is. Looks like it did go GA in 1.12. So if what's left for 1.13 are just fixes around performance improvements, then I would rather track then via separate issues and PRs targeting 1.13 milestone, versus keeping this issue open and tracked. Let us know if thats ok and if so please open issues for the remaining work and we can add those to 1.13.

@kacole2 @nikopen

@soltysh

This comment has been minimized.

Contributor

soltysh commented Oct 23, 2018

Let us know if thats ok and if so please open issues for the remaining work and we can add those to 1.13.

I'm fine closing this in that case. Like you said we'll keep the performance tracked in separate PRs.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 23, 2018

thanks @soltysh

/milestone clear
/close

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Oct 23, 2018

@kacole2: Closing this issue.

In response to this:

thanks @soltysh

/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed this from the v1.13 milestone Oct 23, 2018

@AishSundar

This comment has been minimized.

AishSundar commented Oct 23, 2018

Thanks @soltysh. Can you please point us to those PRs and issues in progress for the performance fixes in 1.13. We can make sure it has all the relevant labels to stay in our query radar :)

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Oct 25, 2018

We're tracking the sever-side implementation of "server-side printing" in #515. Seeing as how this issue was tracking the client-side (kubectl) implementation, I'd like to re-open this to keep both of those efforts separate.

We have an umbrella issue open to track on-going work for this feature: kubernetes/kubernetes#60712

Will link to PRs once those are open.

@AishSundar

This comment has been minimized.

AishSundar commented Oct 25, 2018

@juanvallejo #515 is not tracked for 1.13. Do we still want the client side work to go in 1.13? Is kubernetes/kubernetes#60712 tracking all work needed for client-side kubectl or for the overall work?

@kacole2 as FYI

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Oct 25, 2018

Do we still want the client side work to go in 1.13?

I don't believe we'll make 1.13. We can track that for 1.14

Is kubernetes/kubernetes#60712 tracking all work needed for client-side kubectl or for the overall work?

It tracks all of the work. We are not planning on focusing on the "Server" section any time soon. But I will make sure that "Client" items are updated to reflect current state, and point to their respective issues and PRs

@nikopen

This comment has been minimized.

Member

nikopen commented Oct 25, 2018

Since this feature as a feature per se is considered 'released' and 'stable', and further improvements + fixes are on the pipeline for the near future,
you could maybe simply track this on kubernetes/kubernetes#60712 and track that for v1.14?

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Oct 25, 2018

you could maybe simply track this on kubernetes/kubernetes#60712 and track that for v1.14?

Sure, we can track it there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment