New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Plugin mechanism for kubectl #579

Open
juanvallejo opened this Issue Jun 26, 2018 · 12 comments

Comments

Projects
None yet
7 participants
@juanvallejo
Member

juanvallejo commented Jun 26, 2018

Feature Description

  • One-line feature description (can be used as a release note): kubectl should support extensions adding new commands as well as overriding specific subcommands (at any depth).
  • Primary contact (assignee): juanvallejo, soltysh
  • Responsible SIGs: sig-cli
  • Design proposal link (community repo): kubernetes/community#2437
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: pwittrock, soltysh
  • Approver (likely from SIG/area to which feature belongs): pwittrock, soltysh
  • Feature target (which target equals to which milestone): 1.12
    • Alpha release target (x.y) 1.12
    • Beta release target (x.y) 1.13
    • Stable release target (x.y) 1.14
@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Jun 26, 2018

/sig cli

cc @soltysh

@soltysh soltysh added this to the v1.12 milestone Jul 5, 2018

@soltysh soltysh added the kind/feature label Jul 5, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

@juanvallejo @soltysh --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!

@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 18, 2018

/stage beta

@justaugustus

This comment has been minimized.

Member

justaugustus commented Aug 4, 2018

/remove-stage beta
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha and removed stage/beta labels Aug 4, 2018

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @juanvallejo I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Aug 21, 2018

@zparnold Sure, will open PR updating cli docs against 1.12

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 25, 2018

@soltysh

This comment has been minimized.

Contributor

soltysh commented Oct 5, 2018

@kacole2 this will be promoted to beta in 1.13, I haven't seen it in the tracking spreadsheet.
/milestone v1.13

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.12, v1.13 Oct 5, 2018

@kacole2 kacole2 added stage/beta and removed stage/alpha labels Oct 5, 2018

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 5, 2018

@soltysh this has been added to the tracking sheet. thanks!

@spiffxp

This comment has been minimized.

Member

spiffxp commented Oct 17, 2018

@soltysh what work remains to be done to promote this to beta? are there issues or PR's we could link to track?

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Oct 17, 2018

@spiffxp

what work remains to be done to promote this to beta? are there issues or PR's we could link to track?

All of the outstanding work has been completed. We'll just need to update docs and tags labeling this feature as beta

@juanvallejo

This comment has been minimized.

Member

juanvallejo commented Oct 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment