Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeClass #585

Open
tallclair opened this issue Jul 10, 2018 · 34 comments

Comments

@tallclair
Copy link
Member

commented Jul 10, 2018

Enhancement Description

  • One-line feature description (can be used as a release note): RuntimeClass is a new cluster-scoped resource that surfaces container runtime properties to the control plane.
  • Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/runtime-class.md
  • Primary contact (assignee): @tallclair
  • Responsible SIGs: sig-node
  • Feature target (which target equals to which milestone):
    • Alpha release target: 1.12
    • Beta release target: 1.14
    • Stable release target: x.y

EDIT(spiffxp): I edited this to match the current enhancement tracking issue template, the following entries or content are not part of the template

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Jul 10, 2018

/sig node
/milestone v1.12

@tallclair tallclair added this to the v1.12 milestone Jul 10, 2018

@tallclair tallclair self-assigned this Jul 10, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

commented Jul 18, 2018

@tallclair --

It looks like this feature is currently in the Kubernetes 1.12 Milestone.

If that is still accurate, please ensure that this issue is up-to-date with ALL of the following information:

  • One-line feature description (can be used as a release note):
  • Primary contact (assignee):
  • Responsible SIGs:
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which feature belongs):
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Set the following:

  • Description
  • Assignee(s)
  • Labels:
    • stage/{alpha,beta,stable}
    • sig/*
    • kind/feature

Once this feature is appropriately updated, please explicitly ping @justaugustus, @kacole2, @robertsandoval, @rajendar38 to note that it is ready to be included in the Features Tracking Spreadsheet for Kubernetes 1.12.


Please note that the Features Freeze is July 31st, after which any incomplete Feature issues will require an Exception request to be accepted into the milestone.

In addition, please be aware of the following relevant deadlines:

  • Docs deadline (open placeholder PRs): 8/21
  • Test case freeze: 8/28

Please make sure all PRs for features have relevant release notes included as well.

Happy shipping!
/kind feature
/stage alpha

@derekwaynecarr

This comment has been minimized.

Copy link
Member

commented Jul 25, 2018

LGTM

@justaugustus

This comment has been minimized.

Copy link
Member

commented Jul 26, 2018

Thanks for the update! This has been added to the 1.12 Tracking sheet.

@zparnold

This comment has been minimized.

Copy link
Member

commented Aug 20, 2018

Hey there! @tallclair I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2018

@zparnold what are the docs expectations for alpha features?

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Aug 22, 2018

Kubernetes Submit Queue
Merge pull request #67518 from tallclair/runtimeclass-cri
Automatic merge from submit-queue (batch tested with PRs 67298, 67518, 67635, 67673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Add RuntimeHandler to the CRI RunPodSandboxRequest

**What this PR does / why we need it**:

Adds the CRI portion of the [RuntimeClass](https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md#runtime-handler) API.

**Which issue(s) this PR fixes**:
For kubernetes/enhancements#585

**Special notes for your reviewer**:
The Kubernetes API is still blocked on a decision about alpha field usage, see [discussion on sig-architecture](https://groups.google.com/forum/#!topic/kubernetes-sig-architecture/y9FulL9Uq6A). I'd like to start with the CRI piece so we can unblock work on the CRI implementation side to have support ready when Kubernetes support is there.

**Release note**:
```release-note
[CRI] Adds a "runtime_handler" field to RunPodSandboxRequest, for selecting the runtime configuration to run the sandbox with (alpha feature).
```

/sig node
/milestone v1.12
/priority important-soon
/kind api-change

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Aug 23, 2018

Kubernetes Submit Queue
Merge pull request #67737 from tallclair/runtimeclass-podapi
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Runtimeclass podapi

Adds (but doesn't implement) the RuntimeClass Pod API proposed in https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md

Based on the result (lazy consensus) of the alpha fields discussion on sig-architecture: https://groups.google.com/forum/#!topic/kubernetes-sig-architecture/y9FulL9Uq6A

For kubernetes/enhancements#585

**Special notes for your reviewer**:

**Release note**:
```release-note
RuntimeClass is a new API resource for defining different classes of runtimes that may be used to run containers in the cluster. Pods can select a RunitmeClass to use via the RuntimeClassName field. This feature is in alpha, and the RuntimeClass feature gate must be enabled in order to use it.
```

/sig node
/kind api-change
/priority important-soon
/milestone v1.12

k8s-publishing-bot added a commit to kubernetes/api that referenced this issue Aug 24, 2018

Merge pull request #67737 from tallclair/runtimeclass-podapi
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Runtimeclass podapi

Adds (but doesn't implement) the RuntimeClass Pod API proposed in https://github.com/kubernetes/community/blob/master/keps/sig-node/0014-runtime-class.md

Based on the result (lazy consensus) of the alpha fields discussion on sig-architecture: https://groups.google.com/forum/#!topic/kubernetes-sig-architecture/y9FulL9Uq6A

For kubernetes/enhancements#585

**Special notes for your reviewer**:

**Release note**:
```release-note
RuntimeClass is a new API resource for defining different classes of runtimes that may be used to run containers in the cluster. Pods can select a RunitmeClass to use via the RuntimeClassName field. This feature is in alpha, and the RuntimeClass feature gate must be enabled in order to use it.
```

/sig node
/kind api-change
/priority important-soon
/milestone v1.12

Kubernetes-commit: 40063e8810d61f4550cbdbfa33da90728c727679
@zparnold

This comment has been minimized.

Copy link
Member

commented Aug 25, 2018

Hey @tallclair I think in order to get usage out of the feature it's best to document it in the same way it would be a beta/GA feature. Then if people file issues against it we can improve the feature/docs. What do you think?

@tianshapjq

This comment has been minimized.

Copy link

commented Aug 29, 2018

Are there any docs on the available options about RuntimeClassName to be able to leverage this feature?

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2018

kubernetes/website#10102 will provide the documentation, but it's not written yet.

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2018

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

not yet

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Jan 23, 2019

Actually, #697 updates the KEP with the beta criteria.

@thockin

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

I'll take API.

@vishh shadow

@liggitt liggitt added this to Assigned in API Reviews Feb 15, 2019

@jaredbhatti

This comment has been minimized.

Copy link

commented Feb 15, 2019

Hey folks, I'm helping out with the docs for v1.14.

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions or need additional guidance!

@lachie83

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

Hello @tallclair, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Feb 25, 2019

  • kubernetes/kubernetes#74433 is the most important, which migrates to an internal API and adds the beta API
  • Bump feature gate, blocked on beta API
  • #723 - Mostly just process, but ticks a box on the graduation requirements & improves documentation
  • More testing - kubernetes/kubernetes#74757
@jaredbhatti

This comment has been minimized.

Copy link

commented Mar 8, 2019

I noticed you linked to a merged PR for docs that went out in the last release - are there no docs changes per this release?

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Mar 8, 2019

Thanks for pointing that out @jaredbhatti, I'm afraid I missed your last comment. I see that I've missed the March 1st deadline for this, but if it's not too late I've opened kubernetes/website#13043

@tallclair tallclair closed this Mar 8, 2019

@tallclair tallclair reopened this Mar 8, 2019

@spiffxp

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

/remove-stage alpha
/stage beta
reconciling with https://bit.ly/k8s114-enhancements

@k8s-ci-robot k8s-ci-robot added stage/beta and removed stage/alpha labels Mar 19, 2019

@kacole2

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@kacole2 kacole2 removed this from the v1.14 milestone Apr 12, 2019

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Apr 12, 2019

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

This will remain in beta for 1.15, but we are making to related enhancements:

  1. Scheduling - #894
  2. Pod Overhead - #688
@rbitia

This comment has been minimized.

Copy link

commented Jul 11, 2019

Hi @tallclair, & @thockin, I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thanks!

@tallclair

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

RuntimeClass will remain in beta for 1.16. The 2 changes to RuntimeClass are tracked separately:
#688
#894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.