New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TTL after finish #592

Open
janetkuo opened this Issue Jul 23, 2018 · 13 comments

Comments

Projects
None yet
7 participants
@janetkuo
Member

janetkuo commented Jul 23, 2018

Feature Description

@tnozicka

This comment has been minimized.

tnozicka commented Aug 1, 2018

Design proposal link (community repo): https://goo.gl/YxtxTi

Does the google doc need to be moved to community repo?

@tnozicka

This comment has been minimized.

tnozicka commented Aug 15, 2018

Reviewers from multiple companies preferred

Happy to review as well and help fill in the diversity requirement here.

@janetkuo

This comment has been minimized.

Member

janetkuo commented Aug 16, 2018

Thanks @tnozicka! Added you as reviewer

@janetkuo

This comment has been minimized.

Member

janetkuo commented Aug 16, 2018

Updated link to KEP as well

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @janetkuo I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@janetkuo

This comment has been minimized.

Member

janetkuo commented Aug 23, 2018

@zparnold I've opened the docs PR: kubernetes/website#10064; it's still WIP

k8s-merge-robot added a commit to kubernetes/kubernetes that referenced this issue Sep 5, 2018

Merge pull request #66840 from janetkuo/job-ttl
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```

k8s-publishing-bot added a commit to kubernetes/api that referenced this issue Sep 5, 2018

Merge pull request #66840 from janetkuo/job-ttl
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```

Kubernetes-commit: c50a3471242fa33a111d493711c3477e691ccdea

sttts pushed a commit to sttts/api that referenced this issue Sep 5, 2018

Merge pull request #66840 from janetkuo/job-ttl
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```

Kubernetes-commit: c50a3471242fa33a111d493711c3477e691ccdea
@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@janetkuo --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@janetkuo

This comment has been minimized.

Member

janetkuo commented Sep 6, 2018

@justaugustus yes we're landing it for 1.12. The docs is under review kubernetes/website#10064

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 7, 2018

Thanks for the update, @janetkuo!

k8s-publishing-bot added a commit to kubernetes/kube-controller-manager that referenced this issue Sep 9, 2018

Merge pull request #66840 from janetkuo/job-ttl
Automatic merge from submit-queue (batch tested with PRs 66840, 68159). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

TTL for cleaning up Jobs after they finish

**What this PR does / why we need it**: kubernetes/enhancements#592

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #64470 
For kubernetes/enhancements#592

**Special notes for your reviewer**: @kubernetes/sig-apps-pr-reviews 

**Release note**:

```release-note
Add a TTL machenism to clean up Jobs after they finish.
```

Kubernetes-commit: c50a3471242fa33a111d493711c3477e691ccdea
@ameukam

This comment has been minimized.

Contributor

ameukam commented Oct 5, 2018

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 8, 2018

@janetkuo following up from @ameukam's comment. Is there a plan for this to graduate to beta in 1.13?

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Oct 8, 2018

@janetkuo

This comment has been minimized.

Member

janetkuo commented Oct 9, 2018

There's currently no plan to graduate it to beta in 1.13.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 9, 2018

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment