New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Device Plugin Registration #595

Open
saad-ali opened this Issue Jul 28, 2018 · 28 comments

Comments

@saad-ali
Member

saad-ali commented Jul 28, 2018

Feature Description

@saad-ali

This comment has been minimized.

Member

saad-ali commented Jul 28, 2018

Introduced as alpha in v1.11.

See PR kubernetes/kubernetes#63328
See issue: kubernetes/kubernetes#56944

Partial list of work for beta:

  • Recursive detection of UDS in sub directories
  • Unregistration of drivers when UDS is deleted
@justaugustus

This comment has been minimized.

Member

justaugustus commented Jul 28, 2018

Thanks for the update! This has been added to the 1.12 Tracking sheet.
Who's the primary SIG on this? SIG Node or SIG Storage?

/stage beta

@RenaudWasTaken

This comment has been minimized.

Member

RenaudWasTaken commented Jul 30, 2018

The umbrella issue tracker is here: kubernetes/kubernetes#65773

@vikaschoudhary16

This comment has been minimized.

Member

vikaschoudhary16 commented Aug 1, 2018

@saad-ali design proposal PR (migration from original google doc): kubernetes/community#2369

@zparnold

This comment has been minimized.

Member

zparnold commented Aug 20, 2018

Hey there! @saad-ali I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@RenaudWasTaken

This comment has been minimized.

Member

RenaudWasTaken commented Aug 20, 2018

If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

Documentation is needed but not as part of the Kubernetes website.
Documentation will happen:

  • In the kubernetes/csi repository
  • In Readme's the kubernetes/pkg/kubelet/... source
@zparnold

This comment has been minimized.

Member

zparnold commented Aug 25, 2018

Sounds perfect! Thanks! I'll mark that in the feature tracking spreadsheet

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 5, 2018

@RenaudWasTaken -- please be careful using Fix[es] or Closes in a commit as it may cause us to fall into a close loop when the bots pick up a commit.

/reopen

@k8s-ci-robot

This comment has been minimized.

Contributor

k8s-ci-robot commented Sep 5, 2018

@justaugustus: Reopening this issue.

In response to this:

@RenaudWasTaken -- please be careful using Fix[es] or Closes in a commit as it may cause us to fall into a close loop when the bots pick up a commit.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@idealhack

This comment has been minimized.

Member

idealhack commented Sep 6, 2018

/reopen

Is there anything we can do to stop the loop?

@idealhack idealhack reopened this Sep 6, 2018

@justaugustus

This comment has been minimized.

Member

justaugustus commented Sep 6, 2018

I think it'll take effect on every branch transaction that the commit gets pulled into. I'd say that you could do it by amending the commit, but it might be less effort to just reopen this issue every time :/

@RenaudWasTaken

This comment has been minimized.

Member

RenaudWasTaken commented Sep 6, 2018

Sorry I didn't see that Github converted it into a "fix". I Will pay more attention to that in the future.

@ameukam

This comment has been minimized.

Contributor

ameukam commented Oct 5, 2018

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

@RenaudWasTaken

This comment has been minimized.

Member

RenaudWasTaken commented Oct 5, 2018

Hello @ameukam !

This feature graduated to beta in 1.12 and there are no plans to graduate it to stable in 1.13.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 5, 2018

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.12 milestone Oct 5, 2018

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Oct 5, 2018

@saad-ali saad-ali added this to the v1.13 milestone Oct 16, 2018

@saad-ali

This comment has been minimized.

Member

saad-ali commented Oct 16, 2018

This feature graduated to beta in 1.12 and there are no plans to graduate it to stable in 1.13.

CSI depends on this feature. @vladimirvivien is syncing with @RenaudWasTaken to clarify. Preliminary plan is to move to stable in 1.13.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Oct 17, 2018

@saad-ali I've added this to the tracking sheet but putting it At Risk because I feel this has not had enough time to bake. I believe there will be concern about promoting a feature so quickly. @AishSundar @spiffxp

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@saad-ali what work is left for this in 1.13 to be able to go to Stable? Similarly how confident are we of CSI making it to Stable in 1.13 and if [CSI] slips what are the plans for this feature then?

@vladimirvivien

This comment has been minimized.

Member

vladimirvivien commented Oct 17, 2018

@AishSundar
I have discussed this with author (and other interested parties). He feels confident that the code OK and stable given adoption. This feature is being used by several plugin implementers and users (NVIDIA device plugin, several CSI volume plugins) since beta. If CSI slips, this feature is adopted by other plugin providers who are Ok with v1.

@AishSundar

This comment has been minimized.

AishSundar commented Oct 17, 2018

@vladimirvivien thanks for the update. Could you plz point us to a list of pending PRs (code, tests and docs) for this feature?

@vladimirvivien

This comment has been minimized.

Member

vladimirvivien commented Oct 18, 2018

@AishSundar

@AishSundar

This comment has been minimized.

AishSundar commented Nov 12, 2018

@vladimirvivien can I plz know the latest status on this for 1.13. I see quite a few PRs pending in kubernetes/kubernetes#69015. With Code freeze approaching this Friday 11/16, I am afraid its too little time for all the changes. Could you plz provide a list of pending PRs tracking for 1.13?

@RenaudWasTaken

This comment has been minimized.

Member

RenaudWasTaken commented Nov 12, 2018

Hello @AishSundar !

There are only two PRs pending:

In both case I believe the deadline of Friday 11/16 will be respected.

Thanks for looking into this!

@vladimirvivien

This comment has been minimized.

Member

vladimirvivien commented Nov 12, 2018

@AishSundar as @RenaudWasTaken mentioned we have an approved PR (which needs rebase) and an additional PR which should get resolved early this week. All other PR's have been resolved or merged. We are tracking this to be in by code freeze this Friday. Thank you for addressing this.

@kacole2

This comment has been minimized.

Contributor

kacole2 commented Nov 15, 2018

@AishSundar

This comment has been minimized.

AishSundar commented Nov 16, 2018

@vladimirvivien @RenaudWasTaken looks like there is still some active discussion in the PR kubernetes/kubernetes#70494. Are we still on track for Code freeze tomorrow?

@AishSundar

This comment has been minimized.

AishSundar commented Nov 16, 2018

Discussing with @msau42 pending PR kubernetes/kubernetes#70494 is an optimization and not really a blocker for this enhancement in 1.13. As much as we will try to get in today, this can also go as a 1.13.1 patch if merge get delayed.

@Kymb3rl33

This comment has been minimized.

Kymb3rl33 commented Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment