Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI Inline Volume Support #596

Open
saad-ali opened this Issue Jul 28, 2018 · 42 comments

Comments

@saad-ali
Copy link
Member

saad-ali commented Jul 28, 2018

Feature Description

  • One-line feature description (can be used as a release note): CSI volumes can only be referenced via PV/PVC today. This works well for remote persistent volumes. However, we would like CSI to be used to create local ephemeral volumes (e.g. volumes use to inject identity information in to a pod), and these types of volumes should be able to be referred to directly in pod spec (without PV/PVC).
  • Primary contact (assignee): @jsafrane
  • Responsible SIGs: @kubernetes/sig-storage-feature-requests
  • Design proposal link (community repo): kubernetes/community#2273
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @childsb
  • Approver (likely from SIG/area to which feature belongs): @saad-ali
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y): 1.13
    • Beta release target (x.y): 1.14
    • Stable release target (x.y): 1.15
  • PRs

@saad-ali saad-ali added this to the v1.12 milestone Jul 28, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jul 28, 2018

Thanks for the update! This has been added to the 1.12 Tracking sheet.

/assign @jsafrane
/stage alpha

@zparnold

This comment has been minimized.

Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @saad-ali I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 5, 2018

@jsafrane @vladimirvivien --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@saad-ali

This comment has been minimized.

Copy link
Member Author

saad-ali commented Sep 6, 2018

This PR (kubernetes/kubernetes#67452) did not make it to 1.12. Moving to next milestone

@saad-ali saad-ali modified the milestones: v1.12, v1.13 Sep 6, 2018

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Sep 6, 2018

Thanks for the update!

@justaugustus justaugustus added tracked/no and removed tracked/yes labels Sep 6, 2018

@kacole2 kacole2 added tracked/yes and removed tracked/no labels Oct 8, 2018

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Oct 9, 2018

/assign vladimirvivien

@AishSundar

This comment has been minimized.

Copy link

AishSundar commented Oct 17, 2018

@saad-ali @vladimirvivien how confident are we about this going Alpha in 1.13? Is there a list of pending PRs or issues we are tracking for this work?

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Oct 22, 2018

@vladimirvivien there hasn't been any communication on this issue but from the looks of kubernetes/kubernetes#68232 there is activity happening so this is going to continue to be tracked for v1.13 milestone.

@tfogo

This comment has been minimized.

Copy link
Member

tfogo commented Nov 1, 2018

Hi @vladimirvivien @jsafrane @saad-ali, I'm the docs wrangler for the 1.13 release. Could you please open a placeholder PR for the docs for this enhancement against the dev-1.13 branch of k/website and send me a link? If you already have a docs PR open, or if this doesn't require docs in k/website, please let me know.

The deadline for placeholder PRs for the 1.13 release is November 8. So it's important to make a docs PR as soon as possible.

If you have any questions about any of this, I'm happy to help. You can also message me on slack (I'm tfogo there too).

Thanks!

@claurence

This comment has been minimized.

Copy link

claurence commented Nov 7, 2018

Hi @vladimirvivien I'm an enhancements shadow checking in on how this issue is tracking - looks like lots of activity in the K/K PR. Code slush is on 11/9 and code freeze is coming up on 11/15 are you confident this issue will make those dates?

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Nov 9, 2018

@AishSundar

This comment has been minimized.

Copy link

AishSundar commented Nov 9, 2018

@tfogo for docs PR

@AishSundar

This comment has been minimized.

Copy link

AishSundar commented Nov 12, 2018

@vladimirvivien @saad-ali could you plz provide the latest update on this enhancement and status for 1.13 please. Is kubernetes/kubernetes#68232 is the only pending PR (code snd test).

@kacole2

This comment has been minimized.

Copy link
Member

kacole2 commented Nov 14, 2018

/milestone 1.14

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 23, 2019

Thanks @vladimirvivien - any open PRs we should track for 1.14?

@MAKOSCAFEE

This comment has been minimized.

Copy link
Member

MAKOSCAFEE commented Feb 13, 2019

Hey @vladimirvivien @jsafrane👋 I'm the v1.14 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@kfox1111

This comment has been minimized.

Copy link

kfox1111 commented Feb 13, 2019

@claurence kubernetes/kubernetes#68232

@MAKOSCAFEE I think there was a docs pr opened when this almost merged in 1.13. I don't have the link handy though. @vladimirvivien do you?

@MAKOSCAFEE

This comment has been minimized.

Copy link
Member

MAKOSCAFEE commented Feb 13, 2019

@kfox1111 i think this is the PR you were talking about kubernetes/website#10934. If so can this be opened against dev-1.14 branch and looks like it has a lot of conflicts to resolve.

@kfox1111

This comment has been minimized.

Copy link

kfox1111 commented Feb 13, 2019

That's the one I was thinking of. Thanks for finding it. We should update that, yeah.

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Feb 14, 2019

@MAKOSCAFEE @kfox1111 there will definitely be updates to the doc, not sure if a new one will be created.

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Feb 14, 2019

** PRs to follow **

@MAKOSCAFEE

This comment has been minimized.

Copy link
Member

MAKOSCAFEE commented Feb 14, 2019

@vladimirvivien thanks for the information. docs PR(or a placeholder PR) should be against dev-1.14 branch before March 1 which is the deadline. the sooner the better

@saad-ali

This comment has been minimized.

Copy link
Member Author

saad-ali commented Feb 14, 2019

I am interested in shadowing the API review for this.

CC @liggitt

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Feb 15, 2019

@MAKOSCAFEE Thanks for the thorough info. I will get that started soon.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 15, 2019

/assign

@thockin thockin self-assigned this Feb 15, 2019

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Feb 15, 2019

I can help with API, too if you need Jordan.

@vishh shadow

@liggitt liggitt added this to Assigned in API Reviews Feb 15, 2019

@krmayankk

This comment has been minimized.

Copy link
Contributor

krmayankk commented Feb 15, 2019

Is this getting to beta in 1.14 ? We are interested in this feature as a user and can also help with implementation if you need a hand

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Feb 15, 2019

@krmayankk this feature will be alpha in 1.14

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 22, 2019

@jsafrane looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

@msau42

This comment has been minimized.

Copy link
Member

msau42 commented Feb 22, 2019

@vladimirvivien has a followup PR to add more detailed testing information: #790

@MAKOSCAFEE

This comment has been minimized.

Copy link
Member

MAKOSCAFEE commented Feb 28, 2019

Hi @vladimirvivien just to check if you managed to open docs PR(or a placeholder PR) against dev-1.14 as the deadline for doing so(1 March) is tomorrow.
Thanks

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Feb 28, 2019

@MAKOSCAFEE here is the place holder doc PR for this feature - kubernetes/website#10934

@vladimirvivien

This comment has been minimized.

Copy link
Member

vladimirvivien commented Mar 11, 2019

@MAKOSCAFEE can someone take a look at doc PR please - PTAL - kubernetes/website#10934

@MAKOSCAFEE

This comment has been minimized.

Copy link
Member

MAKOSCAFEE commented Mar 11, 2019

Hi @vladimirvivien sure let me ping the right person to take a look. Thanks

@MAKOSCAFEE MAKOSCAFEE referenced this issue Mar 17, 2019

Closed

REQUEST: New membership for @MAKOSCAFEE #619

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.