Pass Pod information in CSI calls

[jsafrane]

Feature Description

• One-line feature description (can be used as a release note): CSI driver may opt-in to receive information about Pod that requested a volume in NodePublish request.

• Primary contact (assignee): @jsafrane

• Responsible SIGs: @kubernetes/sig-storage-feature-requests @kubernetes/sig-node-feature-requests

• Design proposal link (community repo): CSI: send pod information in NodePublishVolumeRequest community#2439

• Link to e2e and/or unit tests: TBD

• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @gnufied @msau42

• Approver (likely from SIG/area to which feature belongs): @saad-ali

• Feature target (which target equals to which milestone):

  • Alpha release target (x.y): 1.12
  • Beta release target (x.y): 1.13
  • Stable release target (x.y): 1.14

API PRs:

• Make CSINodeInfo and CSIDriver Core APIs kubernetes#73883

Tagging sig-node since it will probably need a new gRPC API in kubelet. Proposal will follow soon. Proposal has been created.

[justaugustus]

Thanks @jsafrane! This has been added to the 1.12 tracking spreadsheet.

/assign @jsafrane
/stage alpha

[zparnold]

Hey there! @jsafrane I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

[justaugustus]

@jsafrane --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

[msau42]

@childsb @gnufied ^

[kfox1111]

can we pass through volume.Name too? looks like it is already exposed indirectly to the driver by way of the mount path here:
https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/csi/csi_mounter.go#L79
I'd rather use a passed version then parse it out.

[gnufied]

This feature is on track for 1.12. I will open placeholder PR for docs shortly.

@kfox1111 you mean PersistentVolume.Name field?

[justaugustus]

@gnufied -- Please keep us posted. Docs PR is overdue at this point.

[kfox1111]

the pod spec, volume.name. (the name property of https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#volume-v1-core)

[kfox1111]

Skimming the code, I think its adding the line: "csi.storage.k8s.io/pod.volumeName": c.specVolumeID,

[tfogo]

Hi @gnufied, do you have an update on the Docs PR? Please let us know as soon as you have a PR open.

[gnufied]

@tfogo now that I think of, traditionally CSI+Kubernetes interface has been documented https://kubernetes-csi.github.io/docs/ rather than on community website. This PR change does not affect any end users and is mostly applicable for CSI plugin authors.

I am wondering if we even need a docs PR to community website. cc @saad-ali

[tfogo]

That makes sense. In that case, it's totally fine not to have a PR open in k/website. (Though you should make sure the appropriate docs land in k-csi/docs.)

[justaugustus]

Thanks for the update!

[saad-ali]

Agreed with @gnufied. This change should be documented in kubernetes-csi as it is relevant to CSI driver authors not end users. Tracking that work here.

[ameukam]

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

[kacole2]

Hi @jsafrane is this enhancement going to graduate to beta in 1.13? Need a confirmation so it can be tracked properly. thanks!

[jsafrane]

Yes, we want beta in 1.13

[kacole2]

/milestone v1.13

[irvifa]

Hello @gnufied I'm one of the v1.18 docs shadows.
Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions!

[irvifa]

Hello @gnufied I'm one of the v1.18 docs shadows.

Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions!

[jeremyrickard]

Hey @gnufied,

For 1.17 it looks like this missed code freeze because kubernetes/kubernetes#84814 didn't merge. It still looks like it has not merged. Are there any other k/k PRs that need to be tracked for this issue? We're about a week out from code freeze, which is on 05 March 2020.

[huffmanca]

@jeremyrickard ,

I'm still working on this PR, and hoping to have it ready for review this week. There are no other k/k PRs to my knowledge regarding this issue.

@irvifa ,

Per #603 (comment), this is not a user facing change and no documentation is required in kubernetes/website repo for this change. This will be documented via - https://github.com/kubernetes-csi/docs

[msau42]

@huffmanca, we may still need docs on the k8s side for the feature gate.

[VineethReddy02]

Hi @huffmanca @msau42
Does this feature need any user-facing guide under k8s/website? If so please raise a placeholder PR against the dev-1.18 branch. Tomorrow is the deadline. Please raise PR ASAP.

Thanks! :)

[huffmanca]

@VineethReddy02 ,
I've created kubernetes/website#19354 as a placeholder for the doc update.

[irvifa]

@huffmanca Thanks, I've updated the sheet..

[helayoty]

Hey @huffmanca Code freeze is today midnight. It does not look like your PR has merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push?

[huffmanca]

@helayoty ,

It's been reviewed and approved by the storage team, and I've pinged the API reviewer. I'm hoping he'll be able to take a look at it today.

[helayoty]

/milestone clear

[helayoty]

The Code freeze is in effect now. You may need to file an exception.

[jeremyrickard]

/milestone v1.18

The PR for this had appropriate approval and milestone assigned prior to code freeze, so we'll add this back.

[palnabarun]

/close

(closing this since the KEP has been implemented)

[k8s-ci-robot]

@palnabarun: Closing this issue.

In response to this:

/close

(closing this since the KEP has been implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.