Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Pod information in CSI calls #603

Closed
1 task
jsafrane opened this issue Jul 31, 2018 · 94 comments
Closed
1 task

Pass Pod information in CSI calls #603

jsafrane opened this issue Jul 31, 2018 · 94 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@jsafrane
Copy link
Member

jsafrane commented Jul 31, 2018

Feature Description

API PRs:

Tagging sig-node since it will probably need a new gRPC API in kubelet. Proposal will follow soon. Proposal has been created.

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 31, 2018
@jsafrane jsafrane added this to the v1.12 milestone Jul 31, 2018
@justaugustus
Copy link
Member

justaugustus commented Jul 31, 2018

Thanks @jsafrane! This has been added to the 1.12 tracking spreadsheet.

/assign @jsafrane
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jul 31, 2018
@justaugustus justaugustus added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 31, 2018
@zparnold
Copy link
Member

zparnold commented Aug 20, 2018

Hey there! @jsafrane I'm the wrangler for the Docs this release. Is there any chance I could have you open up a docs PR against the release-1.12 branch as a placeholder? That gives us more confidence in the feature shipping in this release and gives me something to work with when we start doing reviews/edits. Thanks! If this feature does not require docs, could you please update the features tracking spreadsheet to reflect it?

@justaugustus
Copy link
Member

justaugustus commented Sep 5, 2018

@jsafrane --
Any update on docs status for this feature? Are we still planning to land it for 1.12?
At this point, code freeze is upon us, and docs are due on 9/7 (2 days).
If we don't here anything back regarding this feature ASAP, we'll need to remove it from the milestone.

cc: @zparnold @jimangel @tfogo

@msau42
Copy link
Member

msau42 commented Sep 5, 2018

@childsb @gnufied ^

@kfox1111
Copy link

kfox1111 commented Sep 6, 2018

can we pass through volume.Name too? looks like it is already exposed indirectly to the driver by way of the mount path here:
https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/csi/csi_mounter.go#L79
I'd rather use a passed version then parse it out.

@gnufied
Copy link
Member

gnufied commented Sep 6, 2018

This feature is on track for 1.12. I will open placeholder PR for docs shortly.

@kfox1111 you mean PersistentVolume.Name field?

@justaugustus
Copy link
Member

justaugustus commented Sep 6, 2018

@gnufied -- Please keep us posted. Docs PR is overdue at this point.

@kfox1111
Copy link

kfox1111 commented Sep 6, 2018

the pod spec, volume.name. (the name property of https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#volume-v1-core)

@kfox1111
Copy link

kfox1111 commented Sep 6, 2018

Skimming the code, I think its adding the line: "csi.storage.k8s.io/pod.volumeName": c.specVolumeID,

@tfogo
Copy link
Member

tfogo commented Sep 6, 2018

Hi @gnufied, do you have an update on the Docs PR? Please let us know as soon as you have a PR open.

@gnufied
Copy link
Member

gnufied commented Sep 6, 2018

@tfogo now that I think of, traditionally CSI+Kubernetes interface has been documented https://kubernetes-csi.github.io/docs/ rather than on community website. This PR change does not affect any end users and is mostly applicable for CSI plugin authors.

I am wondering if we even need a docs PR to community website. cc @saad-ali

@tfogo
Copy link
Member

tfogo commented Sep 6, 2018

That makes sense. In that case, it's totally fine not to have a PR open in k/website. (Though you should make sure the appropriate docs land in k-csi/docs.)

@justaugustus
Copy link
Member

justaugustus commented Sep 7, 2018

Thanks for the update!

@saad-ali
Copy link
Member

saad-ali commented Sep 7, 2018

Agreed with @gnufied. This change should be documented in kubernetes-csi as it is relevant to CSI driver authors not end users. Tracking that work here.

@ameukam
Copy link
Member

ameukam commented Oct 5, 2018

Hi folks,
Kubernetes 1.13 is going to be a 'stable' release since the cycle is only 10 weeks. We encourage no big alpha features and only consider adding this feature if you have a high level of confidence it will make code slush by 11/09. Are there plans for this enhancement to graduate to alpha/beta/stable within the 1.13 release cycle? If not, can you please remove it from the 1.12 milestone or add it to 1.13?

We are also now encouraging that every new enhancement aligns with a KEP. If a KEP has been created, please link to it in the original post. Please take the opportunity to develop a KEP.

@kacole2
Copy link
Member

kacole2 commented Oct 8, 2018

Hi @jsafrane is this enhancement going to graduate to beta in 1.13? Need a confirmation so it can be tracked properly. thanks!

@jsafrane
Copy link
Member Author

jsafrane commented Oct 12, 2018

Yes, we want beta in 1.13

@kacole2
Copy link
Member

kacole2 commented Oct 12, 2018

/milestone v1.13

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.12, v1.13 Oct 12, 2018
@kacole2 kacole2 added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Oct 16, 2018
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 15, 2020
@helayoty helayoty added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 15, 2020
@irvifa
Copy link
Member

irvifa commented Feb 9, 2020

Hello @gnufied I'm one of the v1.18 docs shadows.
Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions!

@irvifa
Copy link
Member

irvifa commented Feb 19, 2020

Hello @gnufied I'm one of the v1.18 docs shadows.

Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions!

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 24, 2020

Hey @gnufied,

For 1.17 it looks like this missed code freeze because kubernetes/kubernetes#84814 didn't merge. It still looks like it has not merged. Are there any other k/k PRs that need to be tracked for this issue? We're about a week out from code freeze, which is on 05 March 2020.

@huffmanca
Copy link
Contributor

huffmanca commented Feb 24, 2020

@jeremyrickard ,

I'm still working on this PR, and hoping to have it ready for review this week. There are no other k/k PRs to my knowledge regarding this issue.

@irvifa ,

Per #603 (comment), this is not a user facing change and no documentation is required in kubernetes/website repo for this change. This will be documented via - https://github.com/kubernetes-csi/docs

@msau42
Copy link
Member

msau42 commented Feb 24, 2020

@huffmanca, we may still need docs on the k8s side for the feature gate.

@VineethReddy02
Copy link

VineethReddy02 commented Feb 27, 2020

Hi @huffmanca @msau42
Does this feature need any user-facing guide under k8s/website? If so please raise a placeholder PR against the dev-1.18 branch. Tomorrow is the deadline. Please raise PR ASAP.

Thanks! :)

@huffmanca
Copy link
Contributor

huffmanca commented Feb 27, 2020

@VineethReddy02 ,
I've created kubernetes/website#19354 as a placeholder for the doc update.

@irvifa
Copy link
Member

irvifa commented Feb 28, 2020

@huffmanca Thanks, I've updated the sheet..

@helayoty
Copy link
Member

helayoty commented Mar 5, 2020

Hey @huffmanca Code freeze is today midnight. It does not look like your PR has merged yet, are you still feeling like you're on track for code freeze for this enhancement? Do you want to defer this to 1.19 based on the reviewer bandwidth? Or try and make a push?

@huffmanca
Copy link
Contributor

huffmanca commented Mar 5, 2020

@helayoty ,

It's been reviewed and approved by the storage team, and I've pinged the API reviewer. I'm hoping he'll be able to take a look at it today.

@helayoty helayoty added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Mar 5, 2020
@helayoty
Copy link
Member

helayoty commented Mar 5, 2020

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Mar 5, 2020
@helayoty
Copy link
Member

helayoty commented Mar 5, 2020

The Code freeze is in effect now. You may need to file an exception.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 6, 2020

/milestone v1.18

The PR for this had appropriate approval and milestone assigned prior to code freeze, so we'll add this back.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 6, 2020
@jeremyrickard jeremyrickard added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Mar 6, 2020
@thockin thockin removed their assignment Mar 27, 2020
@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 27, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/close

(closing this since the KEP has been implemented)

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 29, 2020

@palnabarun: Closing this issue.

In response to this:

/close

(closing this since the KEP has been implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests