Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduling Framework #624

Open
bsalamat opened this issue Oct 1, 2018 · 18 comments

Comments

Projects
None yet
9 participants
@bsalamat
Copy link
Member

commented Oct 1, 2018

Feature Description

  • One-line feature description (can be used as a release note): Implement a scheduling framework where many of the existing and future features of the existing scheduler can be written as plug-ins for the scheduler.
  • Primary contact (assignee): @bsalamat
  • Responsible SIGs: scheduling
  • Design proposal link (KEP): https://github.com/kubernetes/enhancements/blob/master/keps/sig-scheduling/20180409-scheduling-framework.md
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @k82cn @misterikkit
  • Approver (likely from SIG/area to which feature belongs): @k82cn @bsalamat
  • Feature target (which target equals to which milestone):
    • Alpha release target (x.y) 1.15
    • Beta release target (x.y) 1.16
    • Stable release target (x.y)

This is a long term project and requires many changes to the existing scheduler. In order to ensure quality and reliability of the scheduler, we plan to build the features gradually and in steps. The first extension points are targeted for 1.13. We will add more extension points in the future releases. We will prioritize the addition of the extension points based on need for them.

/sig scheduling

@fejta-bot

This comment has been minimized.

Copy link

commented Jan 6, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@mlmhl

This comment has been minimized.

Copy link

commented Jan 7, 2019

/remove-lifecycle stale

@claurence

This comment has been minimized.

Copy link

commented Jan 15, 2019

@bsalamat Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - I don't see a relevant KEP for this issue can you drop the link to the KEP? Thanks

@bsalamat

This comment has been minimized.

Copy link
Member Author

commented Mar 29, 2019

@kacole2

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@kacole2 kacole2 removed the tracked/no label Apr 12, 2019

@justaugustus

This comment has been minimized.

Copy link
Member

commented Apr 28, 2019

/assign @bsalamat

@bsalamat

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

@kacole2 Yes, this feature is going to be alpha in 1.15.
One PR which was merged a while back is referenced above is: kubernetes/kubernetes#70227
Another PR which will be merged soon: kubernetes/kubernetes#75848
I would expect to see a number of more PRs in the new future. I will make sure that they reference this issue.

@kacole2

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

/milestone v1.15
/stage alpha

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 30, 2019

@kacole2 kacole2 added the tracked/yes label Apr 30, 2019

@kacole2

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

@bsalamat, After reviewing your KEP, it's currently in a draft state. It must be "implementable" to be included in 1.15. In addition, it's missing test plans and graduation criteria which is required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019.

@bsalamat

This comment has been minimized.

Copy link
Member Author

commented Apr 30, 2019

@kacole2 Thanks for the reminder. I just sent #1026 to add test plans, graduation criteria, and change status to 'implementable'.

@simplytunde

This comment has been minimized.

Copy link
Member

commented May 13, 2019

Hey @bsalamat Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@bsalamat

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

@simplytunde I created PR for adding documentation to the website. It is not complete, but I will finish it in the next couple of weeks: kubernetes/website#14388

@kacole2

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Hi @bsalamat. Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

I see these issues tagged here but not sure which are required by this issue to be merged:
kubernetes/kubernetes#77998
kubernetes/kubernetes#78001
kubernetes/kubernetes#78002
kubernetes/kubernetes#78004
kubernetes/kubernetes#78006
kubernetes/kubernetes#77566

If you know this will slip, please reply back and let us know. Thanks!

@kacole2

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Hi @bsalamat, today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. However, I did notice these two have been merged previously: kubernetes/kubernetes#70227 and kubernetes/kubernetes#75848. Are there any others that are missing? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@draveness

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

Hi @kacole2, I believe the following merged PRs are related to this feature.

And according to the KEP, only three extension points need to be built in alpha stage(1.15) which has already been merged into master.

  • Extension points for Reserve, Unreserve, and Prebind are built.
  • Integration tests for these extension points are added

cc/ @bsalamat, please correct me if there is something wrong. thanks :)

@kacole2

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

@draveness this is remaining on the tracking sheet for 1.15. All good here.

@kacole2

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Hi @draveness @bsalamat, I'm the 1.16 Enhancement Lead/Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@bsalamat

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

Hi @kacole2. We are graduating this feature to beta in 1.16. There are many PRs to implement the feature. Tracking issues for all those PRs are referenced in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.