In-tree storage plugin to CSI Driver Migration

[davidz627]

Feature Description

• One-line feature description (can be used as a release note): Migrate the internals of the in-tree plugins to call out to CSI Plugins while maintaining the original API
• Primary contact (assignee): @davidz627
• Responsible SIGs: sig-storage
• Design proposal link (community repo): https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/csi-migration.md
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-migration.md
• PRs:
  • In-Tree to CSI Migration logic for PersistentVolume Attach/Detach kubernetes#69830
• Link to e2e and/or unit tests:
  • GCE: https://testgrid.k8s.io/sig-gcp-compute-persistent-disk-csi-driver#Migration%20Kubernetes%20Master%20Driver%20Latest
• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @saad-ali @jsafrane
• Approver (likely from SIG/area to which feature belongs): @saad-ali
• Feature target (which target equals to which milestone):
  • Alpha release: 1.13
  • Beta release: 1.17
  • Stable release target (x.y): 1.19

[davidz627]

/sig storage
/cc @ddebroy

[kacole2]

@davidz627 this release is targeted to be more ‘stable’ and will have an aggressive timeline. Please only include this enhancement for 1.13 if there is a high level of confidence it will meet the following deadlines:
Docs (open placeholder PRs): 11/8
Code Slush: 11/9
Code Freeze Begins: 11/15
Docs Complete and Reviewed: 11/27

Do you feel confident it will make these? If so we can include it for 1.13 tracking. Thanks!

[saad-ali]

@kacole2 This is multi quarter work with other components depending on it so we want to get it started ASAP (this quarter). That said as we approach end of the month @davidz627 and @ddebroy will make a call about if it is feasible to ship something this quarter or not. If not, we will remove it from the 1.13 milestone. For now let's track it.

[tfogo]

Hi @davidz627 and @ddebroy, do you think we will be able to land this in 1.13? Please keep in mind this release has an aggressive timeline and we should only include it if you're confident it will meet the deadlines @kacole2 outlined above. Thanks!

[tfogo]

Also, I'm assuming this enhancement won't need any documentation updates on k/website since it's an internal change. Please let me know if we will need documentation. Thanks!

[davidz627]

@tfogo no documentation required. It's looking like we wont hit our 1.13 target and will target 1.14 instead.
@saad-ali

[AishSundar]

@davidz627 and @saad-ali is it safe to move this out to 1.14? if so I can do that.

[AishSundar]

Synced with @davidz627 offline. This is now punted to 1.14. No revert / rollback needed in k/k because feature is being developed on a separate branch to enable atomic commit for the feature when it's ready

@kacole2 @tfogo

[claurence]

@davidz627 Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th and I want to remind that all enhancements must have a KEP - I don't see a KEP for this issue can you please drop a link for the KEP.

[davidz627]

@claurence Work on this started before the KEP process started so we have a design in the "old" style.
https://github.com/kubernetes/community/blob/b7daf2fdfa7c4984d9236336b4f1ccc9f048db98/contributors/design-proposals/storage/csi-migration.md
We have a significant amount of work planned for the 1.14 release including but not limited to:
kubernetes/kubernetes#71901 <- PR will be broken up into smaller PR's soon
kubernetes/kubernetes#70909
kubernetes/kubernetes#72950

As well as some work that has already merged:
kubernetes/kubernetes#72770

[xing-yang]

/milestone v1.25

[Priyankasaggu11929]

Hello @davidz627 👋, 1.25 Enhancements team here.

Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 16, 2022.

For note, This enhancement is targeting for stage stable for 1.25 (correct me, if otherwise)

Here's where this enhancement currently stands: (updated on June 8, 2022)

• KEP file using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable
• KEP has a updated detailed test plan section filled out
• KEP has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

Looks like for this one, we would need to update the following:

• update the merged enhancement KEP to incorporate more details in the Test Plan section, in furtherance of the goal of increasing reliability across the project.
• update the kep.yaml file to reflect the correct milestones.

For note, the status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you!

[Jiawei0227]

Hey @Priyankasaggu11929 , I will update the kep with the latest template.

[Jiawei0227]

Hey @Priyankasaggu11929 , I updated the test plan in the PR mentioned above.

update the kep.yaml file to reflect the correct milestones.

One question I have tho, this KEP has already gone GA in the previous release. Is there anything I need to do this release as well?

[Priyankasaggu11929]

Hello @Jiawei0227, thanks so much for updating the KEP's Test Plan section real quick. 🙂

One question I have tho, this KEP has already gone GA in the previous release. Is there anything I need to do this release as well?

Not sure I'm the right person to answer the above bit. @xing-yang, could you please add context to ^ ? Thank you so much!

[Priyankasaggu11929]

Thanks @Jiawei0227, with the #3342 merged & Test Plan section updated, this enhancement is ready for the upcoming enhancements freeze 🚀

For note, the status of the enhancement is now tracked. Thank you!

[krol3]

Hello @Jiawei0227 👋, 1.25 Release Docs Shadow here.
This enhancement is marked as ‘Needs Docs’ for 1.25 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.25 branch in the k/website repo. This PR can be just a placeholder at this time, and must be created by August 4.
 Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. 


Thank you!

[Priyankasaggu11929]

Hello @Jiawei0227 👋

Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022.

Please ensure the following items are completed:

• All PRs to the Kubernetes repo that are related to your enhancement are linked in the above issue description (for tracking purposes).
• All PRs are fully merged by the code freeze deadline.
  • CSIMigration feature gate to GA kubernetes#110410

Please verify, if there are any additional k/k PRs besides the ones listed above.

With the listed k/k PRs full merged, the status of the enhancement is marked as tracked.

Please also update the issue description with the relevant links for tracking purpose. Thank you so much!

[Jiawei0227]

Hey @krol3

Sorry for the late reply. Here is the draft PR for the doc: https://github.com/kubernetes/website/pull/35611/files

Will work on the blog PR this week and get it ready soon!

[Jiawei0227]

Hey @Priyankasaggu11929

I believe all the PRs to k8s repo that related to this enhancement are tracked in the comments. This is a relatively long feature and unfortunately the initial feature owner is not working on k8s anymore so I dont have edit access to the issue list.

[Priyankasaggu11929]

Thanks for the update @Jiawei0227.

I figured out that the PR kubernetes/kubernetes#110410 is for 1.25 milestone. And since that is merged. This enhancement is ready for 1.25 code freeze & marked as tracked. 🙂

[Jiawei0227]

Hey @krol3

for the doc change please track this one: kubernetes/website#35685 as well as kubernetes/website#35683