Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate Kustomize into kubectl #633

Closed
Liujingfang1 opened this issue Oct 24, 2018 · 28 comments

Comments

@Liujingfang1
Copy link
Contributor

commented Oct 24, 2018

Feature Description

  • One-line feature description (can be used as a release note): add kustomize subcommand into kubectl
  • Primary contact (assignee): Liujingfang1, monopole
  • Responsible SIGs: sig-cli
  • Design proposal link (community repo): Kustomize subcommand integration
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: pwittrock, soltysh
  • Approver (likely from SIG/area to which feature belongs): pwittrock, soltysh
  • Feature target (which target equals to which milestone): 1.14
    • Stable release target (x.y) 1.14

Kustomize has been developed in its own repo kubernetes-sigs/kustomize for the past few months. It has been iterated for several versions and is in good shape now. This feature is to enable kustomize in kubectl.

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

/sig cli

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

/area kubectl
/kind feature

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

/cc @monopole

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2018

/tracked yes

@kacole2

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

@Liujingfang1 please also tag any PRs within k/k here as well to track progress

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2018

The PR for this change kubernetes/kubernetes#70213

@AishSundar

This comment has been minimized.

Copy link

commented Oct 25, 2018

@Liujingfang1 is this feature entering alpha in 1.13? is the above PR the only one needed? It seems quite size-able to be included in a short 'stability' focussed release, especially past enhancement freeze. Please file an exception with details around why this has to go in this release vs waiting for the next release, what risk could we be introducing adding a huge feature at this point, exiting tests and confidence on the feature stability. We can have further discussions on the exception email. Thanks.

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Oct 25, 2018

@AishSundar Since Kustomize has been well developed in its own repo. If we enable it in kubectl, it can be GA in 1.13. The above PR is the only PR needed. I'll file an exception. Thank you.

@juanvallejo

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

@Liujingfang1 Thanks for opening this. I think there's a few items to resolve as part of adding this feature to kubectl:

  • I agree with @smarterclayton 's comment here that we should come up with a name that fits in with existing commands under the kubectl command tree.
  • I also think we should discuss how Kustomize as a whole will co-exist with existing commands with regards to user experience, etc.

We could start by opening a PR updating the KEP with more details describing the user flow of this feature as a kubectl command, and have some of these discussions in that thread

@kacole2

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

/milestone v1.13
/stage stable

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Oct 25, 2018

I don't agree that this is going to stable in 1.13 until we know the status of the KEP update.

@AishSundar

This comment has been minimized.

Copy link

commented Oct 25, 2018

@smarterclayton, based on @Liujingfang1's responses to the exception process questionnaire and assessing the risk and impact of this feature on rest of k/k, the release team is ok tracking the enhancement for 1.13. But it's completely upto the SIG and all of you to decide whether its ready for GA in this timeframe.

We have decided to timebox the development and and check back on the status of the PR, tests and docs around 11/9, closer to code freeze. If there are still outstanding questions and the PR isnt merged, we will have to punt it to future milestone to avoid late landing changes.

@soltysh

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

I'll second Clayton and Juan's concerns here. We need to update the KEP to match naming scheme within all of kubectl and secondly the linked PR must strictly follow the patterns all of CLI-related PRs are required to get merged.

@soltysh

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

Finally, even though this command was developed and stabilized in external repo this cannot enter kubectl as stable, every change has to go through all 3 stages, it can happen fast (promoting in the next two subsequent releases), but we can't skip that.

@kacole2 kacole2 removed this from the v1.13 milestone Oct 26, 2018

@AishSundar

This comment has been minimized.

Copy link

commented Oct 26, 2018

looks like the SIG is still not entirely onboard with this feature going in 1.13. Since this is a "stability" release, the release team is not comfortable accepting another Alpha enhancement, especially if it still has open questions. At this point, we are going to stop tracking it for 1.13. Please add it to 1.14 or future milestones, when ready.

@justaugustus

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

(Some automation I'm testing accidentally sent out a comment, which I've deleted to not make things confusing. Sorry!)

@Liujingfang1 Liujingfang1 changed the title add kustomize as a subcommand in kubectl integrate Kustomize into kubectl Jan 14, 2019

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Here is the updated KEP for integrating Kustomize into Kubectl #684

@claurence

This comment has been minimized.

Copy link

commented Jan 16, 2019

@Liujingfang1 Hello - I’m the enhancement’s lead for 1.14 and I’m checking in on this issue to see what work (if any) is being planned for the 1.14 release. Enhancements freeze is Jan 29th.

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Jan 16, 2019

@claurence We plan to add kustomize as a subcommand in kubectl in 1.14. This is discussed in the KEP #684 (comment)

@pwittrock

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

/assign @Liujingfang1
/assign @monopole

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

@monopole

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

lgtm; awaiting kubernetes/kubernetes#73033 to close this.

@npentrel

This comment has been minimized.

Copy link

commented Feb 22, 2019

Hey @Liujingfang1 👋 I'm a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@claurence

This comment has been minimized.

Copy link

commented Feb 22, 2019

@Liujingfang1 this issue is closed it looks like - should it no longer be tracked for 1.14?

If it's being tracked for 1.14 looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2019

@claurence The testing is added in the integration PR. It's a change on kubectl and won't affect other components.
We also have another PR for the second KEP https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/kustomize-file-processing-integration.md
This second PR has a bunch of tests.

@npentrel Yes, I think we need doc modifications. We added a new subcommand for kubectl. The kubectl reference docs need to be updated. It seems those pages are generated. How do I update it?

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

@npentrel I created a placeholder PR kubernetes/website#12867
Once I'm done with the code changes, I'll work on this doc PR.

@spiffxp

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

/remove-stage alpha
/stage stable
reconciling with https://bit.ly/k8s114-enhancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.