Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Volume Expansion Through StatefulSets #661

Open
SidakM-zz opened this issue Dec 21, 2018 · 75 comments
Open

Support Volume Expansion Through StatefulSets #661

SidakM-zz opened this issue Dec 21, 2018 · 75 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status

Comments

@SidakM-zz
Copy link

SidakM-zz commented Dec 21, 2018

Enhancement Description

  • One-line enhancement description (can be used as a release note): Allow changes to storage requests in StatefulSets.volumeClaimTemplates to propagate to associated PVCs.
  • Primary contact (assignee): @SidakM
  • Responsible SIGs: sig-apps
  • Design proposal link (community repo): Add StatefulSet Volume Expansion Kep #660, KEP-0661: StatefulSet volume resize #2842
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @janetkuo @gnufied
  • Approver (likely from SIG/area to which enhancement belongs):
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Dec 21, 2018
@SidakM-zz
Copy link
Author

/kind feature
/sig apps

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 21, 2018
@janetkuo janetkuo added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Dec 21, 2018
@janetkuo
Copy link
Member

@kubernetes/sig-apps-feature-requests

@janetkuo janetkuo added this to the v1.14 milestone Dec 21, 2018
@janetkuo janetkuo added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Dec 21, 2018
@claurence
Copy link

@SidakM - Hello I'm the enhancements lead for 1.14. It looks like this issue is targeting 1.14 for alpha can you let me know if that is still planned. Enhancements freeze is Jan 29th and we want all issues to have a KEP associated with them.

@SidakM-zz
Copy link
Author

Hey @claurence ,
Was waiting for a review from @kubernetes/sig-apps-feature-requests . Not sure when one of them will look at it though.

@k8s-ci-robot
Copy link
Contributor

@SidakM: Reiterating the mentions to trigger a notification:
@kubernetes/sig-apps-feature-requests

In response to this:

Hey @claurence ,
Was waiting for a review from @kubernetes/sig-apps-feature-requests . Not sure when one of them will look at it though.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@claurence
Copy link

@SidakM checking in as enhancements freeze is on Tuesday - was the KEP reviewed? Are there any open PRs to track for the 1.14 cycle?

@SidakM-zz
Copy link
Author

@claurence Someone looked and commented but didn't follow up after so I am unsure where its at.

@claurence
Copy link

@SidakM since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019
@delgod
Copy link

delgod commented Feb 4, 2019

@claurence it is critical functionality for stateful applications like databases.
If your run databases - you must to use StatefulSet.
so currently, PVC resize feature is mostly useless without StatefulSet resize.
please include it to 1.14 milestone.

@claurence
Copy link

@delgod because we have passed enhancement freeze and the KEP still is not merged please submit an exception request.

@chino
Copy link

chino commented Apr 5, 2019

Can we see something similar for DaemonSets?

@kacole2
Copy link
Contributor

kacole2 commented Apr 12, 2019

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. Enhancements do require a KEP as well.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@justaugustus
Copy link
Member

/assign @SidakM

@SidakM-zz
Copy link
Author

@gnufied Can we get this in for 1.15?

@kacole2 kacole2 added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Apr 29, 2019
@evillgenius75
Copy link

Hi @SidakM , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements merged into the k/e repo. The KEp is currently still open

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@archetec
Copy link

Why is this feature request keeps getting pushed to one Enhancement to another...? This is very important, not only for databases but also for Kafka clusters in production! Although it's possible to replicate to a new cluster with more storage, and then swtich over, it's not a viable solution. We need this!

@dims
Copy link
Member

dims commented Feb 27, 2023

@harshanarayana i'd recommend talking to the sig-storage leadership - https://github.com/kubernetes/community/tree/master/sig-storage#leadership

try async first (email sig-storage mailing list and slack) as you are in IST. you may have to get on their agenda/calendar (sig storage meeting) if that does not work.

@xing-yang
Copy link
Contributor

This enhancement issue has actually been in our tracking spreadsheet which we go over in every SIG Storage meeting. It has not got an update for while but design discussions just started again on the KEP: #3412

@harshanarayana
Copy link

@xing-yang This is now being actively discussed with the help of @gnufied and @jsafrane . @areller and I are working together on the KEP. Thanks

@Atharva-Shinde Atharva-Shinde removed the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label May 14, 2023
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this issue Sep 8, 2023
Currently we are using StatefulSet volumeClaimTemplate to provision the PVC. However the corresponding StatefulSet field that controls the PVC size is immutable. It is not possible to resize/enlarge the underlying PVC through the StatefulSet spec. See kubernetes/enhancements#661
This commit makes the cache size field immutable until we decide how to implement the resize.
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this issue Sep 11, 2023
Currently we are using StatefulSet volumeClaimTemplate to provision the PVC. However the corresponding StatefulSet field that controls the PVC size is immutable. It is not possible to resize/enlarge the underlying PVC through the StatefulSet spec. See kubernetes/enhancements#661
This commit makes the cache size field immutable until we decide how to implement the resize.
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this issue Sep 29, 2023
Currently we are using StatefulSet volumeClaimTemplate to provision the PVC. However the corresponding StatefulSet field that controls the PVC size is immutable. It is not possible to resize/enlarge the underlying PVC through the StatefulSet spec. See kubernetes/enhancements#661
This commit makes the cache size field immutable until we decide how to implement the resize.
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this issue Oct 9, 2023
Currently we are using StatefulSet volumeClaimTemplate to provision the PVC. However the corresponding StatefulSet field that controls the PVC size is immutable. It is not possible to resize/enlarge the underlying PVC through the StatefulSet spec. See kubernetes/enhancements#661
This commit makes the cache size field immutable until we decide how to implement the resize.
gardener-prow bot pushed a commit to gardener/gardener-extension-registry-cache that referenced this issue Oct 10, 2023
* Make the cache size field immutable

Currently we are using StatefulSet volumeClaimTemplate to provision the PVC. However the corresponding StatefulSet field that controls the PVC size is immutable. It is not possible to resize/enlarge the underlying PVC through the StatefulSet spec. See kubernetes/enhancements#661
This commit makes the cache size field immutable until we decide how to implement the resize.

* Address review comments
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024
@blafry
Copy link

blafry commented Jan 22, 2024

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@ialidzhikov
Copy link

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 22, 2024
@R-Studio
Copy link

@harshanarayana any news on this?

@KlavsKlavsen
Copy link

Yeah - this would really be nice to support - it makes production harder than it needs to be - having to delete and recreate statefulsets - ensuring pods aren't killed with cascade=false

@usharik
Copy link

usharik commented Feb 22, 2024

It's going to be really helpful

@harshanarayana
Copy link

I got side tracked with a few other work and same seem to be the case with @areller . But let me get back to that old Document and put up an updated one for discussion again.

@huww98
Copy link

huww98 commented May 27, 2024

We have created #4650 , and working on it at #4651 . The new KEP allows arbitrary changes to the volumeClaimTemplates, it should cover the use-case of this KEP, and more.

@soltysh
Copy link
Contributor

soltysh commented Jun 10, 2024

@huww98 does this means you're replacing #661 and we should close the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
Status: Needs Triage
Development

No branches or pull requests