Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Out-of-Tree Azure Cloud Provider #667

Closed
andrewsykim opened this issue Jan 2, 2019 · 82 comments
Closed

Support Out-of-Tree Azure Cloud Provider #667

andrewsykim opened this issue Jan 2, 2019 · 82 comments
Assignees
Labels
area/provider/azure Issues or PRs related to azure provider lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Jan 2, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Support Out-of-Tree Azure Cloud Provider by running the cloud-controller-manager
  • Primary contact (assignee):
    @lachie83 @justaugustus @khenidak
  • Responsible SIGs:
    SIG Azure, SIG Cloud Provider
  • KEP: Supporting Out-of-Tree Azure Cloud Provider
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    @justaugustus @khenidak @andrewsykim
  • Approver (likely from SIG/area to which enhancement belongs):
    @justaugustus @khenidak @andrewsykim
  • Enhancement target (which target equals to which milestone):
    • Alpha release target: 1.15
    • Beta release target: 1.20
    • Stable release target: 1.21

Ref #88

/sig azure cloud-provider

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. area/provider/azure Issues or PRs related to azure provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 2, 2019
@justaugustus
Copy link
Member

justaugustus commented Jan 4, 2019

/assign @justaugustus @khenidak @dstrebel @feiskyer
/milestone 1.14
/stage alpha

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 4, 2019

@justaugustus: The provided milestone is not valid for this repository. Milestones in this repository: [v1.13, v1.14]

Use /milestone clear to clear the milestone.

In response to this:

/assign @justaugustus @khenidak @dstrebel @feiskyer
/milestone 1.14
/stage alpha

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 4, 2019
@justaugustus
Copy link
Member

justaugustus commented Jan 4, 2019

(^^ what, is it my first day here?)
/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jan 4, 2019
@andrewsykim
Copy link
Member Author

andrewsykim commented Jan 4, 2019

Forgot to ref kubernetes/kubernetes#50752

@PatrickLang PatrickLang added this to To do in Provider Azure Jan 22, 2019
@lachie83
Copy link
Member

lachie83 commented Jan 26, 2019

@andrewsykim @justaugustus can you please add me as an assignee as I'll run point on getting the KEP together

@justaugustus
Copy link
Member

justaugustus commented Jan 26, 2019

Done!
/assign @lachie83

@andrewsykim
Copy link
Member Author

andrewsykim commented Jan 28, 2019

FYI put together the boiler plate for this KEP here #735

@justaugustus
Copy link
Member

justaugustus commented Jan 29, 2019

Thanks @andrewsykim!
@lachie83 @feiskyer -- please use #735 as the template for the Azure KEP

@claurence
Copy link

claurence commented Jan 30, 2019

@lachie83 @justaugustus @khenidak since the KEP for this issue hasn't been marked "implementable" yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019
@justaugustus justaugustus moved this from To do to In progress in Provider Azure Feb 15, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 12, 2019

I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. Please update the original post with the link to the KEP as well.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@feiskyer feiskyer added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Apr 12, 2019
@feiskyer
Copy link
Member

feiskyer commented Apr 12, 2019

yep, this is on tracked.

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 12, 2019
@feiskyer
Copy link
Member

feiskyer commented Sep 28, 2020

@kikisdeliveryservice thanks for the TIP, would file a PR to address the issues.

Update: KEP updated by PR #2028.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

Thanks @feiskyer the above PR merged looks good!

It is still using the old format, so feel free to update to the new template when you get a chance.

Moving this to tracked on the sheet.

Best,
Kirsten

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Oct 11, 2020

Hi @feiskyer

Since your Enhancement is scheduled to be in 1.20, please keep in mind the important upcoming dates:
Friday, Nov 6th: Week 8 - Docs Placeholder PR deadline
Thursday, Nov 12th: Week 9 - Code Freeze

As a reminder, please link all of your k/k PR as well as docs PR to this issue so we can track them.

Thanks!
Kirsten 😺

@somtochiama
Copy link
Member

somtochiama commented Oct 21, 2020

Hello @lachie83 @justaugustus @khenidak, 1.20 Docs shadow here 👋🏽.
Does this enhancement work planned for 1.20 require any new docs or modification to existing docs?

If so, please follows the steps here to open a PR against dev-1.20 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Nov 6th

Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@feiskyer
Copy link
Member

feiskyer commented Oct 26, 2020

@somtochiama the docs would be updated at https://github.com/kubernetes-sigs/cloud-provider-azure

@somtochiama
Copy link
Member

somtochiama commented Oct 26, 2020

@feiskyer Does any modification need to be made to this website/docs? https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

If not, then you are all good.

@feiskyer
Copy link
Member

feiskyer commented Oct 27, 2020

@feiskyer Does any modification need to be made to this website/docs? https://kubernetes.io/docs/reference/command-line-tools-reference/feature-gates/#feature-gates-for-alpha-or-beta-features

No required modification here.

@annajung
Copy link
Member

annajung commented Nov 1, 2020

Hi @feiskyer

Please keep in mind the important upcoming dates:

As a reminder, please link all of your k/k PR as well as docs PR to this issue for the release team to track.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 10, 2020

Hi @feiskyer

Just a reminder that Code Freeze is coming up in 2 days on Thursday, November 12th. All PRs must be merged by that date, otherwise an Exception is required.

I don't see any PRs linked to this issue, can you confirm that your beta graduation criteria were met: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/azure/20190125-out-of-tree-azure.md#alpha---beta-graduation Was n e2e test added in testgrid, if so can you please link?

Thanks,
Kirsten

@feiskyer
Copy link
Member

feiskyer commented Nov 11, 2020

testgrid jobs have been added here: https://testgrid.k8s.io/provider-azure-cloud-provider-azure

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 11, 2020

Perfect, thanks @feiskyer ! You're all set.

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 7, 2021
@fejta-bot
Copy link

fejta-bot commented Apr 7, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2021
@fejta-bot
Copy link

fejta-bot commented May 7, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 7, 2021
@feiskyer feiskyer added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels May 8, 2021
@feiskyer
Copy link
Member

feiskyer commented May 8, 2021

GA version has been released https://github.com/kubernetes-sigs/cloud-provider-azure/releases/tag/v1.0.0

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 8, 2021

@feiskyer: Closing this issue.

In response to this:

GA version has been released https://github.com/kubernetes-sigs/cloud-provider-azure/releases/tag/v1.0.0

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Provider Azure automation moved this from KEPs to Done May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/azure Issues or PRs related to azure provider lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
Development

No branches or pull requests