Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Out-of-Tree OpenStack Cloud Provider #669

Closed
andrewsykim opened this issue Jan 2, 2019 · 26 comments
Closed

Support Out-of-Tree OpenStack Cloud Provider #669

andrewsykim opened this issue Jan 2, 2019 · 26 comments
Assignees
Labels
area/provider/openstack Issues or PRs related to openstack provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Milestone

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Jan 2, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):
    Support Out-of-Tree OpenStack Cloud Provider by running the cloud-controller-manager
  • Primary contact (assignee):
    @dims @hogepodge
  • Responsible SIGs:
    SIG OpenStack, SIG Cloud Provider
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
    @dims @hogepodge @andrewsykim
  • Approver (likely from SIG/area to which enhancement belongs):
    @dims @hogepodge @andrewsykim
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y)
    • Beta release target (x.y)
    • Stable release target (x.y)

Ref #88

/sig openstack cloud-provider

@k8s-ci-robot k8s-ci-robot added area/provider/openstack Issues or PRs related to openstack provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jan 2, 2019
@hogepodge
Copy link
Member

hogepodge commented Jan 2, 2019

/assign @hogepodge

@andrewsykim
Copy link
Member Author

andrewsykim commented Jan 24, 2019

@hogepodge can you assign a stage target for v1.14?

@claurence claurence added this to the v1.14 milestone Jan 28, 2019
@hogepodge
Copy link
Member

hogepodge commented Jan 28, 2019

/stage alpha

KEP to be sent up soon to enumerate graduation criteria. We have a stable external provider, but need to engage with the release process to move this to officially stable.

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 28, 2019
@andrewsykim
Copy link
Member Author

andrewsykim commented Jan 28, 2019

FYI put together the boiler plate for this KEP here #735

@claurence
Copy link

claurence commented Jan 30, 2019

@dims @hogepodge since the KEP for this issue hasn't been merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 12, 2019

Hello @hogepodge , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. Please attach a KEP to the original post as well.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@hogepodge
Copy link
Member

hogepodge commented Apr 16, 2019

@kacole2 I'll follow up with the team tomorrow. We should definitely be able to say we're on stable since we've been running the out of tree provider for more than a year now, and encouraging users to adopt that rather than use the in-tree provider.

cc @adisky

@evillgenius75
Copy link

evillgenius75 commented Jul 10, 2019

Hi @hogepodge @andrewsykim , I'm the 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet.

I see the KEP is still under provisional state, as a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@palnabarun
Copy link
Member

palnabarun commented Oct 1, 2019

Hey there @hogepodge, 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha/beta/stable in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@hogepodge
Copy link
Member

hogepodge commented Oct 1, 2019

I'm no longer running the project, but the external provider is stable and in wide usage. Adding @adisky who is the new point of contact.

@hogepodge
Copy link
Member

hogepodge commented Oct 1, 2019

/assign @adisky

@palnabarun
Copy link
Member

palnabarun commented Oct 1, 2019

Thanks for the updates. :)

@mrbobbytables
Copy link
Member

mrbobbytables commented Oct 14, 2019

@adisky It looks like you have a WIP KEP PR, is this something you'd like tracked for 1.17? If so, the KEP must be merged meet the following criteria:

  • in an implementable state
  • Have a test plan
  • Have graduation criteria

If you could ack back soon if possible, it'd be greatly appreciated 👍

Thanks!

/unassign hogepodge
(from earlier comment)

@adisky
Copy link
Contributor

adisky commented Oct 14, 2019

@mrbobbytables it is implemented long back, testing is also done, have graduation criteria too, it is WIP as some fields are TODO's

@palnabarun
Copy link
Member

palnabarun commented Oct 16, 2019

@adisky -- Unfortunately the deadline for the 1.17 Enhancement freeze has passed and the KEP is still not merged. For now, this is being removed from the milestone and 1.17 tracking sheet. If there is a need to get this in, please file an enhancement exception.

@fejta-bot
Copy link

fejta-bot commented Jan 14, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2020
@palnabarun
Copy link
Member

palnabarun commented Jan 14, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2020
@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jan 14, 2020

@adisky the KEP is still showing status provisional, even after #1303 merged. Can you update it to implemented if everything is done, and close this issue?

Or, is there still work to be done, such as removing the in-tree provider?

@adisky
Copy link
Contributor

adisky commented Jan 21, 2020

@johnbelamaric the work for removing intree provider is still remaining.

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jan 21, 2020

Is that part of this KEP or will it be done as part of https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/20190125-removing-in-tree-providers.md ?

If it's not needed to say that this KEP is "done", and there is no additional work needed for this KEP (it is fully completed) then you would:

  1. go into the actual KEP file and create a PR that sets the header status to implemented, and updates the implementation history.
  2. Mark that it fixes this issue

When that merges it should close this issue.

@adisky
Copy link
Contributor

adisky commented Jan 22, 2020

cc @ramineni would you be able to create a PR for marking this KEP as implemented?

@fejta-bot
Copy link

fejta-bot commented Apr 21, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 27, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2020
@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 4, 2020

This feature is complete and the KEP marked implemented. Any remaining work to remove the in-tree provider is tracked under a different feature.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 4, 2020

@johnbelamaric: Closing this issue.

In response to this:

This feature is complete and the KEP marked implemented. Any remaining work to remove the in-tree provider is tracked under a different feature.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

palnabarun commented May 4, 2020

/milestone v1.17

(since the enhancement was completed in that cycle)

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/openstack Issues or PRs related to openstack provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status
Projects
None yet
Development

No branches or pull requests