Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Out-of-Tree vSphere Cloud Provider #670

Closed
andrewsykim opened this issue Jan 2, 2019 · 27 comments · Fixed by #1677
Closed

Support Out-of-Tree vSphere Cloud Provider #670

andrewsykim opened this issue Jan 2, 2019 · 27 comments · Fixed by #1677
Assignees
Labels
area/provider/vmware Issues or PRs related to vmware provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Jan 2, 2019

Enhancement Description

Ref #88

/sig vmware cloud-provider

@k8s-ci-robot k8s-ci-robot added area/provider/vmware Issues or PRs related to vmware provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Jan 2, 2019
@frapposelli
Copy link
Member

frapposelli commented Jan 24, 2019

/milestone v1.14
/stage beta

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Jan 24, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Jan 24, 2019
@andrewsykim
Copy link
Member Author

andrewsykim commented Jan 29, 2019

FYI put together the boiler plate for this KEP here #735

@claurence
Copy link

claurence commented Jan 30, 2019

@frapposelli @cantbewong since the KEP for this issue hasn't been merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019
@frapposelli
Copy link
Member

frapposelli commented Jan 30, 2019

@claurence exception filed, KEP is in review as #767

@claurence claurence added this to the v1.14 milestone Jan 30, 2019
@claurence
Copy link

claurence commented Jan 30, 2019

exception approved - adding this back to the 1.14 milestone

@frapposelli
Copy link
Member

frapposelli commented Jan 31, 2019

@claurence PR #767 and #787 merged, we should be GTG.

@ameukam
Copy link
Member

ameukam commented Feb 7, 2019

/label tracked/yes

@npentrel
Copy link

npentrel commented Feb 22, 2019

Hey @cantbewong @frapposelli 👋! I'm a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@ameukam
Copy link
Member

ameukam commented Feb 27, 2019

Hello @frapposelli, 1.14 enhancement shadow here. Code Freeze is March 7th and all PRs must be merged by then to your issue to make the 1.14 release. What open K/K PRs do you still have that need to merge? Thanks

@frapposelli
Copy link
Member

frapposelli commented Feb 27, 2019

@ameukam @npentrel we should be good both on the PR and Docs front for this one, thanks!

@npentrel
Copy link

npentrel commented Mar 2, 2019

Just to confirm @frapposelli, you are saying this does not require docs changes?

@kacole2
Copy link
Member

kacole2 commented Apr 12, 2019

Hello @frapposelli , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Apr 12, 2019
@kacole2 kacole2 added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Apr 12, 2019
@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @frapposelli @cantbewong

@evillgenius75
Copy link

evillgenius75 commented Jul 10, 2019

Hi @frapposelli @cantbewong, I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, The current milestone will be clear and the tracking status will be tracked/no.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@annajung
Copy link
Member

annajung commented Oct 2, 2019

Hello @frapposelli @cantbewong , 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

  • The current release schedule is

    • Monday, September 23 - Release Cycle Begins
    • Tuesday, October 15, EOD PST - Enhancements Freeze
    • Thursday, November 14, EOD PST - Code Freeze
    • Tuesday, November 19 - Docs must be completed and reviewed
    • Monday, December 9 - Kubernetes 1.17.0 Released
  • A Kubernetes Enhancement Proposal (KEP) must meet the following criteria before Enhancement Freeze to be accepted into the release

    • PR is merged in
    • In an implementable state
    • Include test plan and graduation criteria
  • All relevant k/k PRs should be listed in this issue

@fejta-bot
Copy link

fejta-bot commented Dec 31, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2019
@palnabarun
Copy link
Member

palnabarun commented Jan 9, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2020
@frapposelli
Copy link
Member

frapposelli commented Jan 9, 2020

/stage stable
/milestone v1.18

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jan 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 9, 2020
@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jan 14, 2020

@frapposelli Release team enhancements shadow here. It looks like this is planned for 1.18, I will add it to the spreadsheet.

@johnbelamaric johnbelamaric added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 14, 2020
@johnbelamaric
Copy link
Contributor

johnbelamaric commented Jan 14, 2020

@frapposelli if you plan to got to stable, can we get some better graduation criteria? All it says now is that the criteria is that it is "complete". I guess that means "feature parity with in-tree". What about removal of in-tree? Can you clarify please?

@irvifa
Copy link
Member

irvifa commented Feb 9, 2020

Hello @frapposelli @cantbewong I'm one of the v1.18 docs shadows.
Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions!

@frapposelli
Copy link
Member

frapposelli commented Feb 9, 2020

@johnbelamaric the out of tree provider for vSphere is feature complete and has feature parity with in-tree.

Removal of in-tree providers is tracked as a larger item by the extraction workgroup under SIG cloud provider. Currently all cloud providers are staged under legacy-cloud-providers in k/k, the plan of record is to remove all them at once in Kubernetes 1.21.

@irvifa
Copy link
Member

irvifa commented Feb 10, 2020

@frapposelli Could you please create a placeholder PR to dev-1.18 for the documentation? Thanks!

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Feb 11, 2020

@frapposelli Ok, thanks. So, the only thing left are docs?

@irvifa
Copy link
Member

irvifa commented Feb 19, 2020

Hello @frapposelli I'm one of the v1.18 docs shadows.

Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions!

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Mar 27, 2020

Hi @frapposelli, since this is now complete, can you please mark the KEP as implemented and mark that PR as fixing this issue (closing the issue)? Thanks!

@palnabarun
Copy link
Member

palnabarun commented Apr 9, 2020

@frapposelli Ping. Can you please mark the corresponding KEP as implemented? 🙂

frapposelli added a commit that referenced this issue Apr 9, 2020
@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/vmware Issues or PRs related to vmware provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet