Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish CRD OpenAPI Schema #692

Closed
roycaihw opened this issue Jan 16, 2019 · 35 comments
Closed

Publish CRD OpenAPI Schema #692

roycaihw opened this issue Jan 16, 2019 · 35 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@roycaihw
Copy link
Member

roycaihw commented Jan 16, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Serve validation schema for Custom Resources from kube-apiserver
  • Primary contact (assignee): @roycaihw
  • Responsible SIGs: SIG API Machinery
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which enhancement belongs):
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.14)
    • Beta release target (1.15)
    • Stable release target (1.16)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

/sig api-machinery

1.14
KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-api-machinery/00xx-publish-crd-openapi.md
Documentation: kubernetes/website#12910
Implementation: kubernetes/kubernetes#71192
Testing-related: kubernetes/test-infra#11618, kubernetes/kubernetes#74832

1.15
Promotion to beta: kubernetes/kubernetes#77825
Documentation: kubernetes/website#14583

1.16
Promotion to GA: kubernetes/kubernetes#81965
Documentation: kubernetes/website#15982
Bug fixes:

Metrics: kubernetes/kubernetes#81786

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 16, 2019
@mbohlool mbohlool added this to the v1.14 milestone Jan 28, 2019
@liggitt liggitt added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Jan 31, 2019
@spiffxp spiffxp added the tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team label Feb 7, 2019
@claurence
Copy link

claurence commented Feb 7, 2019

@liggitt @roycaihw - I see y'all are hoping to target 1.14 for this milestone - I don't see a KEP associated with this issue - was one merged already?

@spiffxp
Copy link
Member

spiffxp commented Feb 7, 2019

/milestone clear
If this is proven to have a merged KEP prior to Feb 4 we can add this back

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Feb 7, 2019
@liggitt
Copy link
Member

liggitt commented Feb 7, 2019

this is ongoing work described in https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/customresources-validation.md#client-side-validation

what is the desired granularity for copying that document into a KEP to unblock work on one aspect of it in this release?

@spiffxp
Copy link
Member

spiffxp commented Feb 7, 2019

I need enough to understand what the implications are from a testing and upgrade/downgrade perspective

@spiffxp
Copy link
Member

spiffxp commented Feb 7, 2019

My desire is not to expect copy-pasta from that doc into a KEP, I am OK with linking out where it makes sense.

@roycaihw
Copy link
Member Author

roycaihw commented Feb 8, 2019

KEP sent out at #821. It's still a draft but comments are welcome

@claurence
Copy link

claurence commented Feb 8, 2019

@roycaihw @liggitt thanks - since we have passed enhancement freeze and want all issues targeting 1.14 to have a KEP merged by enhancements freeze this issue will require an exception for the 1.14 milestone - please submit one https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@liggitt
Copy link
Member

liggitt commented Feb 15, 2019

KEP is now implementable, exception requested at https://groups.google.com/forum/#!msg/kubernetes-milestone-burndown/QKSQVXBPeAQ/dv9Y3qsyAQAJ and acked by sig lead

@claurence
Copy link

claurence commented Feb 27, 2019

exception request was approved adding back to 1.14 milestone

@claurence claurence added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Feb 27, 2019
@claurence claurence added this to the v1.14 milestone Feb 27, 2019
@lledru
Copy link
Member

lledru commented Mar 5, 2019

@roycaihw @liggitt, 1.14 enhancement shadow here.
What should be merged before code freeze? is #71192 the only k/k PR you need to merge ?
Moreover i think you dont have test plan inside the KEP, could you add it quickly please? Thanks a lot

@roycaihw
Copy link
Member Author

roycaihw commented Mar 5, 2019

@lledru we aim to merge kubernetes/kubernetes#71192 (the feature) and kubernetes/kubernetes#74832 (kubectl regression test, doesn't depend on the new feature) before code freeze

the two PRs cover the test plan that we put in the KEP graduation criteria

@spiffxp
Copy link
Member

spiffxp commented Mar 19, 2019

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Mar 19, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 12, 2019

Hello @roycaihw , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

@kacole2 kacole2 removed this from the v1.14 milestone Apr 12, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 12, 2019
@sttts
Copy link
Contributor

sttts commented Apr 12, 2019

@kacole2 yes, this is still planned to get promoted to beta in 1.15.

@sttts
Copy link
Contributor

sttts commented Apr 12, 2019

@roycaihw can you prepare a PR to switch it over?

@daminisatya
Copy link
Member

daminisatya commented May 18, 2019

Hey, @roycaihw I'm the v1.15 docs release shadow.

I see that you are targeting the beta version of this enhancement for the 1.15 release. Does this require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

@daminisatya
Copy link
Member

daminisatya commented May 27, 2019

@roycaihw

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

@kacole2
Copy link
Member

kacole2 commented May 28, 2019

Hi @roycaihw . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

I'm seeing these PRs merged. Is there anything else we should be tracking?
kubernetes/kubernetes#71192
kubernetes/kubernetes#77825

If you know this will slip, please reply back and let us know. Thanks!

@roycaihw
Copy link
Member Author

roycaihw commented May 28, 2019

@daminisatya @kacole2 Thanks for the reminder. The PR tracking looks good. In 1.15 we did kubernetes/kubernetes#77825 and it's merged. I will open a documentation placeholder and link it here

@sttts
Copy link
Contributor

sttts commented May 28, 2019

Docs PR kubernetes/website#14583

@roycaihw can you update the issue description?

@roycaihw
Copy link
Member Author

roycaihw commented May 28, 2019

@sttts done. Thanks

@daminisatya
Copy link
Member

daminisatya commented May 29, 2019

Thank you @sttts @roycaihw

@liggitt
Copy link
Member

liggitt commented May 30, 2019

PRs being tracked for this feature:
kubernetes/kubernetes#78521
kubernetes/kubernetes#78453

@kacole2
Copy link
Member

kacole2 commented Jul 8, 2019

Hi @roycaihw , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.6 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@roycaihw
Copy link
Member Author

roycaihw commented Jul 9, 2019

@kacole2 The plan is to go stable in 1.16. I will keep the issue updated when the coding begins

@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

/stage stable
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jul 9, 2019
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.15, v1.16 Jul 9, 2019
@VineethReddy02
Copy link

VineethReddy02 commented Aug 1, 2019

Hi @roycaihw, I'm the v1.16 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday,August 23rd. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Thanks!

@yue9944882
Copy link
Contributor

yue9944882 commented Aug 2, 2019

/sub

@kacole2
Copy link
Member

kacole2 commented Aug 26, 2019

@liggitt @roycaihw code freeze for 1.16 is on Thursday 8/29. Are there any outstanding k/k PRs that still need to be merged for this to go Stable?

@liggitt
Copy link
Member

liggitt commented Aug 27, 2019

kubernetes/kubernetes#81965 is the only outstanding PR

@liggitt
Copy link
Member

liggitt commented Sep 3, 2019

docs ready for review in kubernetes/website#15982

@liggitt
Copy link
Member

liggitt commented Sep 19, 2019

Released as stable in v1.16.0

Post-GA work tracked in https://github.com/orgs/kubernetes/projects/28

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 19, 2019

@liggitt: Closing this issue.

In response to this:

Released as stable in v1.16.0

Post-GA work tracked in https://github.com/orgs/kubernetes/projects/28

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrbobbytables mrbobbytables removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests