New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish CRD OpenAPI Schema #692

Open
roycaihw opened this Issue Jan 16, 2019 · 8 comments

Comments

Projects
None yet
6 participants
@roycaihw
Copy link
Member

roycaihw commented Jan 16, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Serve validation schema for Custom Resources from kube-apiserver
  • Primary contact (assignee): @roycaihw
  • Responsible SIGs: SIG API Machinery
  • Design proposal link (community repo):
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred:
  • Approver (likely from SIG/area to which enhancement belongs):
  • Enhancement target (which target equals to which milestone):
    • Stable release target (1.14)

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

/sig api-machinery
ref: kubernetes/kubernetes#71192
KEP: #821

@roycaihw roycaihw referenced this issue Jan 17, 2019

Open

Publish CRD openapi #71192

2 of 2 tasks complete

@mbohlool mbohlool added this to the v1.14 milestone Jan 28, 2019

@spiffxp spiffxp added the tracked/no label Feb 7, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 7, 2019

@liggitt @roycaihw - I see y'all are hoping to target 1.14 for this milestone - I don't see a KEP associated with this issue - was one merged already?

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 7, 2019

/milestone clear
If this is proven to have a merged KEP prior to Feb 4 we can add this back

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Feb 7, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 7, 2019

this is ongoing work described in https://github.com/kubernetes/community/blob/master/contributors/design-proposals/api-machinery/customresources-validation.md#client-side-validation

what is the desired granularity for copying that document into a KEP to unblock work on one aspect of it in this release?

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 7, 2019

I need enough to understand what the implications are from a testing and upgrade/downgrade perspective

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 7, 2019

My desire is not to expect copy-pasta from that doc into a KEP, I am OK with linking out where it makes sense.

@roycaihw

This comment has been minimized.

Copy link
Member Author

roycaihw commented Feb 8, 2019

KEP sent out at #821. It's still a draft but comments are welcome

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 8, 2019

@roycaihw @liggitt thanks - since we have passed enhancement freeze and want all issues targeting 1.14 to have a KEP merged by enhancements freeze this issue will require an exception for the 1.14 milestone - please submit one https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 15, 2019

KEP is now implementable, exception requested at https://groups.google.com/forum/#!msg/kubernetes-milestone-burndown/QKSQVXBPeAQ/dv9Y3qsyAQAJ and acked by sig lead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment