-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Volume Ownership Change #695
Comments
/sig api-machinery |
Hello @mattsmithdatera , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. I also do not see a KEP. All enhancements require one to be included. Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly. |
/assign @mattsmithdatera @gnufied |
Hi @mattsmithdatera I'm a 1.16 Enhancement Shadow. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheetand the correct milestone and tracked label is applied. As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements. I see that the KEP #696 has yet to be merged. Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29. Thank you. |
Hello @mattsmithdatera / @gnufied -- 1.17 Enhancement Shadow here! 🙂 I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?
Thank you! 🔔Friendly Reminder The current release schedule is
|
We are not doing anything for this in 1.17, but this is a problem that we are aiming to solve for 1.18. |
Hey @mattsmithdatera / @gnufied -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level? The current release schedule is: Tuesday, January 28th EOD PST - Enhancements Freeze To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined. If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. Thanks! |
We could not make this feature in 1.17 timeline but we are trying to get this done as an alpha feature in 1.18. I have submitted a KEP with updated design #1478 to address some of the issues raised in original design. |
Thanks @gnufied for the update. Kindly include all k/k PRs in the issue so they can be tracked |
/milestone v1.18 |
Hello @mattsmithdatera @gnufied I'm one of the v1.18 docs shadows. If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions! |
Hello @mattsmithdatera @gnufied I'm one of the v1.18 docs shadows. Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so) If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions! |
Hey @gnufied following up, can you please list out k/k PRs for this enhancement? We are getting close to code freeze on 05 March 2020. Thanks |
@jeremyrickard thanks. The first PR that implements necessary api change is - https://github.com/kubernetes/kubernetes/pull/88488/files Update: Same PR kubernetes/kubernetes#88488 contains both API change and implementation. |
Hello @gnufied Thanks! :) |
Hi @gnufied Following up, is this enhancement need any docs? If it is can you please create a placeholder PR? Since the deadline should be today.. Thanks! |
it does need docs PR and placeholder PR is - kubernetes/website#19391 |
/remove-lifecycle rotten |
/milestone v1.23 |
Hi @gnufied @mattsmithdatera 👋🏽 1.23 Enhancements shadow here. Just checking in as we are getting closer to the enhancements freeze deadline at 11:59 pm PST on Thursday 09/09. Looks like we are all set for the enhancements freeze 🎉 |
Hi @gnufied @mattsmithdatera 👋🏼 1.23 Docs Shadow here. This enhancement is marked as Needs Docs for the 1.23 release. Please follow the steps detailed in the documentation to open a PR against the Also, if needed take a look at Documenting for a release to familiarize yourself with the docs requirement for the release. Thanks! |
Hi @gnufied @mattsmithdatera 👋🏽 1.23 Enhancements shadow here. I see that the PR kubernetes/kubernetes#73232 is closed. For this issue to be included in the release please make sure to
Marking this issue as |
The following PR is for this enhancement issue and it is already merged: |
I am working on docs PR for this feature. Please stay tuned, I will update this thread. |
Docs PR - kubernetes/website#30553 |
Hi all, |
I think there is a bug in ceph-csi driver where it explicitly chmods volume path on nodestage which results in dropping setgid bit expected by kubelet - ceph/ceph-csi#2697 Once that is fixed IIRC it works as expected. cc @humblec @Madhu-1 |
Correct @gnufied , I am in path of fixing it.. Initial testing was done with the change in place and it is working as expected. will be revisiting the fix PR soon. |
Hi @gnufied @mattsmithdatera , 1.24 Enhancements Lead here. Could you please update this enhancements's KEP status to Thanks :) |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enhancement Description
PermissionChangePolicy
string field inPersistentVolumeClaimVolumeSource
struct and related conditional volume ownership change behaviorPull request implementing this change: kubernetes/kubernetes#73232
The text was updated successfully, but these errors were encountered: