New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet Resource Metrics Endpoint #727

Open
dashpole opened this Issue Jan 24, 2019 · 10 comments

Comments

Projects
None yet
6 participants
@dashpole
Copy link
Contributor

dashpole commented Jan 24, 2019

Enhancement Description

  • One-line enhancement description: Introduce a new kubelet endpoint for serving metrics about first-class resources.
  • Primary contact: @dashpole
  • Responsible SIGs: Sig-Node, Sig-Instrumentation
  • Design proposal link: #726
  • Link to e2e and/or unit tests: Coming soon
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @DirectXMan12
  • Approver: @dchen1107 @brancz
  • Enhancement target (which target equals to which milestone):
    • Alpha release target 1.14
    • Beta release target TBD
    • Stable release target TBD
@dashpole

This comment has been minimized.

Copy link
Contributor Author

dashpole commented Jan 24, 2019

/sig node

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 25, 2019

@dashpole I've added this enhancement to the 1.14 tracking doc since it looks like y'all are targeting alpha here.

Are there any open PRs for this that should be tracked as well for it to be added to 1.14 as alpha?

@dashpole

This comment has been minimized.

Copy link
Contributor Author

dashpole commented Jan 25, 2019

@claurence I am going to wait until the KEP is approved to open PRs. Ill reference this feature issue from the PRs if/when that happens

@WanLinghao

This comment has been minimized.

Copy link

WanLinghao commented Jan 28, 2019

/cc

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 30, 2019

@dashpole since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019

@claurence claurence added tracked/no and removed tracked/yes labels Jan 30, 2019

@dashpole

This comment has been minimized.

Copy link
Contributor Author

dashpole commented Jan 30, 2019

@claurence where is it specified that KEPs must be merged by feature freeze?
In previous releases the only requirement was to have this issue open.

@dashpole

This comment has been minimized.

Copy link
Contributor Author

dashpole commented Jan 30, 2019

@claurence
https://github.com/kubernetes/sig-release/tree/master/releases/release-1.14#enhancements-freeze states:

"By Tuesday January 29, 2019 all enhancements landing in v1.14.0 must ... have an associated KEP merged or in progress in kubernetes/enhancements, linked to in the description of the tracking issue"

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 30, 2019

Hey @dashpole apologies as our docs have been changing a bit today - given feedback we've heard we are going to be lenient with KEPs though we want them merged by Feb 4th.

@claurence claurence added this to the v1.14 milestone Feb 6, 2019

@claurence claurence added tracked/yes and removed tracked/no labels Feb 7, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 7, 2019

Added back to 1.14 per exception request submitted and approved

@npentrel

This comment has been minimized.

Copy link

npentrel commented Feb 22, 2019

Hey @dashpole 👋! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment