Kubelet Resource Metrics Endpoint

[dashpole]

Enhancement Description

• One-line enhancement description: Introduce a new kubelet endpoint for serving metrics about first-class resources.

• Primary contact: @dashpole

• Responsible SIGs: Sig-Node, Sig-Instrumentation

• KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/727-resource-metrics-endpoint

• Link to e2e and/or unit tests: Coming soon

• Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @DirectXMan12

• Approver: @dchen1107 @brancz

• Enhancement target (which target equals to which milestone):

  • Alpha release target 1.14
  • Beta release target 1.27
  • Stable release target 1.29

• v1alpha1 endpoint

  • KEP (k/enhancements) update PR(s): [KEP] Kubelet Resource Metrics Endpoint #726
  • Code (k/k) update PR(s): Add kubelet resource metrics v1alpha1 endpoint kubernetes#73946
  • Docs (k/website) update(s): Documentation for Kubelet Resource Metrics Endpoint website#12934

• metric-server

  • metrics server v0.6 Implement using /metrics/resource Kubelet endpoint kubernetes-sigs/metrics-server#777 ; Bump metrics-server to v0.6.3 kubernetes#117120 bump v0.6.3 (v1.28)

• Stable

  • KEP (k/enhancements) update PR(s):
    • Update KEP for Kubelet Resource Metrics endpoint GA release #4037
  • Code (k/k) update PR(s): Graduate kubelet resource metrics to GA kubernetes#116897
  • Docs (k/website) update(s):

[dashpole]

/sig node

[claurence]

@dashpole I've added this enhancement to the 1.14 tracking doc since it looks like y'all are targeting alpha here.

Are there any open PRs for this that should be tracked as well for it to be added to 1.14 as alpha?

[dashpole]

@claurence I am going to wait until the KEP is approved to open PRs. Ill reference this feature issue from the PRs if/when that happens

[WanLinghao]

/cc

[claurence]

@dashpole since the KEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

[dashpole]

@claurence where is it specified that KEPs must be merged by feature freeze?
In previous releases the only requirement was to have this issue open.

[dashpole]

@claurence
https://github.com/kubernetes/sig-release/tree/master/releases/release-1.14#enhancements-freeze states:

"By Tuesday January 29, 2019 all enhancements landing in v1.14.0 must ... have an associated KEP merged or in progress in kubernetes/enhancements, linked to in the description of the tracking issue"

[claurence]

Hey @dashpole apologies as our docs have been changing a bit today - given feedback we've heard we are going to be lenient with KEPs though we want them merged by Feb 4th.

[claurence]

Added back to 1.14 per exception request submitted and approved

[npentrel]

Hey @dashpole 👋! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[kacole2]

Hello @dashpole , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

/milestone clear

[dashpole]

@kacole2 I don't have any plans to graduate this in 1.15

[logicalhan]

/cc @Richabanker

(in case she's interested in picking this one up)

[Richabanker]

/assign

[SergeyKanzhelev]

@Richabanker can you please send the PR to update kep.yaml for this enhancement if you target it for 1.28

[Richabanker]

Ack'd.

[Richabanker]

PR to update the KEP: #3994

[SergeyKanzhelev]

PR to update the KEP: #3994

Have you closed this intentionally?

[Richabanker]

oh didn't realize I closed this accidentally while cleaning up my fork. Apologies! Created a new PR here

[SergeyKanzhelev]

/milestone v1.28
/label lead-opted-in

[Atharva-Shinde]

Hello @Richabanker @dashpole 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting for stage stable for v1.28

Question:
Is this enhancement directly jumping from stage alpha to stable?

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone:v1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

• Update kep.yaml with latest information using the latest kep.yaml template.
• The KEP Readme looks quite out-dated. Update the KEP Readme.md file to be in compliance with the latest template. Some of the work will include updating Test Plan section, adding and addressing the Production Readiness Review Questionnaire etc.
• Add a .yaml file for this KEP under kubernetes/enhancements/keps/prod-readiness/sig-node folder with name 727.yaml. Refer 693.yaml to fill in the information. We need to add approvers for every stage this KEP have been through and is currently targeting.
• Ultimately with all the changes addressed we'll need to get this KEP approved by the PRR team.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

[logicalhan]

Hello @Richabanker @dashpole 👋, Enhancements team here.

Just checking in as we approach Enhancements freeze on Thursday, 16th June 2023.

Looks like this enhancement is targeting for stage stable for v1.28

Question: Is this enhancement directly jumping from stage alpha to stable?

Here's where this enhancement currently stands:

• KEP readme using the latest template has been merged into the k/enhancements repo.
• KEP status is marked as implementable for latest-milestone:v1.28
• KEP readme has a updated detailed test plan section filled out
• KEP readme has up to date graduation criteria
• KEP has a production readiness review that has been completed and merged into k/enhancements.

For this KEP, we would need to update the following:

• Update kep.yaml with latest information using the latest kep.yaml template.
• The KEP Readme looks quite out-dated. Update the KEP Readme.md file to be in compliance with the latest template. Some of the work will include updating Test Plan section, adding and addressing the Production Readiness Review Questionnaire etc.
• Add a .yaml file for this KEP under kubernetes/enhancements/keps/prod-readiness/sig-node folder with name 727.yaml. Refer 693.yaml to fill in the information. We need to add approvers for every stage this KEP have been through and is currently targeting.
• Ultimately with all the changes addressed we'll need to get this KEP approved by the PRR team.

The status of this enhancement is marked as at risk. Please keep the issue description up-to-date with appropriate stages as well. Thank you :)

We're going to delay graduation for one more release (v1.29).

[Richabanker]

/milestone v1.29

[k8s-ci-robot]

@Richabanker: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Milestone Maintainers Team and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[npolshakova]

Hi @Richabanker, 1.29 enhancement team here! Is this enhancement targeting 1.29? If it is, can you reopen the issue and follow the instructions here to opt in the enhancement and make sure the lead-opted-in label is set so it can get added to the tracking board? Thanks!

[wojtek-t]

/milestone v1.29
/label lead-opted-in