-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for external signing of Service Account tokens #740
Comments
@micahhausler I see this issue has been added targeting Alpha for 1.14 - I'm the enhancements lead so if that is correct I'll add it to the milestone - as an FYI enhancements freeze is today 1/29 at PST EOD - we'll want to have a KEP for this issue merged and in an implementable state by then. |
/assign @micahhausler |
Hey there @micahhausler, I'm one of the 1.16 Enhancement Shadows. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If it's not graduating, I will remove it from the milestone and change the tracked label. Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly. As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements. Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29. Thank you. |
Hello @micahhausler, 1.17 Enhancement Shadow here! 🙂 I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?
Please note that the KEP is missing test plan. Thank you! 🔔Friendly Reminder
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Hey @micahhausler -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.18 or having a major change in its current level? The current release schedule is: Tuesday, January 28th EOD PST - Enhancements Freeze To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined. If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍 Thanks! |
@helayoty Yes this is planned for 1.18 in alpha |
Thank you @micahhausler for confirming. Please update the issue with the updated KEP and all PRs related. |
/milestone v1.18 |
Updated the issue description with the KEP link. |
Hi @micahhausler, sorry for putting this at the last minute, but it seems like the KEP is missing both test plans and graduation criteria. They are required for this enhancement to be considered for this release. Can you please update the KEP accordingly? |
@micahhausler, unfortunately since this doesn't have test plans or graduation criteria, we are going to need to bump this from the 1.18 release. If you can update the KEP and file an Exception Request we can get it back in! |
/milestone clear |
@AnshumanTripathi I have started a placeholder PR: kubernetes/website#48518 |
Hey @ahmedtd @liggitt 👋, v1.32 Enhancements team here. Just checking in as we approach code freeze at 02:00 UTC Friday 8th November 2024 / 19:00 PDT Thursday 7th November 2024. Here's where this enhancement currently stands:
For this enhancement, it looks like the following PRs need to be merged before code freeze (and we need to update the Issue description to include all the related PRs of this KEP): If you anticipate missing code freeze, you can file an exception request in advance. Also, please let me know if there are other PRs in k/k we should be tracking for this KEP. |
Hi @ahmedtd @liggitt @HarshalNeelkamal 👋, v1.32 Communications Team here again! This is a gentle reminder for the feature blog deadline mentioned above, which is 02:00 UTC Wednesday, 30th Oct. To opt in, please let us know and open a Feature Blog placeholder PR against Tip Some timeline to keep in mind:
Note In your placeholder PR, use |
@rytswd is it different from the Placeholder PR I have opened as in #740 (comment) ? |
@HarshalNeelkamal I believe the one you opened up there is for the documentation update (managed by v1.32 Docs team), and I'm here from the Communications Team, to see if you would like to write up a Feature Blog 👍 |
All code changes for alpha in 1.32 are merged |
Hello @ahmedtd @liggitt 👋, Enhancements team here. With all the implementation(code related) PRs merged as per the issue description: This enhancement is now marked as Please note that KEPs targeting |
Hello 👋, 1.33 Enhancements Lead here. I’m closing milestone 1.32 now. If you'd like to work on this enhancement in v1.33, please have the SIG lead opt-in by adding the /remove-label lead-opted-in |
This is staying in alpha in 1.33 with additional work being done |
Hello @ahmedtd @micahhausler 👋, v1.33 Enhancements team here. Just checking in as we approach enhancements freeze on 02:00 UTC Friday 14th February 2025 / 19:00 PDT Thursday 13th February 2025. This enhancement is targeting stage Here's where this enhancement currently stands:
For this KEP, we would just need to update the following:
The status of this enhancement is marked as If you anticipate missing enhancements freeze, you can file an exception request in advance. Thank you! |
Hello @enj 👋, Now that PR #5130 has been merged, all the KEP requirements are in place and merged into k/enhancements. This enhancement is all good for the upcoming enhancements freeze. 🚀 Before the enhancement freeze, it would be appreciated if following nits could be addressed:
Aside from the minor nit mentioned above, this enhancement is all good for the upcoming enhancements freeze. 🚀 The status of this enhancement is now marked as |
The 1.32 alpha is still correct, as the feature was merged as alpha in that release. It is remaining in alpha in 1.33. |
Hello @enj 👋, v1.33 Docs Shadow here. Does this enhancement work planned for v1.33 require any new docs or modification to existing docs? Also, take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release. |
Enhancement Description
One-line enhancement description (can be used as a release note): External signer integration for service account tokens
Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/740-service-account-external-signing
Primary contact (assignee): @ahmedtd
Responsible SIGs: sig-auth
Enhancement target (which target equals to which milestone):
Alpha 1.32
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update PR(s):Alpha 1.33
k/enhancements
) update PR(s):k/k
) update PR(s):k/website
) update(s):Please keep this description up to date. This will help the Enhancement Team to track the evolution of the enhancement efficiently.
The text was updated successfully, but these errors were encountered: