New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spelling verification to the enhancements repo #745

Closed
tallclair opened this Issue Jan 28, 2019 · 11 comments

Comments

Projects
6 participants
@tallclair
Copy link
Member

tallclair commented Jan 28, 2019

When KEPs were migrated from the community repo, we lost the spelling verification. We should copy the scripts over from the community repo, and enable them in presubmit.

@tallclair

This comment has been minimized.

Copy link
Member Author

tallclair commented Jan 30, 2019

/cc @cblecker

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Jan 30, 2019

Great point, @tallclair!

/sig pm
/help

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Feb 5, 2019

/assign

@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Feb 5, 2019

Created #816

/remove-help

@dashpole

This comment has been minimized.

Copy link
Contributor

dashpole commented Feb 5, 2019

Im getting this error for the verify test for #726:

Verifying verify-spelling.sh
Can't find misspell - is your GOPATH 'bin' in your PATH?
  GOPATH: /home/prow/go
  PATH:   /go/bin:/usr/local/go/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
@nikhita

This comment has been minimized.

Copy link
Member

nikhita commented Feb 6, 2019

@Katharine

This comment has been minimized.

Copy link
Member

Katharine commented Feb 6, 2019

FYI: I disabled this again pending fixes in kubernetes/test-infra#11155 because the job was always failing and it was blocking.

I recommend fixing the job and trying it manually before updating the configuration to make it required.

/reopen

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 6, 2019

@Katharine: Reopened this issue.

In response to this:

FYI: I temporarily disabled this again in kubernetes/test-infra#11155 because the job was always failing and it was blocking.

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Feb 6, 2019

@justaugustus justaugustus added this to In progress in SIG PM Feb 16, 2019

@justaugustus

This comment has been minimized.

Copy link
Member

justaugustus commented Feb 19, 2019

Closed via kubernetes/test-infra#11361.
Thanks again @nikhita + @Katharine! :)

/pony space
/close

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 19, 2019

@justaugustus: pony image

In response to this:

Closed via kubernetes/test-infra#11361.
Thanks again @nikhita + @Katharine! :)

/pony space
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SIG PM automation moved this from In progress to Done Feb 19, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Feb 19, 2019

@justaugustus: Closing this issue.

In response to this:

Closed via kubernetes/test-infra#11361.
Thanks again @nikhita + @Katharine! :)

/pony space
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment