New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HugePages #751

Open
derekwaynecarr opened this Issue Jan 29, 2019 · 8 comments

Comments

Projects
None yet
6 participants
@derekwaynecarr
Copy link
Member

derekwaynecarr commented Jan 29, 2019

Enhancement Description: HugePages to GA

@derekwaynecarr

This comment has been minimized.

Copy link
Member Author

derekwaynecarr commented Jan 29, 2019

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node and removed needs-sig labels Jan 29, 2019

@vishh

This comment has been minimized.

Copy link
Member

vishh commented Jan 29, 2019

@derekwaynecarr do we have adequate metrics exposed to track the health of huge pages functionality in Kubelet? If yes, it would be great if you can list them here (or ideally in user docs) for easier reference in the future

@derekwaynecarr derekwaynecarr added this to the v1.14 milestone Jan 29, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Jan 30, 2019

@derekwaynecarr since therKEP for this issue isn't merged yet we will be removing it from the 1.14 milestone. To have it added back in please file an exception - information on the exception process can be found here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

@claurence claurence removed this from the v1.14 milestone Jan 30, 2019

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 31, 2019

per approved exception

/milestone v1.14

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 11, 2019

I can do any API review required for this (there may not actually be any visible API changes as part of the beta->stable promotion)

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Feb 15, 2019

Already merged, no visible API changes: kubernetes/kubernetes#72785

@liggitt liggitt removed their assignment Feb 15, 2019

@npentrel

This comment has been minimized.

Copy link

npentrel commented Feb 22, 2019

Hey @derekwaynecarr 👋! I'm Naomi, a v1.14 docs release shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 22, 2019

@derekwaynecarr looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment