Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ingress to the networking.v1beta1 API group #758

Closed
1 task done
bowei opened this issue Jan 29, 2019 · 46 comments
Closed
1 task done

Move Ingress to the networking.v1beta1 API group #758

bowei opened this issue Jan 29, 2019 · 46 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@bowei
Copy link
Member

bowei commented Jan 29, 2019

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 29, 2019
@bowei
Copy link
Member Author

bowei commented Jan 29, 2019

/sig network

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 29, 2019
@bowei
Copy link
Member Author

bowei commented Jan 29, 2019

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 29, 2019
@liggitt
Copy link
Member

liggitt commented Jan 30, 2019

KEP is in #749, targeting v1.14 for the next step

moving into the milestone ahead of the implementable KEP deadline of 2/4

@liggitt liggitt added this to the v1.14 milestone Jan 30, 2019
@bowei bowei added this to KEPs in SIG-Network KEPs Jan 30, 2019
@liggitt liggitt added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels Jan 31, 2019
@claurence claurence added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 7, 2019
@liggitt
Copy link
Member

liggitt commented Feb 14, 2019

first PR in kubernetes/kubernetes#74057

@thockin thockin self-assigned this Feb 15, 2019
@thockin
Copy link
Member

thockin commented Feb 15, 2019

I'm on API review.

@vishh shadow

@liggitt liggitt added this to Assigned in API Reviews Feb 15, 2019
@liggitt liggitt removed this from Assigned in API Reviews Feb 20, 2019
@thockin
Copy link
Member

thockin commented Feb 21, 2019

/lgtm
/approve

@claurence
Copy link

claurence commented Feb 22, 2019

@bowei looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

@bowei
Copy link
Member Author

bowei commented Feb 25, 2019

Adding section.

@bowei
Copy link
Member Author

bowei commented Feb 25, 2019

#854

@simplytunde
Copy link
Member

simplytunde commented Feb 27, 2019

Hey @bowei Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@claurence
Copy link

claurence commented Feb 27, 2019

@bowei are there any open PRs in K/K for this enhancement that need to be merged before code freeze (march 7th)?

@kacole2
Copy link
Member

kacole2 commented Apr 11, 2019

Hello @bowei, I'm the Enhancement Lead for 1.15. Is this feature going to be graduating from alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.14 milestone Apr 11, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 11, 2019
@bowei
Copy link
Member Author

bowei commented Apr 26, 2019

We are drafting a following changes to the KEP to kick off the discussion of a plan for GA.

@mrbobbytables mrbobbytables added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 25, 2019
@VineethReddy02
Copy link

VineethReddy02 commented Oct 21, 2019

Hey, @cmluciano, I am docs shadow for 1.17 release. Just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Thanks!

@VineethReddy02
Copy link

VineethReddy02 commented Nov 2, 2019

Hey, @cmluciano, Just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!
We are 5 days away from the deadline. Thanks!

@mrbobbytables
Copy link
Member

mrbobbytables commented Nov 5, 2019

Hey there @cmluciano 1.17 Enhancement lead here 👋 We still have a little bit of time, but Code Freeze is fast approaching (November 14th). All enhancements going into the release must be code-complete, including tests, and have docs PRs open by then.

Are there any other PRs besides kubernetes/kubernetes#83467 that should be tracked? If it or the other PRs that should be tracked aren't merged by the freeze, it'll slip from the 1.17 release cycle. 😬

Only release-blocking issues and PRs will be allowed in the milestone.

If you know it'll slip, please let us know so we can remove it from the tracking sheet.

Thanks!

@cmluciano
Copy link
Member

cmluciano commented Nov 6, 2019

@bowei Should this be revised to incorporate the v1 enhancements or is this one strictly for tracking the move to v1beta1 under networking?

@cmluciano
Copy link
Member

cmluciano commented Nov 8, 2019

We talked about this last night and agreed to push this to 1.18 @VineethReddy02

@mrbobbytables
Copy link
Member

mrbobbytables commented Nov 8, 2019

Thanks @cmluciano, we'll remove it from the tracking sheet and add it to 1.18 👍
/milestone v1.18

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.18 Nov 8, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Nov 8, 2019
@aojea aojea moved this from KEP to In progress in SIG-Network KEPs Dec 15, 2019
@aojea aojea moved this from In progress to KEP in SIG-Network KEPs Dec 15, 2019
@sftim
Copy link
Contributor

sftim commented Dec 23, 2019

Move Ingress to the networking.v1beta1 API group

Should this be revised to incorporate the v1 enhancements or is this one strictly for tracking the move to v1beta1 under networking?

That change happened already, right? So stablization & GA should be a new issue linked to this one.

@glasser
Copy link

glasser commented Dec 23, 2019

Hi, maybe this is too late, but I have a suggestion for this KEP. (I think maybe this comment is in the wrong place — there's a suggestion in the README about a linked-to-issue but I'm not sure what that means and the new issue template only shows how to create a new KEP. Happy to move this to a better place.)

Nothing in the current docs or the KEP that I can see explains what happens if two rules have the same hostname, and the new hostname section is not super explicit about what happens if an URL matches two rules by host.

I suggest that the answer should be that an URL matches a "precise" rule if there is one, otherwise it matches a "wildcard" rule if there is one, otherwise it matches a rule with no host if there is one. Also, if it's possible, it should be an error (or just not recommended?) to have multiple rules with the same host.

But maybe I'm wrong and the answer is that rule order controls precedence? This is not explicitly documented even for the beta version (where it's unclear if rule order matters for a precise host rule vs a no host rule).

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jan 14, 2020

Hey there @bowei @cmluciano -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.18?

The current release schedule is:
Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.
If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍
We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks!

@bowei
Copy link
Member Author

bowei commented Jan 14, 2020

@robscott what do you think? I think we can definitely make it pending resolving some of these conversations.

@robscott
Copy link
Member

robscott commented Jan 14, 2020

Hey @kikisdeliveryservice and @bowei, thanks for checking in! We've been doing most of the work (and corresponding reviews) for this feature on a fork of k/k given how large this update is. With that said, although there isn't much evidence of work in PRs on k/k yet, I do think we're on track for a 1.18 release.

As suggested by @sftim above, I've created a separate issue to track the work towards GA (#1453) and will close this as the work towards beta has been completed.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 14, 2020

@robscott: Closing this issue.

In response to this:

Hey @kikisdeliveryservice and @bowei, thanks for checking in! We've been doing most of the work (and corresponding reviews) for this feature on a fork of k/k given how large this update is. With that said, although there isn't much evidence of work in PRs on k/k yet, I do think we're on track for a 1.18 release.

As suggested by @sftim above, I've created a separate issue to track the work towards GA (#1453) and will close this as the work towards beta has been completed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

palnabarun commented May 9, 2020

/milestone clear

(clearing milestone as 1.18 release cycle is complete)

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone May 9, 2020
stefannica added a commit to stefannica/harbor-helm that referenced this issue Aug 27, 2020
The kubernetes extensions/v1beta1 Ingress API has been deprecated
in v1.16 in favor of networking.k8s.io/v1beta1 [1]. extensions/v1beta1
will be completely removed in kubernetes 1.18 [2].

kubernetes/enhancements#758
kubernetes/kubernetes#43214
stefannica added a commit to stefannica/harbor-helm that referenced this issue Aug 27, 2020
The kubernetes extensions/v1beta1 Ingress API has been deprecated
in v1.16 in favor of networking.k8s.io/v1beta1 [1]. extensions/v1beta1
will be completely removed in kubernetes 1.18 [2].

[1] kubernetes/enhancements#758
[2] kubernetes/kubernetes#43214

Signed-off-by: Stefan Nica <snica@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests