Move Ingress to the networking.v1beta1 API group

[bowei]

Enhancement Description

• One-line enhancement description: Move Ingress to the networking.v1beta1 API group
• Primary contact: bowei
• Responsible SIGs: sig-network
• KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/20190125-ingress-api-group.md
• Link to e2e and/or unit tests:
• Reviewer(s): @aledbf
• Approver: @caseydavenport, thockin@
• Enhancement target: 1.14, 1.15, 1.16
• PRs
  • Ingress extensions/v1beta1 -> networking.k8s.io/v1beta1 kubernetes#74057

[bowei]

/sig network

[bowei]

/kind cleanup

[liggitt]

KEP is in #749, targeting v1.14 for the next step

moving into the milestone ahead of the implementable KEP deadline of 2/4

[liggitt]

first PR in kubernetes/kubernetes#74057

[thockin]

I'm on API review.

@vishh shadow

[thockin]

/lgtm
/approve

[claurence]

@bowei looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

[bowei]

Adding section.

[bowei]

#854

[simplytunde]

Hey @bowei Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

[claurence]

@bowei are there any open PRs in K/K for this enhancement that need to be merged before code freeze (march 7th)?

[kacole2]

Hello @bowei, I'm the Enhancement Lead for 1.15. Is this feature going to be graduating from alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet.

Once coding begins, please list all relevant k/k PRs in this issue so they can be tracked properly.

/milestone clear

[bowei]

We are drafting a following changes to the KEP to kick off the discussion of a plan for GA.

[VineethReddy02]

Hey, @cmluciano, I am docs shadow for 1.17 release. Just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

Thanks!

[VineethReddy02]

Hey, @cmluciano, Just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, Nov 8th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!
We are 5 days away from the deadline. Thanks!

[mrbobbytables]

Hey there @cmluciano 1.17 Enhancement lead here 👋 We still have a little bit of time, but Code Freeze is fast approaching (November 14th). All enhancements going into the release must be code-complete, including tests, and have docs PRs open by then.

Are there any other PRs besides kubernetes/kubernetes#83467 that should be tracked? If it or the other PRs that should be tracked aren't merged by the freeze, it'll slip from the 1.17 release cycle. 😬

Only release-blocking issues and PRs will be allowed in the milestone.

If you know it'll slip, please let us know so we can remove it from the tracking sheet.

Thanks!

[cmluciano]

@bowei Should this be revised to incorporate the v1 enhancements or is this one strictly for tracking the move to v1beta1 under networking?

[cmluciano]

We talked about this last night and agreed to push this to 1.18 @VineethReddy02

[mrbobbytables]

Thanks @cmluciano, we'll remove it from the tracking sheet and add it to 1.18 👍
/milestone v1.18

[sftim]

Move Ingress to the networking.v1beta1 API group

Should this be revised to incorporate the v1 enhancements or is this one strictly for tracking the move to v1beta1 under networking?

That change happened already, right? So stablization & GA should be a new issue linked to this one.

[glasser]

Hi, maybe this is too late, but I have a suggestion for this KEP. (I think maybe this comment is in the wrong place — there's a suggestion in the README about a linked-to-issue but I'm not sure what that means and the new issue template only shows how to create a new KEP. Happy to move this to a better place.)

Nothing in the current docs or the KEP that I can see explains what happens if two rules have the same hostname, and the new hostname section is not super explicit about what happens if an URL matches two rules by host.

I suggest that the answer should be that an URL matches a "precise" rule if there is one, otherwise it matches a "wildcard" rule if there is one, otherwise it matches a rule with no host if there is one. Also, if it's possible, it should be an error (or just not recommended?) to have multiple rules with the same host.

But maybe I'm wrong and the answer is that rule order controls precedence? This is not explicitly documented even for the beta version (where it's unclear if rule order matters for a precise host rule vs a no host rule).

[kikisdeliveryservice]

Hey there @bowei @cmluciano -- 1.18 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to stable in 1.18?

The current release schedule is:
Monday, January 6th - Release Cycle Begins
Tuesday, January 28th EOD PST - Enhancements Freeze
Thursday, March 5th, EOD PST - Code Freeze
Monday, March 16th - Docs must be completed and reviewed
Tuesday, March 24th - Kubernetes 1.18.0 Released

To be included in the release, this enhancement must have a merged KEP in the implementable status. The KEP must also have graduation criteria and a Test Plan defined.
If you would like to include this enhancement, once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍
We'll be tracking enhancements here: http://bit.ly/k8s-1-18-enhancements
Thanks!

[bowei]

@robscott what do you think? I think we can definitely make it pending resolving some of these conversations.

[robscott]

Hey @kikisdeliveryservice and @bowei, thanks for checking in! We've been doing most of the work (and corresponding reviews) for this feature on a fork of k/k given how large this update is. With that said, although there isn't much evidence of work in PRs on k/k yet, I do think we're on track for a 1.18 release.

As suggested by @sftim above, I've created a separate issue to track the work towards GA (#1453) and will close this as the work towards beta has been completed.

/close

[k8s-ci-robot]

@robscott: Closing this issue.

In response to this:

Hey @kikisdeliveryservice and @bowei, thanks for checking in! We've been doing most of the work (and corresponding reviews) for this feature on a fork of k/k given how large this update is. With that said, although there isn't much evidence of work in PRs on k/k yet, I do think we're on track for a 1.18 release.

As suggested by @sftim above, I've created a separate issue to track the work towards GA (#1453) and will close this as the work towards beta has been completed.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[palnabarun]

/milestone clear

(clearing milestone as 1.18 release cycle is complete)