Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip attach for non-attachable CSI volumes #770

Closed
2 tasks
msau42 opened this issue Jan 29, 2019 · 41 comments · Fixed by kubernetes/kubernetes#84814
Closed
2 tasks

Skip attach for non-attachable CSI volumes #770

msau42 opened this issue Jan 29, 2019 · 41 comments · Fixed by kubernetes/kubernetes#84814
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@msau42
Copy link
Member

msau42 commented Jan 29, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Allow CSI drivers that don't support attach to not require the CSI external-attacher
  • Primary contact (assignee): @jsafrane
  • Responsible SIGs: sig-storage
  • Design proposal link (community repo)/ KEP: Add KEP for csi skip attach #768 / https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20190129-csi-skip-attach.md
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @msau42 @saad-ali
  • Approver (likely from SIG/area to which enhancement belongs): @saad-ali
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y): 1.12
    • Beta release target (x.y): 1.14
    • Stable release target (x.y)

API PRs:

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 29, 2019
@msau42
Copy link
Member Author

msau42 commented Jan 29, 2019

For some reason I couldn't find a feature issue for this, so I created this

@msau42
Copy link
Member Author

msau42 commented Jan 29, 2019

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. kind/feature Categorizes issue or PR as related to a new feature. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 29, 2019
@msau42
Copy link
Member Author

msau42 commented Jan 29, 2019

cc @claurence
This should be tracked as beta for 1.14.

@msau42
Copy link
Member Author

msau42 commented Jan 30, 2019

/assign @bertinatto @jsafrane

@claurence claurence added this to the v1.14 milestone Feb 5, 2019
@claurence claurence added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Feb 5, 2019
@ameukam
Copy link
Member

ameukam commented Feb 6, 2019

/stage beta

@k8s-ci-robot k8s-ci-robot added the stage/beta Denotes an issue tracking an enhancement targeted for Beta status label Feb 6, 2019
@liggitt liggitt added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 15, 2019
@liggitt liggitt added this to Assigned in API Reviews Feb 15, 2019
@liggitt liggitt removed this from Assigned in API Reviews Feb 20, 2019
@simplytunde
Copy link
Member

simplytunde commented Feb 27, 2019

Hey @msau42 Just a friendly reminder we're looking for a PR against k/website (branch dev-1.14) due by Friday, March 1. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@claurence
Copy link

claurence commented Feb 27, 2019

@msau42 Checking in as code freeze is approaching (March 7th) - I see a few PRs mentioned above but want to check which ones need to be merged by code freeze for this to be included in the 1.14 release (and if there are any additional PRs).

@msau42
Copy link
Member Author

msau42 commented Feb 28, 2019

I updated the description with all the k/k prs required

@jsafrane
Copy link
Member

jsafrane commented Mar 1, 2019

This feature is not facing users and thus does not have docs on kubernetes.io. Its documentation is at https://kubernetes-csi.github.io/docs/. 1.14 updates are in progress at kubernetes-csi/docs#121

@kacole2
Copy link
Member

kacole2 commented Apr 11, 2019

Hello @msau42 @jsafrane , I'm the Enhancement Lead for 1.15. Is this feature going to be graduating alpha/beta/stable stages in 1.15? Please let me know so it can be tracked properly and added to the spreadsheet. Drop any relevant k/k PRs into this issue so they can be tracked as well. Thanks!

@helayoty helayoty added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 15, 2020
@irvifa
Copy link
Member

irvifa commented Feb 9, 2020

Hello @msau42 @jsafrane I'm one of the v1.18 docs shadows.
Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th., it can just be a placeholder PR at this time. Let me know if you have any questions!

@irvifa
Copy link
Member

irvifa commented Feb 19, 2020

Hello @msau42 @jsafrane I'm one of the v1.18 docs shadows.

Does this enhancement for (or the work planned for v1.18) require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, which is roughly 1 weeks from now. It can just be a placeholder PR at this time. Let me know if you have any questions!

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 24, 2020

Hello @msau42 @jsafrane @gnufied,

Can you please link us to any k/k PRs for this enhancement so we can better track things. Code freeze is coming up quickly on 05 March 2020

@irvifa
Copy link
Member

irvifa commented Feb 27, 2020

Hi @msau42 @jsafrane @gnufied I know you’re keeping tabs on this.. since the deadline is this Friday would you like to share when will you create a placeholder PR? Thanks..

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 2, 2020

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Mar 2, 2020
@jeremyrickard jeremyrickard added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Mar 2, 2020
@VineethReddy02
Copy link

VineethReddy02 commented Mar 2, 2020

Hi, @msau42 @jsafrane @gnufied as there is no docs placeholder PR for this enhancement and didn't receive any update on the docs front. we have crossed the docs placeholder PR deadline. So we are removing this enhancement from the 1.18 release. If you want to request an exception. Please refer to https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

Thanks!

@gnufied
Copy link
Member

gnufied commented Mar 2, 2020

so this enhancment and #603 are basically behind same feature gate which is called CSIDriverRegistry and it does make sense to open two different placeholder docs for documenting same feature-gate - kubernetes/website#19354

@VineethReddy02
Copy link

VineethReddy02 commented Mar 2, 2020

So @gnufied kubernetes/website#19354 will this placeholder PR contain docs for this enhancement or you want to create another placeholder PR? In the previous comment, you mentioned you want different placeholder PR

@msau42
Copy link
Member Author

msau42 commented Mar 2, 2020

I think the same PR covers both

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 3, 2020

/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 3, 2020
@jeremyrickard jeremyrickard added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Mar 3, 2020
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Mar 6, 2020

/reopen @gnufied @msau42 you should leave this open until the KEP is updated to implemented

@gnufied
Copy link
Member

gnufied commented Mar 6, 2020

Yeah. This is a side effect of PRs using direct ref rather than xref.

@jsafrane
Copy link
Member

jsafrane commented Mar 9, 2020

you should leave this open until the KEP is updated to implemented

Filed #1605

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 27, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/close

(closing this since the KEP has been implemented)

@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Apr 29, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 29, 2020

@palnabarun: Closing this issue.

In response to this:

/close

(closing this since the KEP has been implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.