New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s.io/component-base #783

Open
luxas opened this Issue Jan 30, 2019 · 6 comments

Comments

@luxas
Copy link
Member

luxas commented Jan 30, 2019

As per @spiffxp's request, I'm filing this enhancements issue although it's not very user facing.

@pohly

This comment has been minimized.

Copy link

pohly commented Jan 30, 2019

How will k8s.io/component-base be different from k8s.io/utils aka https://github.com/kubernetes/utils/?

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Jan 30, 2019

@pohly k8s.io/utils cannot depend on kube libraries. In contrast, component-base builds on-top of client-go and apimachinery.

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 5, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 11, 2019

@luxas are there any open PRs in k/k that need to be merged (in addition to the one referenced above) for this to be in 1.14? Code freeze is 3/7 and if the PRs are not able to merge by then this issue will be removed from the milestone.

@luxas

This comment has been minimized.

Copy link
Member Author

luxas commented Feb 12, 2019

Got it. We have a few things in the pipeline, but not all PRs intended to be merged published yet. We'll let you all know how it goes closer to the deadline. However, this is not as critical as a feature in the sense that it's a step-by-step refactor, so it can "stop" at any time and just continue when the next cycle opens, without disrupting anything.

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 22, 2019

@luxas looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment