Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate the kube-proxy ComponentConfig to v1beta1 #784

Open
luxas opened this issue Jan 30, 2019 · 58 comments
Open

Graduate the kube-proxy ComponentConfig to v1beta1 #784

luxas opened this issue Jan 30, 2019 · 58 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.

Comments

@luxas
Copy link
Member

luxas commented Jan 30, 2019

  • One-line enhancement description (can be used as a release note): Usage of the kube-proxy configuration file has graduated from experimental, as the API version now is v1beta1
  • Primary contact (assignee): @luxas
  • Responsible SIGs: @kubernetes/sig-network-api-reviews @kubernetes/wg-component-standard
  • KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/784-kube-proxy-component-config
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @thockin
  • Approver (likely from SIG/area to which enhancement belongs): @thockin
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y) PAST
    • Beta release target (x.y) 1.16
    • Stable release target (x.y) TODO

The kube-proxy ComponentConfig is currently in v1alpha1. The spec needs to be graduated to v1beta1 and beyond in order to be usable widely.
/assign @thockin

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jan 30, 2019
@luxas luxas added this to the v1.14 milestone Jan 30, 2019
@luxas luxas added the wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard. label Jan 30, 2019
@bowei bowei added this to KEPs in SIG-Network KEPs Jan 30, 2019
@liggitt liggitt added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 31, 2019
@sttts
Copy link
Contributor

sttts commented Jan 31, 2019

We need a thorough API review of the kube-proxy component config in the light of unifying them for all components. Moving what we have to beta in the 1.14 time frame feels like rushing in the light of us having just started with component-base.

@claurence
Copy link

@luxas I don't see a KEP for this issue links in the description. I'm removing it from the 1.14 milestone - to have it added back please file an exception request.

@rosti
Copy link
Member

rosti commented Mar 19, 2019

I am giving this a try.
/assign

@kacole2
Copy link
Member

kacole2 commented Apr 11, 2019

@luxas @rosti I'm the enhancement lead for 1.15. I don't see a KEP filed for this enhancement and per the guidelines, all enhancements will require one. Please let me know if this issue will have any work involved for this release cycle and update the original post reflect it. Thanks!

@rosti
Copy link
Member

rosti commented Apr 16, 2019

@kacole2 I am a bit skeptical for a KEP in this release cycle, however if we manage to put something before enhancements freeze for 1.15 then we'll ping you.

@rosti
Copy link
Member

rosti commented Jun 5, 2019

Initial proposal doc.
This is shared with WG Component Standard, SIG Network, SIG Windows, SIG API Machinery and SIG Cluster Lifecycle. If someone has trouble accessing it, ping me.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 5, 2019

@rosti thanks for picking this up! The common vs. local and per-platform config problems have needed someone who can really focus on them for a while, and I haven't been able to dedicate enough time lately. So I'm grateful someone's looking at this :). This is critical to the future of the componentconfig effort.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 5, 2019

I left some comments on your doc.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 6, 2019

@vllry, I heard you're also going to be working on kube-proxy componentconfig, wanted to make sure you see this.

@stealthybox
Copy link
Member

@rosti, shall we tag this /w 1.16 and update KEP #1104?

@alejandrox1
Copy link
Contributor

Moving this to the 1.16 milestone to tackle during the next release
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 26, 2019
@neolit123 neolit123 added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 26, 2019
@neolit123
Copy link
Member

IMO we should have k/enhancements issues that track full graduation of APIs. from alpha->GA instead of separate ones for beta or GA.

@rosti
Copy link
Member

rosti commented Jul 1, 2019

If the KEP merges we can have an alpha version released before the end of the cycle, so I think, that it's appropriate to have it in 1.16.

@mrbobbytables
Copy link
Member

Hey there @luxas, I'm one of the 1.16 Enhancement Shadows. Looks like you're on track for v1.16 :)

As a general reminder, the KEP must be merged and in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@mrbobbytables mrbobbytables added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 10, 2019
@thockin thockin moved this from Pre-Alpha (code not merged) to No gates in SIG-Network KEPs Jun 1, 2021
@jayunit100
Copy link
Member

hi folks, anyone looking at this ?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 18, 2021
@thockin thockin removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 20, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 19, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thockin thockin reopened this Jun 14, 2023
SIG-Network KEPs automation moved this from No gates to New, not evaluated Jun 14, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2023
@thockin
Copy link
Member

thockin commented Aug 17, 2023

We really do need to fix the k-p config vs flags mess.

@thockin thockin removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 17, 2023
@thockin thockin reopened this Aug 17, 2023
@pohly
Copy link
Contributor

pohly commented Aug 18, 2023

See also kubernetes/kubernetes#119864 regarding how adding config options for logging broke logging command flags. This was fixed just in time before the 1.28 release.

@sftim
Copy link
Contributor

sftim commented Sep 4, 2023

💭 how come this enhancement doesn't aim to graduate that config to stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Projects
SIG-Network KEPs
New, not evaluated
Development

No branches or pull requests