Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate the kube-proxy ComponentConfig to v1beta1 #784

Closed
luxas opened this issue Jan 30, 2019 · 53 comments
Closed

Graduate the kube-proxy ComponentConfig to v1beta1 #784

luxas opened this issue Jan 30, 2019 · 53 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.

Comments

@luxas
Copy link
Member

luxas commented Jan 30, 2019

  • One-line enhancement description (can be used as a release note): Usage of the kube-proxy configuration file has graduated from experimental, as the API version now is v1beta1
  • Primary contact (assignee): @luxas
  • Responsible SIGs: @kubernetes/sig-network-api-reviews @kubernetes/wg-component-standard
  • KEP: https://github.com/kubernetes/enhancements/blob/master/keps/sig-network/784-kube-proxy-component-config
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @thockin
  • Approver (likely from SIG/area to which enhancement belongs): @thockin
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y) PAST
    • Beta release target (x.y) 1.16
    • Stable release target (x.y) TODO

The kube-proxy ComponentConfig is currently in v1alpha1. The spec needs to be graduated to v1beta1 and beyond in order to be usable widely.
/assign @thockin

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Jan 30, 2019
@luxas luxas added this to the v1.14 milestone Jan 30, 2019
@luxas luxas added the wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard. label Jan 30, 2019
@bowei bowei added this to KEPs in SIG-Network KEPs Jan 30, 2019
@liggitt liggitt added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Jan 31, 2019
@sttts
Copy link
Contributor

sttts commented Jan 31, 2019

We need a thorough API review of the kube-proxy component config in the light of unifying them for all components. Moving what we have to beta in the 1.14 time frame feels like rushing in the light of us having just started with component-base.

@claurence
Copy link

claurence commented Feb 5, 2019

@luxas I don't see a KEP for this issue links in the description. I'm removing it from the 1.14 milestone - to have it added back please file an exception request.

@rosti
Copy link
Member

rosti commented Mar 19, 2019

I am giving this a try.
/assign

@kacole2
Copy link
Member

kacole2 commented Apr 11, 2019

@luxas @rosti I'm the enhancement lead for 1.15. I don't see a KEP filed for this enhancement and per the guidelines, all enhancements will require one. Please let me know if this issue will have any work involved for this release cycle and update the original post reflect it. Thanks!

@rosti
Copy link
Member

rosti commented Apr 16, 2019

@kacole2 I am a bit skeptical for a KEP in this release cycle, however if we manage to put something before enhancements freeze for 1.15 then we'll ping you.

@rosti
Copy link
Member

rosti commented Jun 5, 2019

Initial proposal doc.
This is shared with WG Component Standard, SIG Network, SIG Windows, SIG API Machinery and SIG Cluster Lifecycle. If someone has trouble accessing it, ping me.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 5, 2019

@rosti thanks for picking this up! The common vs. local and per-platform config problems have needed someone who can really focus on them for a while, and I haven't been able to dedicate enough time lately. So I'm grateful someone's looking at this :). This is critical to the future of the componentconfig effort.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 5, 2019

I left some comments on your doc.

@mtaufen
Copy link
Contributor

mtaufen commented Jun 6, 2019

@vllry, I heard you're also going to be working on kube-proxy componentconfig, wanted to make sure you see this.

@stealthybox
Copy link

stealthybox commented Jun 25, 2019

@rosti, shall we tag this /w 1.16 and update KEP #1104?

@alejandrox1
Copy link
Contributor

alejandrox1 commented Jun 26, 2019

Moving this to the 1.16 milestone to tackle during the next release
/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jun 26, 2019
@neolit123 neolit123 added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels Jun 26, 2019
@neolit123
Copy link
Member

neolit123 commented Jun 26, 2019

IMO we should have k/enhancements issues that track full graduation of APIs. from alpha->GA instead of separate ones for beta or GA.

@rosti
Copy link
Member

rosti commented Jul 1, 2019

If the KEP merges we can have an alpha version released before the end of the cycle, so I think, that it's appropriate to have it in 1.16.

@mrbobbytables
Copy link
Member

mrbobbytables commented Jul 10, 2019

Hey there @luxas, I'm one of the 1.16 Enhancement Shadows. Looks like you're on track for v1.16 :)

As a general reminder, the KEP must be merged and in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@mrbobbytables mrbobbytables added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 10, 2019
@fejta-bot
Copy link

fejta-bot commented Dec 29, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2020
@fejta-bot
Copy link

fejta-bot commented Jan 28, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 28, 2021
@neolit123
Copy link
Member

neolit123 commented Jan 28, 2021

/remove-lifecycle rotten
hoping that sig-network can pick the graduation of this config eventually.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 28, 2021
@jayunit100
Copy link
Member

jayunit100 commented Mar 19, 2021

hiya folks, is anyone workin on this?

@rikatz
Copy link
Contributor

rikatz commented Apr 12, 2021

/assign @jayunit100 @rikatz

OK, let's keep this on our track Jay. At least we know where it is, and how we can help on this.

But first we need to solve the flags/config conflicts (as Lubomir pointed in your original track) and then maybe propose to promote this :D

@rikatz
Copy link
Contributor

rikatz commented Apr 12, 2021

@LappleApple marking you here just to be aware :D

@thockin thockin moved this from Pre-Alpha (code not merged) to No gates in SIG-Network KEPs Jun 1, 2021
@jayunit100
Copy link
Member

jayunit100 commented Aug 19, 2021

hi folks, anyone looking at this ?

@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Dec 18, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 18, 2021
@thockin thockin removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Dec 20, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Mar 20, 2022

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented Apr 19, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 19, 2022
@k8s-triage-robot
Copy link

k8s-triage-robot commented May 19, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 19, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/network Categorizes an issue or PR as relevant to SIG Network. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team wg/component-standard Categorizes an issue or PR as relevant to WG Component Standard.
Projects
Development

No branches or pull requests