-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate the kube-scheduler ComponentConfig to GA #785
Comments
We need a thorough API review of the kube-scheduler component config in the light of unifying them for all components. Moving what we have to beta in the 1.14 time frame feels like rushing in the light of us having just started with component-base. |
@luxas I don't see a KEP for this issue links in the description. I'm removing it from the 1.14 milestone - to have it added back please file an exception request. |
@luxas I'm the enhancement lead for 1.15. I don't see a KEP filed for this enhancement and per the guidelines, all enhancements will require one. Please let me know if this issue will have any work involved for this release cycle and update the original post reflect it. Thanks! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
Enhancement issues opened in /remove-lifecycle frozen |
Hey there @luxas, I'm one of the 1.16 Enhancement Shadows. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label. Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly. As a reminder, every enhancement requires a KEP in an implementable state with Graduation Criteria explaining each alpha/beta/stable stages requirements. Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29. Thank you. |
@mrbobbytables given that this issue does not have an owner and we didn't plan it for 1.16 in SIG scheduling, I doubt if this can make it to 1.16, but given that we still have another ~10 days before enhancement freeze, we may still be able to squeeze this in. If I find an owner for this, I will update it and will let you know. |
@bsalamat I’d like to work on this if you have not assign to anyone. |
@jfbai Please go ahead and send a KEP as soon as possible. The KEP must be merged by the end of July for this to be considered for 1.16. |
@bsalamat Are there any big changes against kube-scheduler configuraions when graduating to v1beta1? Or, just keep it same as v1alpha1? According to Moving ComponentConfig API types to staging repos, ComponentConfig is to split component config to internal and external with version, and move external versioned config to If I missed something important, could you please provide suggestion to accomplish this work, since I am lack of knowledge about related works. |
Initially we didn't plan to make any changes, but now we should make sure that fields are optional as is proposed by: #1173 We need to wait for that KEP to be implemented. For that reason, we cannot promote the scheduler config to beta in 1.16. |
I see, thanks a lot. |
/remove-lifecycle stale |
I'd like to take this as graduate CC to GA, mentioned by @alculquicondor before kubernetes/kubernetes#108444 (comment) |
Tracking TODOs:
|
Hello @kerthcet, @alculquicondor 👋, 1.25 Enhancements team here. Just checking in as we approach enhancements freeze on 18:00 PST on Thursday June 23, 2022. For note, This enhancement is targeting for stage Here's where this enhancement currently stands:
For note, the status of this enhancement is marked as |
Hello @kerthcet 👋 Checking in once more as we approach 1.25 code freeze at 01:00 UTC on Wednesday, 3rd August 2022. Please ensure the following items are completed:
Please verify, if there are any additional k/k PRs besides the ones listed above. Please plan to get the open PRs merged by the code freeze deadline. The status of the enhancement is currently marked as Also kindly update the issue description with the relevant links for tracking purposes. Thank you so much! |
With the code k/k PRs merged now, this enhancement is ready for the 1.25 code freeze. (updated) Will wait for the following PR to merge as well before marking it as tracked: |
FYI we have another related PR kubernetes/kubernetes#111547 here, just one log warning. @Priyankasaggu11929 |
Thanks so much for pointing @kerthcet. Have updated my comments above with the open PR ^ 🙂 |
With k/k PR kubernetes/kubernetes#111547 merged now, marking this enhancement as |
As the KEP has been marked as implemented, closing this issue. |
Enhancement Description
The kube-scheduler ComponentConfig is currently in v1alpha1. The spec needs to be graduated to v1beta1 and beyond in order to be usable widely.
/assign @bsalamat @k82cn
The text was updated successfully, but these errors were encountered: