New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-controller-manager ComponentConfig #786

Open
luxas opened this Issue Jan 30, 2019 · 8 comments

Comments

Projects
None yet
8 participants
@luxas
Copy link
Member

luxas commented Jan 30, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Usage of the kube-controller-manager configuration file is experimental, as the API version now is v1alpha1
  • Primary contact (assignee): @luxas
  • Responsible SIGs: @kubernetes/sig-api-machinery-api-reviews @kubernetes/wg-component-standard
  • Design proposal link (community repo): N/A
  • Link to e2e and/or unit tests:
  • Reviewer(s) - (for LGTM) recommend having 2+ reviewers (at least one from code-area OWNERS file) agreed to review. Reviewers from multiple companies preferred: @liggitt @deads2k
  • Approver (likely from SIG/area to which enhancement belongs): @liggitt @deads2k
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (x.y) v1.14
    • Beta release target (x.y) v1.15
    • Stable release target (x.y) v1.16

The kube-controller-manager ComponentConfig is currently in v1alpha1 and unserializable. It needs to become serializable, and then the spec needs to be graduated to v1beta1 and beyond in order to be usable widely.
/assign @liggitt @deads2k

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 30, 2019

controller manager doesn't even consume a config file currently, and the existing v1alpha1 config is not serializable. I'd expect serialization and config file loading while still in alpha to be the first stage, then promotion to beta the second step.

@luxas

This comment has been minimized.

Copy link
Member Author

luxas commented Jan 30, 2019

Yep, that indeed makes sense. This was just automatically generated as per request for tracking in k/enhancements overall. For this specific case, I can change to just "k-c-m ComponentConfig" and mark alpha for v1.14 (serializable)

@luxas luxas changed the title Graduate the kube-controller-manager ComponentConfig to v1beta1 kube-controller-manager ComponentConfig Jan 30, 2019

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Jan 30, 2019

+1 for alpha first.

@justinsb

This comment has been minimized.

Copy link
Member

justinsb commented Jan 31, 2019

Are we also planning on splitting the k-c-m config into per-controller kinds?

@stewart-yu

This comment has been minimized.

Copy link

stewart-yu commented Jan 31, 2019

+1 for alpha first. 😄
Had some pre-discuss with sttts before

@liggitt liggitt added the stage/alpha label Jan 31, 2019

@luxas

This comment has been minimized.

Copy link
Member Author

luxas commented Jan 31, 2019

Are we also planning on splitting the k-c-m config into per-controller kinds?

@justinsb yes.

@sttts

This comment has been minimized.

Copy link
Contributor

sttts commented Jan 31, 2019

Are we also planning on splitting the k-c-m config into per-controller kinds?

We also discussed this at KubeCon with @mtaufen and @luxas. It think this topic deserves a KEP to think through the usability implications of that. I can imagine how it is to choose the right v1alpha1, v1beta1, v1, v2 version on a per-controller basis. This is getting complicated. I can also see reason why we might want that though.

side note: we have those independent kinds per admission plugins.

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 5, 2019

@luxas I don't see a KEP for this issue linked - I'm removing it from the 1.14 milestone as having a KEP in an implementable state is a requirement for 1.14. To get this issue added back please submit an exception request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment