New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote Node OS/Arch labels to GA #793

Open
yujuhong opened this Issue Jan 31, 2019 · 9 comments

Comments

@yujuhong
Copy link
Member

yujuhong commented Jan 31, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):
kubelet: OS and Arch information is now recorded in `kubernetes.io/os` and `kubernetes.io/arch` labels on Node objects. The previous labels (`beta.kubernetes.io/os` and `beta.kubernetes.io/arch`) are still recorded, but are deprecated and targeted for removal in 1.18.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 31, 2019

@yujuhong: There are no sig labels on this issue. Please add a sig label.

A sig label can be added by either:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <group-name>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. See the group list.
The <group-suffix> in method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yujuhong yujuhong self-assigned this Jan 31, 2019

@yujuhong yujuhong added sig/node and removed needs-sig labels Jan 31, 2019

@yujuhong yujuhong added this to the v1.14 milestone Jan 31, 2019

@smarterclayton

This comment has been minimized.

Copy link
Contributor

smarterclayton commented Jan 31, 2019

I can do api review for this.

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 31, 2019

targeting stable for 1.14

@liggitt

This comment has been minimized.

Copy link
Member

liggitt commented Jan 31, 2019

assigned clayton for api review

@spiffxp spiffxp added the tracked/yes label Feb 7, 2019

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Feb 7, 2019

Adding tracked/yes label to reconcile against https://bit.ly/k8s114-enhancements
FYI @claurence @lachie83 @lledru @ameukam

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 11, 2019

@yujuhong are there any open PRs in k/k that need to be merged for this to be in 1.14? Code freeze is 3/7 and if the PRs are not able to merge by then this issue will be removed from the milestone.

@andrewsykim

This comment has been minimized.

Copy link
Member

andrewsykim commented Feb 15, 2019

I would like to shadow API review for this :)

@thockin

This comment has been minimized.

Copy link
Member

thockin commented Feb 15, 2019

@liggitt liggitt removed this from Assigned in API Reviews Feb 20, 2019

@claurence

This comment has been minimized.

Copy link

claurence commented Feb 22, 2019

@yujuhong looking over the KEP for this enhancement I don't see any testing plans - can someone help PR in testing plans for this enhancement? This information is helpful for knowing readiness of this feature for the release and is specifically useful for CI Signal.

If we don't have testing plans this enhancement will be at risk for being included in the 1.14 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment