Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodDisruptionBudget and /eviction subresource #85

Closed
12 tasks done
davidopp opened this issue Aug 30, 2016 · 94 comments
Closed
12 tasks done

PodDisruptionBudget and /eviction subresource #85

davidopp opened this issue Aug 30, 2016 · 94 comments
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Milestone

Comments

@davidopp
Copy link
Member

davidopp commented Aug 30, 2016

Enhancement Description

@davidopp
Copy link
Member Author

davidopp commented Aug 30, 2016

cc/ @mml

@jaredbhatti
Copy link

jaredbhatti commented Sep 7, 2016

@davidopp Are docs required for this feature?

@davidopp
Copy link
Member Author

davidopp commented Sep 7, 2016

Yes, @mml is starting to work on it.

@jaredbhatti
Copy link

jaredbhatti commented Sep 12, 2016

@mml Another ping on docs. Any PRs you can point me to?

@davidopp davidopp added this to the v1.5 milestone Oct 1, 2016
@davidopp davidopp added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Oct 1, 2016
@davidopp
Copy link
Member Author

davidopp commented Oct 1, 2016

Planning to move this to Beta in 1.5, see kubernetes/kubernetes#25321

@erictune
Copy link
Member

erictune commented Oct 13, 2016

Please consider kubernetes/kubernetes#34776 before beta, as addressing it might be a breaking API change (makes a required field optional).

@davidopp
Copy link
Member Author

davidopp commented Oct 14, 2016

Is it really not allowed to add a mutually exclusive field once something is already in Beta? I don't understand why that would be the case (I may be missing something though). I thought the "backward compatibility" requirement for Beta just meant that an object from the old API version has to be usable in the new binary version. It seems that would be the case, since the new binary version understands both fields.

@idvoretskyi
Copy link
Member

idvoretskyi commented Dec 13, 2016

@davidopp can you confirm that this item targets beta in 1.6?

@idvoretskyi idvoretskyi modified the milestones: next-milestone, v1.5 Dec 13, 2016
@davidopp
Copy link
Member Author

davidopp commented Dec 14, 2016

It was beta in 1.5. beta-in-1.5 label looks correct.

We don't have any short-term plan for additional work on this, so I'll close.

@idvoretskyi idvoretskyi modified the milestones: v1.5, next-milestone Dec 15, 2016
@mikedanese
Copy link
Member

mikedanese commented Feb 14, 2017

@davidopp when is this going to GA? should we keep this open until then?

cc @maisem

@davidopp davidopp removed this from the v1.5 milestone Feb 20, 2017
@davidopp
Copy link
Member Author

davidopp commented Feb 20, 2017

Yeah, let's reopen until it goes to GA. Not sure when that's happening, so I've removed the milestone. The sig-apps folks have had various ideas for changes we should make before GA but we haven't had bandwidth to discuss it. I assume the discussion will happen on kubernetes/kubernetes#25321

@reylejano
Copy link
Member

reylejano commented Mar 12, 2021

Hello @mortent , 1.21 Docs lead here.
Does this enhancement work planned for 1.21 require any new docs or modification to existing docs?
If so, please follows the steps here to open a PR against dev-1.21 branch in the k/website repo. This PR can be just a placeholder at this time and must be created by March 16 EOD PST
Also take a look at Documenting for a release to get yourself familiarize with the docs requirement for the release.
Thank you!

@liggitt liggitt added this to GA cleanup in PodDisruptionBudget Apr 1, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 25, 2021
@liggitt liggitt modified the milestones: v1.21, v1.22 Apr 29, 2021
@liggitt
Copy link
Member

liggitt commented Apr 29, 2021

1.22 work is complete:

@liggitt liggitt moved this from GA cleanup to Complete in PodDisruptionBudget Apr 29, 2021
@liggitt liggitt assigned mortent and liggitt and unassigned mattfarina, prydonius and kow3ns Apr 29, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Apr 29, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 6, 2021

Hey @liggitt, 1.22 enhancements lead here 👋

This is broadly good, but I have a couple of questions:

  • Can you set the latest-milestone key in your kep.yaml to be "v1.22"?
  • After the changes to your KEP do any of the PRR questions need to be revisited?

@liggitt
Copy link
Member

liggitt commented May 6, 2021

Can you set the latest-milestone key in your kep.yaml to be "v1.22"?

Done in #2683

After the changes to your KEP do any of the PRR questions need to be revisited?

No, the 1.22 completions don't modify any PRR responses.

@JamesLaverack
Copy link
Member

JamesLaverack commented May 10, 2021

Great. With that merged you're all set for 1.22 enhancements freeze. 🎉

@JamesLaverack
Copy link
Member

JamesLaverack commented May 12, 2021

I'd normally ask if your participating SIG (SIG Scheduling) needed to do anything — but if you've already completed your k/k PR I'm going to assume you're all set. 😄

@JamesLaverack JamesLaverack added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label May 12, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 10, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2021
@liggitt
Copy link
Member

liggitt commented Aug 10, 2021

this was completed in 1.22

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 10, 2021

@liggitt: Closing this issue.

In response to this:

this was completed in 1.22

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhockenbury rhockenbury removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
Development

No branches or pull requests