Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable scale velocity for HPA #853

Closed
gliush opened this issue Feb 25, 2019 · 65 comments
Closed

Configurable scale velocity for HPA #853

gliush opened this issue Feb 25, 2019 · 65 comments
Assignees
Labels
sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@gliush
Copy link
Contributor

gliush commented Feb 25, 2019

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 25, 2019
@gliush
Copy link
Contributor Author

gliush commented Feb 25, 2019

/sig autoscaling

@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 25, 2019
@gliush gliush changed the title Configurable HPA velocity Configurable scale velocity for HPA Mar 7, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 11, 2019

Hi @gliush. I'm the Enhancement Lead for 1.15. Does this feature plan on being implemented into an alpha state for 1.15?

@gliush
Copy link
Contributor Author

gliush commented Apr 11, 2019

Hi @kacole2, I'm ok to implement it as soon as I get an approval. So, I'm ok with 1.15 as well as with 1.xx version :)

@kacole2
Copy link
Member

kacole2 commented Apr 12, 2019

@gliush Enhancement Freeze is April 30th. Code Freeze is May 29th. We need a KEP approved and merged before these deadlines to be included.

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 12, 2019
@kacole2 kacole2 added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 14, 2019
@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @gliush

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 29, 2019

@gliush Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@mrbobbytables
Copy link
Member

mrbobbytables commented May 1, 2019

@gliush Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you.

@mrbobbytables mrbobbytables removed this from the v1.15 milestone May 1, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 1, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

Hi @gliush , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@josephburnett
Copy link
Member

josephburnett commented Jul 10, 2019

@kacole2, yes, I think we should target alpha for 1.16. Are there documented requirements for what is required for an alpha feature?

@gliush this means we need to land all the code by 8/29. I have a TODO to review your PR kubernetes/kubernetes#74525 this week.

@kacole2
Copy link
Member

kacole2 commented Jul 10, 2019

@josephburnett I'll get this added to the tracking sheet. As for requirements to be considered alpha is all based on the graduation criteria in the KEP. I just checked out 20190307-configurable-scale-velocity-for-hpa and noticed there is no graduation criteria. I would talk amongst the SIG and establish what requirements are necessary for graduating between stages going forward. Get those merged into the KEP and then you will have a community consensus. Lastly, the KEP is currently in a provisional state. KEPs must be in an Implementable state which requires SIG owners to LGTM and Approve.

I would focus on doing those first before trying to get the code landed.

@kacole2 kacole2 added this to the v1.16 milestone Jul 10, 2019
@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jul 10, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Jul 29, 2019

@josephburnett @gliush I'm one of the 1.16 Enhancement Shadows -- I just wanted to check in. Do you think the KEP will have the graduation criteria and be bumped to an implementable state by the freeze tomorrow?

@kacole2
Copy link
Member

kacole2 commented Jul 31, 2019

@josephburnett @gliush

Enhancement Freeze has passed for 1.16. The KEP at is still in a Provisional state and now this is being removed from the 1.16 milestone. If this would like to be re-added, please file an exception and it will require approval from the release lead.

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.16 milestone Jul 31, 2019
@kacole2 kacole2 removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jul 31, 2019
@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 31, 2020

Exception request was approved. Adding back to the milestone.
/milestone v1.18

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 31, 2020
@jeremyrickard jeremyrickard added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jan 31, 2020
@arjunrn
Copy link
Contributor

arjunrn commented Feb 1, 2020

@jeremyrickard The test plan was merged into the kep. I think we don't need the exception anymore. Also this PR on k/k for this enhancement was already merged. But I cannot find this feature listed in the changelog. Is there something missing from our end. Is it just because this KEP was left in the implementable state? Because I've changed it to implemented now.

@savitharaghunathan
Copy link
Member

savitharaghunathan commented Feb 3, 2020

Hello, @gliush @josephburnett @arjunrn :) 1.18 docs shadow here. Does this enhancement work planned for 1.18 require any new docs (or modifications to existing docs)? If not, can you please update the 1.18 Enhancement Tracker Sheet (or let me know and I'll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.18) due by Friday, Feb 28th, it can just be a placeholder PR at this time. Let me know if you have any questions!

Thanks,
Savitha

@arjunrn
Copy link
Contributor

arjunrn commented Feb 3, 2020

@savitharaghunathan Here is the PR. The changes were originally made against master but they have been reverted. Can you also add the PR to the Enhancement Tracker.

@savitharaghunathan
Copy link
Member

savitharaghunathan commented Feb 3, 2020

@arjunrn - thanks for the update. I will link the PR to the enhancements tracker.

@gliush
Copy link
Contributor Author

gliush commented Feb 5, 2020

@jeremyrickard , @savitharaghunathan: could you confirm that this is going to be part of 1.18 and we don't miss anything?

@palnabarun
Copy link
Member

palnabarun commented Feb 5, 2020

@gliush This enhancement surely satisfies all criteria to be part of the release cycle.

Just a few concerning things:

  1. The KEP status is set to implemented, whereas it should have been implementable if it yet to be implemented. The status is set to implemented only when an enhancement graduates successfully to the stable phase.
  2. Can you please confirm which graduation stage are you targeting this release cycle?

@palnabarun
Copy link
Member

palnabarun commented Feb 5, 2020

PS: We are actively tracking it on the tracking sheet

@palnabarun
Copy link
Member

palnabarun commented Feb 5, 2020

Investigating further, the PR that set the status to implemented: #1522

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 5, 2020

As @palnabarun pointed out, you're going to need to update this to implementable. You won't set the status to implemented until it graduates to stable. @arjunrn @gliush

You don't need another exception to fix that, but please do it ASAP.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Feb 11, 2020

Hey @gliush

I think everything for this is merged yes? Could you link us to the PRs that merged the implementation for this enhancement so we can update the tracking sheet? Code freeze for 1.18 is March 05, 2020, so anything additional will need to be completed and merged prior to that.

@gliush
Copy link
Contributor Author

gliush commented Feb 11, 2020

Hi @jeremyrickard

Yes, everything seems to be merged.

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 17, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/milestone clear

(removing this enhancement issue from the v1.18 milestone as the milestone is complete)

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Apr 29, 2020
@gliush
Copy link
Contributor Author

gliush commented Apr 30, 2020

This enhancement was merged. What should I do with it? I don't see good documentation anywhere that explains the usual enhancement flow.
Should I just close the issue? Should I mention somewhere that the enhancement is merged in 1.18?

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 4, 2020

@gliush So, as I read it, this was implemented as part of a beta API, so there will be no separate graduation for this feature. It will graduate with that API. Therefore, we can just close this!

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 4, 2020

@johnbelamaric: Closing this issue.

In response to this:

@gliush So, as I read it, this was implemented as part of a beta API, so there will be no separate graduation for this feature. It will graduate with that API. Therefore, we can just close this!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 4, 2020

/milestone v1.18

Since that is when it was implemented.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone May 4, 2020
@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 4, 2020

/stage beta

Also, we would categorize this as "a change to an existing beta API", so I believe the stage should be beta. @palnabarun , make sense?

@k8s-ci-robot k8s-ci-robot added stage/beta Denotes an issue tracking an enhancement targeted for Beta status and removed stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status labels May 4, 2020
@palnabarun
Copy link
Member

palnabarun commented May 4, 2020

@johnbelamaric LGTM! 🙂

@gliush
Copy link
Contributor Author

gliush commented May 4, 2020

@johnbelamaric : Thank you very much for explanation, it was really helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests