Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include kubectl command metadata in http request headers #859

Closed
pwittrock opened this issue Feb 27, 2019 · 69 comments
Closed

Include kubectl command metadata in http request headers #859

pwittrock opened this issue Feb 27, 2019 · 69 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Milestone

Comments

@pwittrock
Copy link
Member

pwittrock commented Feb 27, 2019

Include kubectl command metadata in http request headers

@pwittrock pwittrock added this to the v1.15 milestone Feb 27, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 27, 2019
@pwittrock pwittrock added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 27, 2019
@pwittrock pwittrock added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ labels Feb 27, 2019
@pwittrock
Copy link
Member Author

pwittrock commented Feb 27, 2019

cc @kubernetes/sig-api-machinery-misc
cc @kubernetes/sig-cli-misc
cc @soltysh
cc @deads2k

@kacole2
Copy link
Member

kacole2 commented Apr 11, 2019

@pwittrock can you please update the original post with the correct formatting so we have consistency?

# Enhancement Description
- One-line enhancement description (can be used as a release note):
- Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
- Primary contact (assignee):
- Responsible SIGs:
- Enhancement target (which target equals to which milestone):
  - Alpha release target (x.y)
  - Beta release target (x.y)
  - Stable release target (x.y)

@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 14, 2019
@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @pwittrock

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 29, 2019

@pwittrock Are you still looking to move forward with this KEP as a part of the 1.15 milestone? The 1.15 Enhancement Freeze is 4/30/2019 (tomorrow). If so, please update the original post with the supporting information so that we can make the appropriate tracking changes.

@daminisatya
Copy link
Member

daminisatya commented May 18, 2019

Hey, @pwittrock @mrbobbytables Is this enhancement still targeted for v1.15?

@daminisatya
Copy link
Member

daminisatya commented May 27, 2019

@pwittrock Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

@mrbobbytables
Copy link
Member

mrbobbytables commented May 28, 2019

Hi @pwittrock . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please update the issue with the supporting information and list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@kacole2
Copy link
Member

kacole2 commented May 31, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 31, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 31, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

Hi @pwittrock , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@kcmartin
Copy link

kcmartin commented Oct 2, 2019

Hello @pwittrock -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

@fejta-bot
Copy link

fejta-bot commented Dec 31, 2019

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2019
@gracenng
Copy link
Member

gracenng commented May 11, 2021

Hi @seans3 👋 1.22 Enhancements Shadow here.

Does sig-cli need to do anything for this enhancement and if so, is the SIG ok with it?

I also have some minor change requests in light of Enhancement Freeze on Thursday May 13th:

  • PRR not approved for beta
  • In kep.yaml, update alpha latest-milestone and milestone
  • In kep.yaml, answer the PRR questions for beta (metrics)
  • In README, clarify the Graduation Criteria for alpha and beta (see latest template)

Thanks!

@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 11, 2021

You can assign me as PRR approver. Thanks.

@JamesLaverack
Copy link
Member

JamesLaverack commented May 14, 2021

Hi @seans3, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release as there is no beta graduation criteria in your KEP.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.22 milestone May 14, 2021
@JamesLaverack JamesLaverack added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 14, 2021
@JamesLaverack
Copy link
Member

JamesLaverack commented May 18, 2021

Hey @seans3, as per the discussion on the SIG Release mailing list this enhancement's exception request has been approved.

With #2747 merged, this is in a good state for 1.22.

/milestone v1.22

@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone May 18, 2021
@JamesLaverack JamesLaverack added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 18, 2021
@carlisia
Copy link
Member

carlisia commented May 19, 2021

Hello @pwittrock 👋, 1.22 Docs Shadow here.
This enhancement is marked as ‘Needs Docs’ for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙏

@gracenng
Copy link
Member

gracenng commented Jun 23, 2021

Hi @pwittrock, 1.22 enhancements shadow here.

In light of Code Freeze on July 8th is k/k#98952 the only PR for this enhancements?
Please link the associated PRs in this issue so enhancements can easily keep track.
Thank you!

@carlisia
Copy link
Member

carlisia commented Jun 28, 2021

Hey @pwittrock, friendly reminder that this enhancement will also need docs, thank you!

@seans3
Copy link
Contributor

seans3 commented Jun 28, 2021

Hey Phillip Wittrock, friendly reminder that this enhancement will also need docs, thank you!

Hi @carlisia . Thanks for the reminder. We will be adding a small update to kubectl docs to show how to turn these headers off. My understanding is the docs deadline is end of July--is that correct?

@carlisia
Copy link
Member

carlisia commented Jun 28, 2021

This is the instructions we have:

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

@salaxander salaxander added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Aug 19, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Nov 17, 2021

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 17, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Dec 17, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 17, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Jan 16, 2022

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 16, 2022

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests