Include kubectl command metadata in http request headers

[pwittrock]

Include kubectl command metadata in http request headers

• One-line enhancement description (can be used as a release note): kubectl adds http headers with the subcommand name, which flags were specified and a session id.
• Kubernetes Enhancement Proposal: PR Proposal for adding headers with the command name to kubectl requests #855 / https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/kubectl-commands-in-headers.md
• Primary contact (assignee):
• Responsible SIGs:
• Enhancement target (which target equals to which milestone):
  • Alpha release target (x.y)
  • Beta release target (x.y)
  • Stable release target (x.y)

[pwittrock]

cc @kubernetes/sig-api-machinery-misc
cc @kubernetes/sig-cli-misc
cc @soltysh
cc @deads2k

[kacole2]

@pwittrock can you please update the original post with the correct formatting so we have consistency?

# Enhancement Description
- One-line enhancement description (can be used as a release note):
- Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR)
- Primary contact (assignee):
- Responsible SIGs:
- Enhancement target (which target equals to which milestone):
  - Alpha release target (x.y)
  - Beta release target (x.y)
  - Stable release target (x.y)

[justaugustus]

/assign @pwittrock

[mrbobbytables]

@pwittrock Are you still looking to move forward with this KEP as a part of the 1.15 milestone? The 1.15 Enhancement Freeze is 4/30/2019 (tomorrow). If so, please update the original post with the supporting information so that we can make the appropriate tracking changes.

[daminisatya]

Hey, @pwittrock @mrbobbytables Is this enhancement still targeted for v1.15?

[daminisatya]

@pwittrock Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

[mrbobbytables]

Hi @pwittrock . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please update the issue with the supporting information and list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[kacole2]

/milestone clear

[kacole2]

Hi @pwittrock , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

[kcmartin]

Hello @pwittrock -- 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

• Monday, September 23 - Release Cycle Begins
• Tuesday, October 15, EOD PST - Enhancements Freeze
• Thursday, November 14, EOD PST - Code Freeze
• Tuesday, November 19 - Docs must be completed and reviewed
• Monday, December 9 - Kubernetes 1.17.0 Released

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[gracenng]

Hi @seans3 👋 1.22 Enhancements Shadow here.

Does sig-cli need to do anything for this enhancement and if so, is the SIG ok with it?

I also have some minor change requests in light of Enhancement Freeze on Thursday May 13th:

• PRR not approved for beta
• In kep.yaml, update alpha latest-milestone and milestone
• In kep.yaml, answer the PRR questions for beta (metrics)
• In README, clarify the Graduation Criteria for alpha and beta (see latest template)

Thanks!

[johnbelamaric]

You can assign me as PRR approver. Thanks.

[JamesLaverack]

Hi @seans3, 1.22 Enhancements Lead here. 👋 With enhancements freeze now in effect we are removing this enhancement from the 1.22 release as there is no beta graduation criteria in your KEP.

Feel free to file an exception to add this back to the release. If you plan to do so, please file this as early as possible.

Thanks!
/milestone clear

[JamesLaverack]

Hey @seans3, as per the discussion on the SIG Release mailing list this enhancement's exception request has been approved.

With #2747 merged, this is in a good state for 1.22.

/milestone v1.22

[carlisia]

Hello @pwittrock 👋, 1.22 Docs Shadow here.
This enhancement is marked as ‘Needs Docs’ for the 1.22 release.

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

Also, take a look at Documenting for a release to familiarize yourself with the docs requirement for the release.

Thank you! 🙏

[gracenng]

Hi @pwittrock, 1.22 enhancements shadow here.

In light of Code Freeze on July 8th is k/k#98952 the only PR for this enhancements?
Please link the associated PRs in this issue so enhancements can easily keep track.
Thank you!

[carlisia]

Hey @pwittrock, friendly reminder that this enhancement will also need docs, thank you!

[seans3]

Hey Phillip Wittrock, friendly reminder that this enhancement will also need docs, thank you!

Hi @carlisia . Thanks for the reminder. We will be adding a small update to kubectl docs to show how to turn these headers off. My understanding is the docs deadline is end of July--is that correct?

[carlisia]

This is the instructions we have:

Please follow the steps detailed in the documentation to open a PR against dev-1.22 branch in the k/website repo. This PR can be just a placeholder at this time and must be created before Fri July 9, 11:59 PM PDT.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.