Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even pod spreading across failure domains #895

Closed
bsalamat opened this issue Mar 14, 2019 · 48 comments
Closed

Even pod spreading across failure domains #895

bsalamat opened this issue Mar 14, 2019 · 48 comments
Assignees
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@bsalamat
Copy link
Member

bsalamat commented Mar 14, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): This feature enables Kubernetes scheduler to spread a group of pods across failure domains. The existing hard inter-pod anti-affinity does not allow more than one pod to exist in a failure domain. The new feature supports more than one pod in a failure domain.
  • KEP: 20190221-pod-topology-spread.md
  • Primary contact (assignee): @Huang-Wei
  • Responsible SIGs: Scheduling
  • Enhancement target (which target equals to which milestone):
    • Alpha release target - 1.16
    • Beta release target - 1.18
    • Stable release target (x.y)
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 14, 2019
@bsalamat bsalamat added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 14, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 11, 2019

@bsalamat I'm going to add this to the 1.15 milestone for tracking purposes. Once the KEP has been merged lets get the link updated. As usual, put any relevant k/k PRs to be tracked in this issue. Thanks!

/milestone v1.15
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 11, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 11, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 14, 2019
@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @Huang-Wei

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 29, 2019

@bsalamat, @Huang-Wei Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@Huang-Wei
Copy link
Member

Huang-Wei commented Apr 29, 2019

@mrbobbytables thanks for the reminder.

@bsalamat I've raised #996 to address above concerns.

@daminisatya
Copy link
Member

daminisatya commented May 18, 2019

Hey, @Huang-Wei @bsalamat I'm the v1.15 docs release shadow.

I see that you are targeting the alpha version of this enhancement for the 1.15 release. Does this require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

@daminisatya
Copy link
Member

daminisatya commented May 27, 2019

@Huang-Wei @bsalamat

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

@mrbobbytables
Copy link
Member

mrbobbytables commented May 28, 2019

@Huang-Wei @bsalamat. Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@mrbobbytables
Copy link
Member

mrbobbytables commented May 30, 2019

@Huang-Wei @bsalamat, today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@kacole2
Copy link
Member

kacole2 commented May 31, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 31, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 31, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

Hi @bsalamat @Huang-Wei , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@Huang-Wei
Copy link
Member

Huang-Wei commented Jul 9, 2019

@kacole2 Yes, it's on the right track for 1.16, and it will be an Alpha feature.

@kacole2 kacole2 added this to the v1.16 milestone Jul 9, 2019
@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Jul 9, 2019
@daminisatya
Copy link
Member

daminisatya commented Aug 6, 2019

@bsalamat @Huang-Wei

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

@Huang-Wei
Copy link
Member

Huang-Wei commented Aug 6, 2019

@daminisatya It needs new docs. The doc PR (placeholder atm) has been created - kubernetes/website#15514

@Huang-Wei
Copy link
Member

Huang-Wei commented Feb 4, 2020

@savitharaghunathan I created a placeholder PR here kubernetes/website#18969

@palnabarun
Copy link
Member

palnabarun commented Feb 5, 2020

Hi @Huang-Wei, just a friendly reminder that the Code Freeze will go into effect on Thursday 5th March.

Can you please link all the k/k PRs or any other PRs which should be tracked for this enhancement?

Thank You :)

@Huang-Wei
Copy link
Member

Huang-Wei commented Feb 9, 2020

@palnabarun Here is an umbrella issue (kubernetes/kubernetes#87662) tracking the PRs. It progresses well right now - an e2e PR and a document PR need to be finished.

@palnabarun
Copy link
Member

palnabarun commented Feb 9, 2020

Thank you @Huang-Wei for the updates. It's great to see the progress. :)

@Huang-Wei
Copy link
Member

Huang-Wei commented Mar 17, 2020

@palnabarun All items to qualify this feature to be beta in 1.18 has been completed. Feel free to update the description of this issue.

@palnabarun
Copy link
Member

palnabarun commented Mar 18, 2020

Thanks @Huang-Wei for the efforts. 👏

I will update the issue comment.

@palnabarun palnabarun added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Apr 17, 2020
@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

/milestone clear

(removing this enhancement issue from the v1.18 milestone as the milestone is complete)

@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone Apr 29, 2020
@Huang-Wei
Copy link
Member

Huang-Wei commented Apr 29, 2020

@palnabarun we'd like to promote it to GA in 1.19.

@palnabarun
Copy link
Member

palnabarun commented May 1, 2020

Hi @Huang-Wei, thank you for the update. We will update the tracking sheet accordingly. 👍

@palnabarun palnabarun added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 4, 2020
@palnabarun
Copy link
Member

palnabarun commented May 4, 2020

/stage stable
/milestone v1.19

@k8s-ci-robot k8s-ci-robot added stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status labels May 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 4, 2020
@Huang-Wei
Copy link
Member

Huang-Wei commented May 19, 2020

#1796 is just adopting the new KEP template (with PRR).

@divya-mohan0209
Copy link
Contributor

divya-mohan0209 commented May 21, 2020

Hey, @Huang-Wei @bsalamat I'm one of the v1.19 docs release shadows.

Could you please let me know if this piece of enhancement work planned requires any new docs (or modifications to existing docs) for 1.19 release?

If not, can you please update the 1.19 Enhancement Tracker Sheet (or let me know and I'll do so) :)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.19) due by Friday, June 12, it can just be a placeholder PR at this time. Let me know if you have any questions!

Regards,
Divya

@Huang-Wei
Copy link
Member

Huang-Wei commented May 21, 2020

@divya-mohan0209 kubernetes/website#21115 acts as a placeholder.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 15, 2020

Hi @Huang-Wei Just to confirm: is this now code complete for 1.19 GA?

@Huang-Wei
Copy link
Member

Huang-Wei commented Jun 15, 2020

@kikisdeliveryservice yes, all code items have been completed - tracked at kubernetes/kubernetes#89433 (comment).

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Jun 15, 2020

Hi @Huang-Wei !

Thanks for letting me know! This is mostly not applicable as your code is complete, but to follow-up on the email sent to k-dev today, I wanted to let you know that Code Freeze has been extended to Thursday, July 9th. You can see the revised schedule here: https://github.com/kubernetes/sig-release/tree/master/releases/release-1.19

Please let me know if you have any questions. 😄

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Sep 11, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi all

Enhancements Lead here. As this graduated to stable in 1.19 and the underlying KEP is marked implemented I am closing this issue.

Thank you for all of your work!!

Best,
Kirsten

@kikisdeliveryservice kikisdeliveryservice removed this from the v1.19 milestone Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests