Add go module support to k8s.io/kubernetes

[liggitt]

Enhancement Description

• One-line enhancement description (can be used as a release note): Add go module support to k8s.io/kubernetes
• Kubernetes Enhancement Proposal: https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-03-19-go-modules.md
• Primary contact (assignee): @liggitt
• Responsible SIGs: sig-architecture, sig-api-machinery
• Enhancement target (which target equals to which milestone):
  • Stable release target (v1.15)

Announcement:

• https://groups.google.com/d/msg/kubernetes-dev/ECejidBCELI/Scc5zgGlBgAJ

Developer experience impact:

• Before: dependency updates must be performed on a linux machine, took ~30 minutes, and failed frequently (~50% in unscientific local attempts)
• After: dependency updates can be done on any OS, take ~1-2 minutes, and succeed reliably

Design updates:

• initial go modules draft #908
• Update go.modules KEP #916
• Update published modules with v0.x.y tags #1350

Associated changes:

• add go module support, manage vendor directory using go mod vendor kubernetes#74877
• Add preliminary go module instructions to client-go kubernetes#75595
• Make pin-dependency.sh work with things other than docker kubernetes#76149
• Update vendored dependencies kubernetes#76215
• stop clearing GOPATH in vendor scripts kubernetes#76511
• Update client-go module install instructions kubernetes#76567
• Prune matching replace directives in staging repos more effectively kubernetes#77753
• Allow hack/lint-dependencies.sh to skip golang.org/x/... deps, verify in verify-vendor.sh kubernetes#79944
• go-mod support publishing-bot#169
• sync-tags: add support for v0.x.y tags publishing-bot#210

Documentation:

• https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/vendor.md
• https://github.com/liggitt/gomodules/
• https://www.youtube.com/watch?v=OrMA16ASz2U&t=40s

[daminisatya]

Hey, @liggitt I'm the v1.15 docs release shadow.

Does this require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Thursday, May 30th. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! 😄

[liggitt]

The only documentation changes are developer facing and have already merged:

• https://github.com/kubernetes/client-go/blob/master/INSTALL.md#go-modules
• https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/vendor.md

[daminisatya]

Thank you @liggitt

[mrbobbytables]

Hi @liggitt . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

[liggitt]

There are no pending PRs

[kacole2]

This has graduated stable so closing it down
/milestone clear
/close

[k8s-ci-robot]

@kacole2: Closing this issue.

In response to this:

This has graduated stable so closing it down
/milestone clear
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.