Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod-startup liveness-probe holdoff for slow-starting pods #950

Closed
matthyx opened this issue Apr 11, 2019 · 73 comments · Fixed by #1988
Closed

Add pod-startup liveness-probe holdoff for slow-starting pods #950

matthyx opened this issue Apr 11, 2019 · 73 comments · Fixed by #1988
Assignees
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@matthyx
Copy link
Contributor

matthyx commented Apr 11, 2019

Enhancement Description

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 11, 2019
@matthyx
Copy link
Contributor Author

matthyx commented Apr 11, 2019

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 11, 2019
@matthyx
Copy link
Contributor Author

matthyx commented Apr 11, 2019

/assign @derekwaynecarr

@matthyx
Copy link
Contributor Author

matthyx commented Apr 11, 2019

/kind api-change

@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Apr 11, 2019
@matthyx
Copy link
Contributor Author

matthyx commented Apr 11, 2019

/milestone v1.15

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 11, 2019

@matthyx: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matthyx
Copy link
Contributor Author

matthyx commented Apr 11, 2019

/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 11, 2019
@kacole2 kacole2 added this to the v1.15 milestone Apr 11, 2019
@kacole2 kacole2 added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 14, 2019
@matthyx
Copy link
Contributor Author

matthyx commented Apr 23, 2019

@kacole2 the feature is implemented in this PR: kubernetes/kubernetes#71449

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 29, 2019

@matthyx Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@matthyx
Copy link
Contributor Author

matthyx commented Apr 29, 2019

Hi Bob!
Please have a look at #1014
I have already talked to @derekwaynecarr to have a look, he suggested adding a feature gate to the document, which I did.
I am also waiting for some feedback from @thockin after answering his concerns.

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 29, 2019

@matthyx Great! Thanks for the info :) Will keep an eye on #1014

@matthyx
Copy link
Contributor Author

matthyx commented Apr 30, 2019

@mrbobbytables I haven't heard of them during the night... not sure we'll meet the deadline :-(

@thockin thockin changed the title Add initializationFailureThreshold to health probes Add pod-startup liveness-probe holdoff for slow-starting pods Apr 30, 2019
@matthyx
Copy link
Contributor Author

matthyx commented May 1, 2019

@mrbobbytables I have the support of @thockin for this KEP, can we maintain it in 1.15?
We're just discussing the implementation now, but the fundamentals are more or less agreed upon.

@mrbobbytables
Copy link
Member

mrbobbytables commented May 1, 2019

@matthyx Enhancement Freeze for Kubernetes 1.15 has passed and this unfortunately did not meet the deadline. It's being removed from the 1.15 milestone and the tracking sheet, but it looks like you're already on track to get an Enhancement Exception in. 👍 Thanks for being on point about it :)

@mrbobbytables mrbobbytables removed this from the v1.15 milestone May 1, 2019
@mrbobbytables mrbobbytables added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 1, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented May 1, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 1, 2019
@johnbelamaric
Copy link
Contributor

johnbelamaric commented May 4, 2020

Sure.

/milestone v1.20

@qixiaobo
Copy link

qixiaobo commented Jul 16, 2020

Enhancement Description

  • One-line enhancement description (can be used as a release note): adds initializationFailureThreshold to probes allowing a greater number of failures during the initial start of the container.

  • Kubernetes Enhancement Proposal: 20190221-livenessprobe-holdoff

  • Primary contact (assignee): @matthyx

  • Responsible SIGs: @kubernetes/sig-node-api-reviews

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y) v1.16
    • Beta release target (x.y) v1.XY
    • Stable release target (x.y) v1.XY

Glad to hear this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 16, 2020

@qixiaobo: Reiterating the mentions to trigger a notification:
@kubernetes/sig-node-api-reviews

In response to this:

Enhancement Description

  • One-line enhancement description (can be used as a release note): adds initializationFailureThreshold to probes allowing a greater number of failures during the initial start of the container.

  • Kubernetes Enhancement Proposal: 20190221-livenessprobe-holdoff

  • Primary contact (assignee): @matthyx

  • Responsible SIGs: @kubernetes/sig-node-api-reviews

  • Enhancement target (which target equals to which milestone):

    • Alpha release target (x.y) v1.16
    • Beta release target (x.y) v1.XY
    • Stable release target (x.y) v1.XY

Glad to hear this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 11, 2020

Hi @matthyx !

Enhancements Lead here, do you still intend to go GA in 1.20?

Thanks!
Kirsten

@matthyx
Copy link
Contributor Author

matthyx commented Sep 12, 2020

Hi @kikisdeliveryservice

I actually did already with this PR: kubernetes/kubernetes#94160
I just need to merge the corresponding doc: kubernetes/website#23332

@kikisdeliveryservice kikisdeliveryservice added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Sep 12, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

@matthyx Perfect thank you for the update!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 12, 2020

Also just as a reminder once this feature totally complete and all of your PRs are merged, please update the kep to have a status of implemented: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/20190221-livenessprobe-holdoff.md

@matthyx
Copy link
Contributor Author

matthyx commented Sep 12, 2020

sure!

@mikejoh
Copy link

mikejoh commented Sep 27, 2020

Hi @matthyx 👋!

I'm one of the Enhancement shadows for the 1.20 release cycle. Not exactly relevant to this KEP since it's almost completed, but the Enhancement freeze is on the 6th of Oct.

It looks like one of the last things to do is to get the following PR (#1988) merged to move this KEP to implemented, there's one lgtm at this point and i guess there's someone you can poke at to get it approved!

Thanks!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Nov 9, 2020

Keeping this open for tracking until we close the milestone :)

@annajung annajung removed this from the v1.20 milestone Jan 7, 2021
@annajung annajung removed stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jan 7, 2021
@annajung
Copy link
Member

annajung commented Jan 7, 2021

Hello, 1.21 Enhancement lead here.
I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 7, 2021

@annajung: Closing this issue.

In response to this:

Hello, 1.21 Enhancement lead here.
I'm closing out this issue since the enhancement is GA and KEP has been updated to implemented.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matthyx
Copy link
Contributor Author

matthyx commented Jan 7, 2021

Thanks @annajung !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/node Categorizes an issue or PR as relevant to SIG Node. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

Successfully merging a pull request may close this issue.