Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior-driven conformance testing #960

Closed
johnbelamaric opened this issue Apr 13, 2019 · 28 comments
Closed

Behavior-driven conformance testing #960

johnbelamaric opened this issue Apr 13, 2019 · 28 comments
Assignees
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status

Comments

@johnbelamaric
Copy link
Contributor

johnbelamaric commented Apr 13, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Behaviors for conformance are defined up front, separately from the tests which validate those behaviors.
  • Kubernetes Enhancement Proposal: Add KEP for Behavior-driven Conformance Testing #959
  • Primary contact (assignee): @johnbelamaric
  • Responsible SIGs: sig-architecture
  • Enhancement target (which target equals to which milestone):
    • Stable release target (1.15)
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 13, 2019
@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Apr 13, 2019

/assign
/sig architecture

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 13, 2019
@kacole2
Copy link
Member

kacole2 commented Apr 14, 2019

/milestone v1.15
/stage stable

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Apr 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 14, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Apr 14, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 29, 2019

@johnbelamaric Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Apr 29, 2019

Yes, this will likely slip, we still have a lot of details to work out.

@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Apr 29, 2019

/milestone v1.16

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 29, 2019

@johnbelamaric: You must be a member of the kubernetes/kubernetes-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kacole2
Copy link
Member

kacole2 commented May 2, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 2, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 2, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

Hi @johnbelamaric , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@palnabarun
Copy link
Member

palnabarun commented Oct 1, 2019

Hey there @johnbelamaric , 1.17 Enhancements shadow here. I wanted to check in and see if you think this Enhancement will be graduating to alpha in 1.17?

The current release schedule is:

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

If you do, I'll add it to the 1.17 tracking sheet (https://bit.ly/k8s117-enhancement-tracking). Once coding begins please list all relevant k/k PRs in this issue so they can be tracked properly. 👍

Thanks!

@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Oct 2, 2019

Yes, I am targeting phase 1 for this cycle. Phase 1 is/will be defined in #1267

@mrbobbytables
Copy link
Member

mrbobbytables commented Oct 14, 2019

Thanks @johnbelamaric :) We'll add it to the tracking sheet. 👍

@mrbobbytables mrbobbytables added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Oct 14, 2019
@palnabarun
Copy link
Member

palnabarun commented Oct 16, 2019

/milestone v1.17

@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Oct 16, 2019
@pgburt
Copy link

pgburt commented Oct 22, 2019

Hello @johnbelamaric , I'm one of the v1.17 docs shadows.
Does this enhancement (or the work planned for v1.17) require any new docs (or modifications to existing docs)? If not, please update the 1.17 Enhancement Tracker Sheet (or let me know and I'll do so).

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.17) due by Friday, November 8th, it can just be a placeholder PR at this time. Let me know if you have any questions!

@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Oct 22, 2019

No, no user-facing docs, thanks.

@palnabarun
Copy link
Member

palnabarun commented Nov 5, 2019

Hi @johnbelamaric

I am one of the Enhancements Shadow for the 1.17 Release Team. We are very near to the Code Freeze (Nov 14th) for this release cycle. Just checking in about the progress of this enhancement. see that
kubernetes/kubernetes#83964 was filed in relation to this. Is there any other PR related to this enhancement? If yes, can you please link them here?

Thank you in advance 😄

@Jefftree
Copy link
Member

Jefftree commented Nov 6, 2019

@palnabarun: kubernetes/kubernetes#83964 is the only related PR. It should be merged before Nov 14.

@palnabarun
Copy link
Member

palnabarun commented Nov 7, 2019

Thank you for the updates @Jefftree :)

@palnabarun
Copy link
Member

palnabarun commented Nov 13, 2019

Hi @johnbelamaric @Jefftree , tomorrow is code freeze for the 1.17 release cycle. It looks like kubernetes/kubernetes#83964 has not yet been merged. We're flagging as the enhancement as At Risk in the 1.17 Enhancement Tracking Sheet.

Do you think they will be merged by the EoD of the 14th (Thursday)? After that point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@Jefftree
Copy link
Member

Jefftree commented Nov 13, 2019

@palnabarun: Yes it should be merged by EOD Thursday.

@palnabarun
Copy link
Member

palnabarun commented Nov 13, 2019

@Jefftree Awesome! 😃

@palnabarun
Copy link
Member

palnabarun commented Nov 15, 2019

@Jefftree I see that kubernetes/kubernetes#83964 has been merged. Really appreciate the efforts that have been put in.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 3, 2020

Hey @Jefftree @johnbelamaric, 1.18 Enhancements lead here 👋. Happy New Year from the 1.18 Release Team! As this graduated in 1.17, could you update the KEP to indicate that this has been implemented? Then we can close this issue out! Thanks!

@jeremyrickard jeremyrickard removed the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Jan 3, 2020
@johnbelamaric
Copy link
Contributor Author

johnbelamaric commented Mar 24, 2020

/milestone v1.19

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.17, v1.19 Mar 24, 2020
@palnabarun
Copy link
Member

palnabarun commented May 20, 2020

@johnbelamaric -- Should this enhancement be tracked by us? Or, does it qualify for tracked/out-of-tree?

@fejta-bot
Copy link

fejta-bot commented Aug 18, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@Jefftree
Copy link
Member

Jefftree commented Aug 18, 2020

KEP has been withdrawn.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 18, 2020

@Jefftree: Closing this issue.

In response to this:

KEP has been withdrawn.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

palnabarun commented Aug 19, 2020

/milestone clear

(since it wasn't part of the 1.19 cycle)

@k8s-ci-robot k8s-ci-robot removed this from the v1.19 milestone Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status
Projects
None yet
Development

No branches or pull requests

9 participants