Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionHook #962

Closed
xing-yang opened this issue Apr 14, 2019 · 65 comments
Closed

ExecutionHook #962

xing-yang opened this issue Apr 14, 2019 · 65 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@xing-yang
Copy link
Contributor

xing-yang commented Apr 14, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note):
Provide ExecutionHook API design to trigger hook commands in the containers for different use cases, e.g., volume snapshot and application snapshot. 
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 14, 2019
@xing-yang
Copy link
Contributor Author

xing-yang commented Apr 14, 2019

/sig storage

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 14, 2019
@xing-yang
Copy link
Contributor Author

xing-yang commented Apr 14, 2019

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 14, 2019
@xing-yang
Copy link
Contributor Author

xing-yang commented Apr 14, 2019

/assign @xing-yang

@xing-yang
Copy link
Contributor Author

xing-yang commented Apr 14, 2019

/assign @jingxu97

@kacole2
Copy link
Member

kacole2 commented Apr 14, 2019

/milestone v1.15
/stage alpha

@k8s-ci-robot k8s-ci-robot added the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Apr 14, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 14, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels Apr 14, 2019
@craiglpeters
Copy link
Contributor

craiglpeters commented Apr 30, 2019

@jingxu97 and @xing-yang, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@xing-yang
Copy link
Contributor Author

xing-yang commented Apr 30, 2019

@craiglpeters We are trying to get the KEP merged by 4/30.

@christianh814
Copy link

christianh814 commented May 13, 2019

Hey @jingxu97 , @xing-yang I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@xing-yang
Copy link
Contributor Author

xing-yang commented May 13, 2019

@christianh814 Sure, I'll submit a placeholder PR soon. Thanks!

@xing-yang
Copy link
Contributor Author

xing-yang commented May 27, 2019

Hi @christianh814, a placeholder doc PR is submitted: kubernetes/website#14560

@mrbobbytables
Copy link
Member

mrbobbytables commented May 28, 2019

Hey there @xing-yang . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@xing-yang
Copy link
Contributor Author

xing-yang commented May 28, 2019

Hi @mrbobbytables The code for ExecutionHook will not be in-tree so it does not have to be merged by May 30th. Thanks!

@mrbobbytables
Copy link
Member

mrbobbytables commented May 28, 2019

@xing-yang Would you mind linking to the PRs even if its not in-tree? It may not need to be in by the 30th, but they're something that should be tracked for the Enhancement.

Thanks!

@xing-yang
Copy link
Contributor Author

xing-yang commented May 28, 2019

@mrbobbytables, right now the code is still in my private repo here: https://github.com/xing-yang/execution-hook. We need to create a new repo under kubernetes-sigs. We have not finalized on a repo name. I opened an issue to track this and we need to get the repo created as soon as possible: kubernetes-csi/external-snapshotter#125

@mrbobbytables
Copy link
Member

mrbobbytables commented May 28, 2019

Great, thank you for letting us know! :)

@xing-yang
Copy link
Contributor Author

xing-yang commented Jun 3, 2019

Since development work for ExecutionHook is out-of-tree, we don't need to create a doc in-tree. So I just closed kubernetes/website#14560.

@jeremyrickard
Copy link
Contributor

jeremyrickard commented Jan 30, 2020

Hey @xing-yang,

In order to make it back into the 1.18 release, you need to file an exception request TODAY. Friendly reminder: the instructions are here: https://github.com/kubernetes/sig-release/blob/master/releases/EXCEPTIONS.md

cc: @alejandrox1 @mrbobbytables @onlydole

@xing-yang
Copy link
Contributor Author

xing-yang commented Jan 30, 2020

Hi @jeremyrickard, there were some comments came up during the code review. It means we'll have to have a design discussion to decide which direction to go. So we won't add this back to 1.18. Thanks!

@onlydole
Copy link
Member

onlydole commented Jan 30, 2020

Thank you, @xing-yang!

@humblec
Copy link
Contributor

humblec commented Feb 11, 2020

@xing-yang Do we have a sync up call scheduled for driving this forward ? if yes, I would like to contribute to this through the same.

@xing-yang
Copy link
Contributor Author

xing-yang commented Feb 11, 2020

@humblec we don't have a call scheduled yet. I'm working on a proposal to address the review comments but it is not ready yet. Will keep you updated.

By the way, if you are interested in helping with moving the volume snapshot feature to GA, this ExecutionHook feature is not required for that.

@xing-yang
Copy link
Contributor Author

xing-yang commented Feb 12, 2020

@humblec and @ashish-amarnath, I added ExecutionHook to tomorrow's Data Protection WG agenda to discuss: https://docs.google.com/document/d/15tLCV3csvjHbKb16DVk-mfUmFry_Rlwo-2uG6KNGsfw/edit#

@humblec
Copy link
Contributor

humblec commented Feb 12, 2020

@humblec and @ashish-amarnath, I added ExecutionHook to tomorrow's Data Protection WG agenda to discuss: https://docs.google.com/document/d/15tLCV3csvjHbKb16DVk-mfUmFry_Rlwo-2uG6KNGsfw/edit#

Thanks @xing-yang ! will catch up on this.

@ashish-amarnath
Copy link

ashish-amarnath commented Feb 12, 2020

/assign ashish-amarnath

@palnabarun
Copy link
Member

palnabarun commented Apr 28, 2020

Hi @xing-yang @humblec @ashish-amarnath -- 1.19 Enhancements Lead here, I wanted to check in if you think this enhancement would graduate in 1.19?

In order to have this part of the release:

  1. The KEP PR must be merged in an implementable state
  2. The KEP must have test plans
  3. The KEP must have graduation criteria.

The current release schedule is:

  • Monday, April 13: Week 1 - Release cycle begins
  • Tuesday, May 19: Week 6 - Enhancements Freeze
  • Thursday, June 25: Week 11 - Code Freeze
  • Thursday, July 9: Week 14 - Docs must be completed and reviewed
  • Tuesday, August 4: Week 17 - Kubernetes v1.19.0 released

@xing-yang
Copy link
Contributor Author

xing-yang commented Apr 29, 2020

@palnabarun We actually need to do some re-design on this. So we won't track this for 1.19 yet. Thanks!

@palnabarun
Copy link
Member

palnabarun commented Apr 29, 2020

Thank you @xing-yang for the updates. I will update the tracking sheet accordingly. 👍

@fejta-bot
Copy link

fejta-bot commented Jul 28, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2020
@xing-yang
Copy link
Contributor Author

xing-yang commented Jul 28, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 28, 2020
@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Hi again @xing-yang 😄

Any plans for this in 1.20?

Thanks!
Kirsten

@xing-yang
Copy link
Contributor Author

xing-yang commented Sep 13, 2020

Hi @kikisdeliveryservice,

The plan is to go with a different approach as described here: #1977. If that goes through, we won't need this one any more.

Thanks!
Xing

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 13, 2020

Makes sense to me!

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 29, 2020

Just a ping that if you intend to use this one in 1.20, it would need test plans added by Enhancements Freeze October 6th.

Seems like 1977 is under heavy discussion though, but if you do end up wanting to move forward with this one, let me know.

@xing-yang
Copy link
Contributor Author

xing-yang commented Sep 30, 2020

Thanks @kikisdeliveryservice for the reminder! I did submit a PR for adding test plans a while ago but there's no plan for this in 1.20 so that PR won't be reviewed for now.

@kikisdeliveryservice
Copy link
Member

kikisdeliveryservice commented Sep 30, 2020

@xing-yang ahh good to know, just wanted to double check 😄

@fejta-bot
Copy link

fejta-bot commented Dec 29, 2020

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 29, 2020
@fejta-bot
Copy link

fejta-bot commented Jan 28, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 28, 2021
@fejta-bot
Copy link

fejta-bot commented Feb 27, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 27, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests