Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate ResourceQuotaScopeSelectors from beta to GA #986

Closed
ravisantoshgudimetla opened this issue Apr 23, 2019 · 28 comments
Closed

Graduate ResourceQuotaScopeSelectors from beta to GA #986

ravisantoshgudimetla opened this issue Apr 23, 2019 · 28 comments
Assignees
@draveness @ravisantoshgudimetla
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@ravisantoshgudimetla
Copy link
Contributor

ravisantoshgudimetla commented Apr 23, 2019 •
edited by kacole2

Enhancement Description

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

ResourceQuotaScopeSelectors allow critical pods to be created in any namespace that cluster-admin configured using quotas. While Priority & Preemption graduated to GA in 1.14, we still need to address the issue of not allowing critical pods in namespaces other than kube-system. So, we wish to address this by allowing ResourceQuotaScopeSelectors to GA.
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/feature Categorizes issue or PR as related to a new feature. labels Apr 23, 2019
@mrbobbytables
Copy link
Member

/milestone v1.15
/stage stable

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Apr 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 23, 2019
@mrbobbytables mrbobbytables added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 23, 2019
@justaugustus
Copy link
Member

/assign @ravisantoshgudimetla

@craiglpeters
Copy link
Contributor

@ravisantoshgudimetla, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes.

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Apr 29, 2019 •
edited

Thanks @craiglpeters - To be clear, what's an "implementable" state? some WIP PR?

@kacole2
Copy link
Member

kacole2 commented May 1, 2019

@ravisantoshgudimetla The current KEP listed above is not following the correct procedure. For any new enhancement or feature to Kubernetes a KEP must be filed, accepted, and merged by a particular SIG that will review it. I don't see the process has been followed here. Please review this at the root of this rep. https://github.com/kubernetes/enhancements

For now, this feature is going to be untracked and removed from the 1.15 milestone

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 1, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 1, 2019
@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented May 1, 2019 •
edited

@kacole2, here is the KEP created for it, I did not update this issue with KEP. Please let me know, if I need to do anything additional.

#987

@kacole2
Copy link
Member

kacole2 commented May 1, 2019 via email

@kacole2 kacole2 added tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team and removed tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team labels May 1, 2019
@kacole2
Copy link
Member

kacole2 commented May 1, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone May 1, 2019
@christianh814
Copy link

Hey @ravisantoshgudimetla I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@craiglpeters
Copy link
Contributor

Hi @ravisantoshgudimetla . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@ravisantoshgudimetla
Copy link
Contributor Author

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

I will get started on this.

Hi @ravisantoshgudimetla . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Except for docs PR, the main PR is in review(which I believe should be merged by Thursday). I will get started on a docs PR.

@makoscafee
Copy link
Member

HI @ravisantoshgudimetla docs PR does not have to be complete... The Today deadline needs to have a just a placeholder PR with title and description. Nothing fancy. This is mandatory before code freeze.

@craiglpeters
Copy link
Contributor

Hi @ravisantoshgudimetla, today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@ravisantoshgudimetla
Copy link
Contributor Author

@craiglpeters - I don't have enough reviewers atm to review the PR. Is there a way to file exception?

Here is the PR: kubernetes/kubernetes#76310. It's so close yet so far :).

@kacole2
Copy link
Member

kacole2 commented May 31, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 31, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels May 31, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

Hi @ravisantoshgudimetla , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@draveness
Copy link
Member

/assign

@draveness draveness mentioned this issue Sep 9, 2019
Closed
3 tasks
@annajung
Copy link
Member

annajung commented Oct 2, 2019

Hello @draveness @ravisantoshgudimetla , 1.17 Enhancement Shadow here! 🙂

I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

  • The current release schedule is

    • Monday, September 23 - Release Cycle Begins
    • Tuesday, October 15, EOD PST - Enhancements Freeze
    • Thursday, November 14, EOD PST - Code Freeze
    • Tuesday, November 19 - Docs must be completed and reviewed
    • Monday, December 9 - Kubernetes 1.17.0 Released

  • A Kubernetes Enhancement Proposal (KEP) must meet the following criteria before Enhancement Freeze to be accepted into the release

    • PR is merged in
    • In an implementable state
    • Include test plan and graduation criteria

  • All relevant k/k PRs should be listed in this issue

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2019
@draveness
Copy link
Member

This feature has already graduated to GA, and we could close this now.

/close

@k8s-ci-robot
Copy link
Contributor

@draveness: Closing this issue.

In response to this:

This feature has already graduated to GA, and we could close this now.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

Hi @draveness, since this enhancement already graduated to Stable, can you please also mark the KEP as implemented?

@palnabarun
Copy link
Member

/reopen
(reopening in the interim till the KEP in marked implemented)

@k8s-ci-robot k8s-ci-robot reopened this Apr 17, 2020
@k8s-ci-robot
Copy link
Contributor

@palnabarun: Reopened this issue.

In response to this:

/reopen
(reopening in the interim till the KEP in marked implemented)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness draveness mentioned this issue Apr 18, 2020
Merged
@draveness
Copy link
Member

/reopen
(reopening in the interim till the KEP in marked implemented)

Thanks for the reminder, I've opened a PR to updates the KEP.

@draveness
Copy link
Member

/close
since #1700 has been merged

@k8s-ci-robot
Copy link
Contributor

@draveness: Closing this issue.

In response to this:

/close
since #1700 has been merged

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@palnabarun
Copy link
Member

@draveness -- Thank you for updating the KEP. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@draveness draveness

@ravisantoshgudimetla ravisantoshgudimetla

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests