-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate ResourceQuotaScopeSelectors from beta to GA #986
Comments
/milestone v1.15 |
/assign @ravisantoshgudimetla |
@ravisantoshgudimetla, Kubernetes 1.15 Enhancement Freeze is 4/30/2019. To be included in the Kubernetes 1.15 milestone, KEPs are required to be merged and in an "Implementable" state with proper test plans and graduation criteria. Please submit any PRs needed to make this KEP adhere to inclusion criteria. If this will slip from the 1.15 milestone, please let us know so we can make appropriate tracking changes. |
Thanks @craiglpeters - To be clear, what's an "implementable" state? some WIP PR? |
@ravisantoshgudimetla The current KEP listed above is not following the correct procedure. For any new enhancement or feature to Kubernetes a KEP must be filed, accepted, and merged by a particular SIG that will review it. I don't see the process has been followed here. Please review this at the root of this rep. https://github.com/kubernetes/enhancements For now, this feature is going to be untracked and removed from the 1.15 milestone /milestone clear |
Ill get this re-added in the morning. Only thing missing from the KEP is
testing plans. Thank you.
On Tue, Apr 30, 2019 at 11:06 PM RaviSantosh Gudimetla < ***@***.***> wrote:
Ohh @kacole2 <https://github.com/kacole2>, here is the KEP created for
it, I did not update this issue with KEP:
#987 <#987>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#986 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABCGKUSEGRTX5SG6WGUTXNDPTECL7ANCNFSM4HH5SJHA>
.
--
Kendrick Coleman
kendrickcoleman.com
@KendrickColeman
github.com/kacole2
|
/milestone v1.15 |
Hey @ravisantoshgudimetla I'm the v1.15 docs shadow. Does this enhancement require any new docs (or modifications)? Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! |
Hi @ravisantoshgudimetla . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open. Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone. If you know this will slip, please reply back and let us know. Thanks! |
I will get started on this.
Except for docs PR, the main PR is in review(which I believe should be merged by Thursday). I will get started on a docs PR. |
HI @ravisantoshgudimetla docs PR does not have to be complete... The Today deadline needs to have a just a placeholder PR with title and description. Nothing fancy. This is mandatory before code freeze. |
Hi @ravisantoshgudimetla, today is code freeze for the 1.15 release cycle. I do not see a reply for any k/k PRs to track for this merge. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. If there is no response, or you respond with PRs to track and they are not merged by EOD PST, this will be dropped from the 1.15 Milestone. After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception. |
@craiglpeters - I don't have enough reviewers atm to review the PR. Is there a way to file exception? Here is the PR: kubernetes/kubernetes#76310. It's so close yet so far :). |
/milestone clear |
Hi @ravisantoshgudimetla , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label. Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly. Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29. Thank you. |
/assign |
Hello @draveness @ravisantoshgudimetla , 1.17 Enhancement Shadow here! 🙂 I wanted to reach out to see if this enhancement will be graduating to alpha/beta/stable in 1.17?
Thank you! 🔔Friendly Reminder
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
This feature has already graduated to GA, and we could close this now. /close |
@draveness: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @draveness, since this enhancement already graduated to Stable, can you please also mark the KEP as |
/reopen |
@palnabarun: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the reminder, I've opened a PR to updates the KEP. |
/close |
@draveness: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@draveness -- Thank you for updating the KEP. 🙂 |
Enhancement Description
One-line enhancement description (can be used as a release note):
Graduate ResourceQuotaScopeSelectors from beta to GA
Kubernetes Enhancement Proposal PR: Promote resourcequotascopeselector to GA #987
Kubernetes Enhancement Proposal: 20190409-resource-quota-ga
Primary contact (assignee): @ravisantoshgudimetla
Responsible SIGs: @kubernetes/sig-scheduling-feature-requests @bsalamat @derekwaynecarr @sjenning
Enhancement target (which target equals to which milestone):
Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement
ResourceQuotaScopeSelectors allow critical pods to be created in any namespace that cluster-admin configured using quotas. While Priority & Preemption graduated to GA in 1.14, we still need to address the issue of not allowing critical pods in namespaces other than
kube-system
. So, we wish to address this by allowing ResourceQuotaScopeSelectors to GA.The text was updated successfully, but these errors were encountered: