-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support generators and transformers plugins in kubectl kustomize
and kubectl -k
#993
Comments
/sig cli |
/kind feature |
/milestone v1.15 |
/assign @Liujingfang1 @monopole |
@Liujingfang1 and @monopole we're doing a KEP review for enhancements to be included in the Kubernetes v1.15 milestone. After reviewing your KEP, it's currently missing test plan and graduation criteria which are required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019. |
@mrbobbytables I updated it to Alpha release in 1.15. |
Thanks! |
opened a PR for adding test plan and graduation criteria #1023 |
Hey @monopole @Liujingfang1 I'm the v1.15 docs shadow. Does this enhancement require any new docs (or modifications)? Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions! |
Hi @Liujingfang1 . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open. Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone. If you know this will slip, please reply back and let us know. Thanks! |
We will postpone this to v1.16. |
/milestone clear |
Hi @Liujingfang1 @monopole , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label. Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly. Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29. Thank you. |
@kacole2 Thank you for checking with me. Since currently kubectl is moving into staging and will be eventually moved out of core. We don't plan to make this process more complicated by integrating new kustomize version into it. We will postpone this feature. |
Hello @Liujingfang1 -- 1.17 Enhancement Shadow here! 🙂 I see your comment above regarding postponing the feature, however I wanted to reach out to see if your plans have changed, and if this enhancement will be graduating to alpha/beta/stable in 1.17?
Thank you! 🔔Friendly Reminder The current release schedule is
|
Hi @monopole @Liujingfang1! Excited to hear this enhancement is planned for beta in 1.20. Wanted to check in on a few things as the Enhancements Freeze is coming up next Tuesday, 10/6.
Feel free to reach out with any comments or questions! Thanks, |
Hi @monopole @Liujingfang1 - a quick reminder that the Enhancements Freeze is tomorrow, 10/6. The Risk and Mitigations section is considered a required section, therefore this should be completed. Also pertaining to the comment above, please add clarity to the test plan or provide an explanation as to why this is sufficient. These changes need to be merged by EOD tomorrow in order for this KEP to be considered in release 1.20. Please reach out should you have any questions! Thanks, Kendall Roden |
This was temporarily destaffed so won't make it into 1.20. We did have a meeting about it last Thursday, are re-staffing it and now the target is 1.21 Thanks Kendall! Please just close this. |
@monopole Thanks for the update! Just to confirm, we will keep the issue open but mark it as untracked for the 1.20 release and will have the enhancement team check back in during the 1.21 release :) @kikisdeliveryservice has removed the tracking label for 1.20! |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-contributor-experience at kubernetes/community. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
@ehashman: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Did this land in 1.21? kubernetes/kubernetes#98946 |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-contributor-experience at kubernetes/community. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enhancement Description
One-line enhancement description (can be used as a release note):
support generators and transformers plugins through plugins in
kubectl kustomize
andkubectl -k
Kubernetes Enhancement Proposal: (link to kubernetes/enhancements file, if none yet, link to PR) https://github.com/kubernetes/enhancements/blob/master/keps/sig-cli/20190318-kustomize-generators-transformers.md
Primary contact (assignee):
Liujingfang1, monopole
Responsible SIGs:
/sig-cli
Enhancement target (which target equals to which milestone): 1.15
This is to revendor Kustomize into kubectl with generator and transformer plugin support.
Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement
The text was updated successfully, but these errors were encountered: