Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support generators and transformers plugins in `kubectl kustomize` and `kubectl -k` #993

Open
Liujingfang1 opened this issue Apr 24, 2019 · 15 comments

Comments

@Liujingfang1
Copy link
Contributor

@Liujingfang1 Liujingfang1 commented Apr 24, 2019

Enhancement Description

This is to revendor Kustomize into kubectl with generator and transformer plugin support.

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

@Liujingfang1 Liujingfang1 commented Apr 24, 2019

/sig cli

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

@Liujingfang1 Liujingfang1 commented Apr 24, 2019

/kind feature

@mrbobbytables

This comment has been minimized.

Copy link
Member

@mrbobbytables mrbobbytables commented Apr 24, 2019

/milestone v1.15
/stage stable

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 24, 2019
@justaugustus

This comment has been minimized.

Copy link
Member

@justaugustus justaugustus commented Apr 28, 2019

@craiglpeters

This comment has been minimized.

Copy link
Contributor

@craiglpeters craiglpeters commented Apr 29, 2019

@Liujingfang1 and @monopole we're doing a KEP review for enhancements to be included in the Kubernetes v1.15 milestone. After reviewing your KEP, it's currently missing test plan and graduation criteria which are required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019.

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

@Liujingfang1 Liujingfang1 commented Apr 30, 2019

@mrbobbytables I updated it to Alpha release in 1.15.

@mrbobbytables

This comment has been minimized.

Copy link
Member

@mrbobbytables mrbobbytables commented Apr 30, 2019

Thanks!
/remove-stage stable
/stage alpha

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

@Liujingfang1 Liujingfang1 commented Apr 30, 2019

opened a PR for adding test plan and graduation criteria #1023

@christianh814

This comment has been minimized.

Copy link

@christianh814 christianh814 commented May 13, 2019

Hey @monopole @Liujingfang1 I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@craiglpeters

This comment has been minimized.

Copy link
Contributor

@craiglpeters craiglpeters commented May 29, 2019

Hi @Liujingfang1 . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

@Liujingfang1 Liujingfang1 commented May 29, 2019

We will postpone this to v1.16.

@kacole2

This comment has been minimized.

Copy link
Member

@kacole2 kacole2 commented Jun 3, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone Jun 3, 2019
@kacole2 kacole2 added tracked/no and removed tracked/yes labels Jun 3, 2019
@kacole2

This comment has been minimized.

Copy link
Member

@kacole2 kacole2 commented Jul 9, 2019

Hi @Liujingfang1 @monopole , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@Liujingfang1

This comment has been minimized.

Copy link
Contributor Author

@Liujingfang1 Liujingfang1 commented Jul 9, 2019

@kacole2 Thank you for checking with me. Since currently kubectl is moving into staging and will be eventually moved out of core. We don't plan to make this process more complicated by integrating new kustomize version into it. We will postpone this feature.

@kcmartin

This comment has been minimized.

Copy link

@kcmartin kcmartin commented Oct 2, 2019

Hello @Liujingfang1 -- 1.17 Enhancement Shadow here! 🙂

I see your comment above regarding postponing the feature, however I wanted to reach out to see if your plans have changed, and if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.