Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support generators and transformers plugins in kubectl kustomize and kubectl -k #993

Closed
Liujingfang1 opened this issue Apr 24, 2019 · 47 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team

Comments

@Liujingfang1
Copy link
Contributor

Liujingfang1 commented Apr 24, 2019

Enhancement Description

This is to revendor Kustomize into kubectl with generator and transformer plugin support.

Please to keep this description up to date. This will help the Enhancement Team track efficiently the evolution of the enhancement

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 24, 2019
@Liujingfang1
Copy link
Contributor Author

Liujingfang1 commented Apr 24, 2019

/sig cli

@Liujingfang1
Copy link
Contributor Author

Liujingfang1 commented Apr 24, 2019

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 24, 2019
@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 24, 2019

/milestone v1.15
/stage stable

@k8s-ci-robot k8s-ci-robot added the stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status label Apr 24, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Apr 24, 2019
@mrbobbytables mrbobbytables added the tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team label Apr 24, 2019
@justaugustus
Copy link
Member

justaugustus commented Apr 28, 2019

/assign @Liujingfang1 @monopole

@craiglpeters
Copy link
Contributor

craiglpeters commented Apr 29, 2019

@Liujingfang1 and @monopole we're doing a KEP review for enhancements to be included in the Kubernetes v1.15 milestone. After reviewing your KEP, it's currently missing test plan and graduation criteria which are required information per the KEP Template. Please update the KEP to include the required information before the Kubernetes 1.15 Enhancement Freeze date of 4/30/2019.

@Liujingfang1
Copy link
Contributor Author

Liujingfang1 commented Apr 30, 2019

@mrbobbytables I updated it to Alpha release in 1.15.

@mrbobbytables
Copy link
Member

mrbobbytables commented Apr 30, 2019

Thanks!
/remove-stage stable
/stage alpha

@k8s-ci-robot k8s-ci-robot added stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status and removed stage/stable Denotes an issue tracking an enhancement targeted for Stable/GA status labels Apr 30, 2019
@Liujingfang1
Copy link
Contributor Author

Liujingfang1 commented Apr 30, 2019

opened a PR for adding test plan and graduation criteria #1023

@christianh814
Copy link

christianh814 commented May 13, 2019

Hey @monopole @Liujingfang1 I'm the v1.15 docs shadow.

Does this enhancement require any new docs (or modifications)?

Just a friendly reminder we're looking for a PR against k/website (branch dev-1.15) due by Friday, May 31st. It would be great if it's the start of the full documentation, but even a placeholder PR is acceptable. Let me know if you have any questions!

@craiglpeters
Copy link
Contributor

craiglpeters commented May 29, 2019

Hi @Liujingfang1 . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@Liujingfang1
Copy link
Contributor Author

Liujingfang1 commented May 29, 2019

We will postpone this to v1.16.

@kacole2
Copy link
Member

kacole2 commented Jun 3, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone Jun 3, 2019
@kacole2 kacole2 added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Jun 3, 2019
@kacole2
Copy link
Member

kacole2 commented Jul 9, 2019

Hi @Liujingfang1 @monopole , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@Liujingfang1
Copy link
Contributor Author

Liujingfang1 commented Jul 9, 2019

@kacole2 Thank you for checking with me. Since currently kubectl is moving into staging and will be eventually moved out of core. We don't plan to make this process more complicated by integrating new kustomize version into it. We will postpone this feature.

@kcmartin
Copy link

kcmartin commented Oct 2, 2019

Hello @Liujingfang1 -- 1.17 Enhancement Shadow here! 🙂

I see your comment above regarding postponing the feature, however I wanted to reach out to see if your plans have changed, and if this enhancement will be graduating to alpha/beta/stable in 1.17?


Please let me know so that this enhancement can be added to 1.17 tracking sheet.

Thank you!

🔔Friendly Reminder

The current release schedule is

  • Monday, September 23 - Release Cycle Begins
  • Tuesday, October 15, EOD PST - Enhancements Freeze
  • Thursday, November 14, EOD PST - Code Freeze
  • Tuesday, November 19 - Docs must be completed and reviewed
  • Monday, December 9 - Kubernetes 1.17.0 Released

@kikisdeliveryservice kikisdeliveryservice removed the stage/alpha Denotes an issue tracking an enhancement targeted for Alpha status label Sep 16, 2020
@kendallroden
Copy link
Contributor

kendallroden commented Sep 28, 2020

Hi @monopole @Liujingfang1! Excited to hear this enhancement is planned for beta in 1.20. Wanted to check in on a few things as the Enhancements Freeze is coming up next Tuesday, 10/6.

  1. It appears that there is a test plan, however it is lacking detail. Is there anything that can be added to provide clarity around the required integration tests?
  2. There is nothing under the "Risks and Mitigations" section which should be completed
  3. This KEP is currently using the retired KEP template, if possible please update to use the new template before 10/6

Feel free to reach out with any comments or questions!

Thanks,
Kendall (1.20 Enhancements Team)

@kendallroden
Copy link
Contributor

kendallroden commented Oct 5, 2020

Hi @monopole @Liujingfang1 - a quick reminder that the Enhancements Freeze is tomorrow, 10/6. The Risk and Mitigations section is considered a required section, therefore this should be completed. Also pertaining to the comment above, please add clarity to the test plan or provide an explanation as to why this is sufficient. These changes need to be merged by EOD tomorrow in order for this KEP to be considered in release 1.20. Please reach out should you have any questions!

Thanks,

Kendall Roden
Enhancements Team 1.20

@monopole
Copy link
Contributor

monopole commented Oct 5, 2020

This was temporarily destaffed so won't make it into 1.20.

We did have a meeting about it last Thursday, are re-staffing it and now the target is 1.21

Thanks Kendall! Please just close this.

@kikisdeliveryservice kikisdeliveryservice removed this from the v1.20 milestone Oct 5, 2020
@kikisdeliveryservice kikisdeliveryservice added tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team and removed tracked/yes Denotes an enhancement issue is actively being tracked by the Release Team labels Oct 5, 2020
@kendallroden
Copy link
Contributor

kendallroden commented Oct 5, 2020

@monopole Thanks for the update! Just to confirm, we will keep the issue open but mark it as untracked for the 1.20 release and will have the enhancement team check back in during the 1.21 release :) @kikisdeliveryservice has removed the tracking label for 1.20!

@fejta-bot
Copy link

fejta-bot commented Jan 4, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@fejta-bot
Copy link

fejta-bot commented Feb 3, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 3, 2021
@fejta-bot
Copy link

fejta-bot commented Mar 5, 2021

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 5, 2021

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ehashman
Copy link
Member

ehashman commented May 5, 2021

/remove-lifecycle rotten
/reopen

@k8s-ci-robot k8s-ci-robot reopened this May 5, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 5, 2021

@ehashman: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 5, 2021
@ehashman
Copy link
Member

ehashman commented May 5, 2021

Did this land in 1.21? kubernetes/kubernetes#98946

@k8s-triage-robot
Copy link

k8s-triage-robot commented Aug 3, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 3, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Sep 2, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 2, 2021
@k8s-triage-robot
Copy link

k8s-triage-robot commented Oct 2, 2021

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 2, 2021

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI. stage/beta Denotes an issue tracking an enhancement targeted for Beta status tracked/no Denotes an enhancement issue is NOT actively being tracked by the Release Team
Projects
None yet
Development

No branches or pull requests