Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeadm for Windows #995

Open
ksubrmnn opened this issue Apr 24, 2019 · 22 comments

Comments

@ksubrmnn
Copy link
Contributor

commented Apr 24, 2019

Enhancement Description

  • One-line enhancement description (can be used as a release note): Kubeadm support for Windows
  • Kubernetes Enhancement Proposal PR: #994
  • Kubernetes Enhancement Proposal: 20190424-kubeadm-for-windows
  • Primary contact (assignee): @ksubrmnn
  • Responsible SIGs:
    /sig-windows
    /sig-cluster-lifecycle
  • Enhancement target (which target equals to which milestone):
    • Alpha release target (1.16)
    • Beta release target: TODO
    • GA release target: TODO
@neolit123

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

/sig windows
/sig cluster-lifecycle

@craiglpeters

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@ksubrmnn, Enhancement Freeze for Kubernetes 1.15 has passed and this did not meet the deadline. This is now being removed from the 1.15 milestone and the tracking sheet. If there is a need for this to be in 1.15, please file an Enhancement Exception. Thank you.

@craiglpeters

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone May 1, 2019

@michmike michmike added this to Backlog (v.1.15) in SIG-Windows May 3, 2019

@kacole2 kacole2 added tracked/yes and removed tracked/no labels May 6, 2019

@kacole2 kacole2 added this to the v1.15 milestone May 6, 2019

@craiglpeters

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Hi @ksubrmnn . Code Freeze is Thursday, May 30th 2019 @ EOD PST. All enhancements going into the release must be code-complete, including tests, and have docs PRs open.

Please list all current k/k PRs so they can be tracked going into freeze. If the PRs aren't merged by freeze, this feature will slip for the 1.15 release cycle. Only release-blocking issues and PRs will be allowed in the milestone.

If you know this will slip, please reply back and let us know. Thanks!

@michmike

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@craiglpeters according to the KEP for kubeadm for 1.15, we were not going to add any more tests beyond unit tests. are we good on this area? thanks!
cc: @ksubrmnn

@makoscafee

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Hey, @michmike @ksubrmnn 👋 I'm the v1.15 docs Lead.
Does this enhancement require any new docs (or modifications)?

Sorry for getting to you late, Code Freeze is Thursday, May 30th 2019 @ EOD PST It would be great to have a placeholder PR by then can be just empty PR with title and description. Let me know if you have any questions!

@PatrickLang PatrickLang moved this from Backlog (v.1.15) to In Progress+Review in SIG-Windows May 30, 2019

@craiglpeters

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@michmike and @ksubrmnn yes agreed that unit tests are good for alpha. I still need to know which k/k PRs to track for this issue. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. Is there high confidence these will be merged by EOD PST today? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@ksubrmnn

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

@craiglpeters See kubernetes/kubeadm#1393

We are still on track for alpha. I will fix up kubernetes/kubernetes#78324 and it will get merged today.

@ksubrmnn

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

Docs PR open: kubernetes/website#14644

@michmike

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@craiglpeters we will continue working on this. if we can get an exception, it will make it into 1.15 and if not it will come later. the code changes are good, but there is still lots of documentation work left.

@PatrickLang

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@craiglpeters

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Hi @ksubrmnn, tomorrow is code freeze (one day delay) for the 1.15 release cycle. The k/k PRs have not yet been merged. It's now being marked as At Risk in the 1.15 Enhancement Tracking Sheet. Is there high confidence these will be merged by EOD PST tomorrow? After this point, only release-blocking issues and PRs will be allowed in the milestone with an exception.

@kacole2

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

/milestone clear

@k8s-ci-robot k8s-ci-robot removed this from the v1.15 milestone Jun 11, 2019

@kacole2 kacole2 added tracked/no and removed tracked/yes labels Jun 11, 2019

@kacole2

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Hi @PatrickLang @michmike , I'm the 1.16 Enhancement Lead. Is this feature going to be graduating alpha/beta/stable stages in 1.16? Please let me know so it can be added to the 1.16 Tracking Spreadsheet. If not's graduating, I will remove it from the milestone and change the tracked label.

Once coding begins or if it already has, please list all relevant k/k PRs in this issue so they can be tracked properly.

Milestone dates are Enhancement Freeze 7/30 and Code Freeze 8/29.

Thank you.

@michmike

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

hi @kacole2 , yes this is tracked for an alpha release with 1.16. thanks!

@michmike

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

@ksubrmnn can link the PRs when we have them (likely will create some this week). the KEP is already approved for this work

@kacole2 kacole2 added this to the v1.16 milestone Jul 9, 2019

@kacole2 kacole2 added tracked/yes and removed tracked/no labels Jul 9, 2019

@sethmccombs

This comment has been minimized.

Copy link

commented Aug 4, 2019

Hey @ksubrmnn @michmike

I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)

If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

@ksubrmnn

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2019

Hey @ksubrmnn @michmike
I'm one of the v1.16 docs shadows.
Does this enhancement (or the work planned for v1.16) require any new docs (or modifications to existing docs)? If not, can you please update the 1.16 Enhancement Tracker Sheet (or let me know and I’ll do so)
If so, just a friendly reminder we're looking for a PR against k/website (branch dev-1.16) due by Friday, August 23rd, it can just be a placeholder PR at this time. Let me know if you have any questions!

@daschott

@daschott

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@sethmccombs we would like to modify the page on how to join Windows nodes in the Windows user guide but the exact content of that page have yet to be confirmed 100%. Is it OK if we raise a placeholder PR for now?

EDIT: Updated URL. We may also want to add a very short page titled something along the lines of "Joining Windows nodes" to the kubeadm section containing a pointer to the instructions in the Windows user guide.

@daschott

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

@sethmccombs I raised kubernetes/website#15750 as a placeholder PR for the doc updates.

@kacole2

This comment has been minimized.

Copy link
Member

commented Aug 26, 2019

@daschott @michmike @PatrickLang @neolit123 code freeze for 1.16 is on Thursday 8/29. It looks like everything on kubernetes/kubeadm#1393 has been merged. So if this is on track we are good to go! If there are any other outstanding k/k PRs please update the issue.

@michmike

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

hi @kacole2 , we are on track for 1.16. thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.