KEP 1693: Warning mechanism for use of deprecated APIs #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/L
liggitt
force-pushed
the
warnings
branch
3 times, most recently
from
93197c7
to
3d64a7b
Compare
liggitt
changed the title
k8s-ci-robot
added
sig/instrumentation
liggitt
force-pushed
the
warnings
branch
3 times, most recently
from
43a3e89
to
af5bf39
Compare
liggitt
changed the title
logicalhan
reviewed
Apr 16, 2020
logicalhan
reviewed
Apr 16, 2020
|
/lgtm for the metrics stuff as discussed offline |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm (restamp) from sig-instrumentation |
k8s-ci-robot
added
the
lgtm
|
Looks good to me, thanks! |
lavalamp
reviewed
Apr 16, 2020
| 2. log to stderr with a `Warning:` prefix | ||
| 3. color the `Warning:` prefix if stderr is a terminal and `$TERM != "dumb"` and `$NO_COLOR` is unset | ||
|
|
||
| In kube-apiserver and kube-controller-manager, configure the process-wide handler to ignore warnings |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lavalamp, liggitt, logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Will keep provisional until all reviewers get a shot at this, then get acks from approvers before flipping to implementable. I also added it to agendas for the upcoming SIG meetings to field any questions. |
Merged
6 tasks
|
Review continued in #1697, fixed a couple typos and added whitespace bits to allow adding comments to any lines |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposes a mechanism for surfacing use of deprecated APIs to users via
Warningheaders, and to administrators via metrics/audit events.Proof-of-concept at kubernetes/kubernetes#73032
/sig api-machinery architecture cli instrumentation