KEP-2133: kubelet credential provider plugins#2151
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Jan 8, 2021
Merged
KEP-2133: kubelet credential provider plugins#2151k8s-ci-robot merged 1 commit intokubernetes:masterfrom
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
andrewsykim
force-pushed
the
kubelet-credential-provider
branch
2 times, most recently
from
163b349 to
17cee38
Compare
Member
Author
|
/assign @cheftako @liggitt @derekwaynecarr |
andrewsykim
force-pushed
the
kubelet-credential-provider
branch
from
17cee38 to
45c67ca
Compare
4 tasks
Member
|
Thanks for updating this as requested for your 1.20 Exception Request! |
liggitt
reviewed
Nov 13, 2020
Member
liggitt
left a comment
liggitt
left a comment
There was a problem hiding this comment.
A few nits, looks good overall for alpha.
| creation-date: 2019-10-04 | ||
| last-updated: 2019-12-10 | ||
| status: implementable | ||
| status: replaced |
|
|
||
| ### Upgrade / Downgrade Strategy | ||
|
|
||
| This feature is feature gated so explicit opt-in is required on upgrade and explcit opt-out is required on downgrade. |
Member
There was a problem hiding this comment.
Suggested change
| This feature is feature gated so explicit opt-in is required on upgrade and explcit opt-out is required on downgrade. | |
| This feature is feature gated so explicit opt-in is required on upgrade and explicit opt-out is required on downgrade. |
Comment on lines
+451
to
+452
| Yes, but not from kubelet directly. The plugin invoked by the kubelet may be responsible | ||
| for making new requests to the cloud provider. |
Member
There was a problem hiding this comment.
I would say no here. The feature does not make calls to a cloud provider, and different plugin implementations may or may not.
|
|
||
| * **How does this feature react if the API server and/or etcd is unavailable?** | ||
|
|
||
| TBD for beta. |
Member
There was a problem hiding this comment.
this feature has no dependencies on the API server or etcd
Comment on lines
+46
to
+48
| # The following PRR answers are required at beta release | ||
| metrics: | ||
| - my_feature_metric |
Comment on lines
+43
to
+44
| - [ ] (R) Test plan is in place, giving consideration to SIG Architecture and SIG Testing input | ||
| - [ ] (R) Graduation criteria is in place |
k8s-ci-robot
added
the
needs-rebase
andrewsykim
force-pushed
the
kubelet-credential-provider
branch
from
45c67ca to
c0bd3fd
Compare
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: Andrew Sy Kim <kim.andrewsy@gmail.com>
andrewsykim
force-pushed
the
kubelet-credential-provider
branch
from
c0bd3fd to
e882a17
Compare
Member
|
looks good for sig-node and captures present state. /lgtm |
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, derekwaynecarr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
|
||
| * in contrast to existing built-in implementations, credentials for a image registry is now passed | ||
| through stdio of a process invoked by the kubelet, as opposed to those credentials only remaining in-memory. | ||
| * exec-ing plugins for image credentials can be expensive for the kubelet. |
Contributor
There was a problem hiding this comment.
Might this be an appropriate place to mention the strategy that the current implementation takes of timing out plugins after 1 minute to prevent plugin processes from becoming too long-lived? LGTM otherwise, I think.
Member
Author
There was a problem hiding this comment.
Good catch! Will make sure to include that for the v1.21 beta update of this KEP :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Sy Kim kim.andrewsy@gmail.com