KEP-2831: Instrumenting Kubelet for OpenTelemetry Tracing by sallyom · Pull Request #2832 · kubernetes/enhancements

sallyom · 2021-07-21T03:32:00Z

One-line PR description: Instrument kubelet to generate and export OpenTelemetry trace data.

Issue link: Kubelet OpenTelemetry Tracing #2831

dashpole · 2021-08-10T16:36:11Z

@sallyom let me know when comments are addressed and you are ready for another round of review

ehashman · 2021-09-08T17:51:58Z

/sig node

ehashman

Did a quick pass, I don't think this will make it in time for 1.23.

sallyom · 2021-09-09T15:47:22Z

@ehashman @dashpole thanks for your reviews. bummer, this won't make 1.23 but i'll keep on this to push for merge and kubelet changes with 1.24

dashpole

First pass

sallyom · 2021-10-10T01:16:20Z

@dashpole @ehashman ptal, thanks

dashpole

/approve
This looks great. We should make sure we get feedback from sig-node members as well.

sallyom · 2022-01-20T15:30:10Z

@ehashman ptal at the prod-readiness review for 1.24 freeze, thanks again :)

ehashman

PRR is nearly done, just a couple of small questions. Need node and @dashpole review as well :)

ehashman

/approve

for PRR. Leaving final LGTM to @dashpole

ehashman · 2022-01-26T19:35:26Z

+owning-sig: sig-instrumentation
+participating-sigs:
+  - sig-architecture
+  - sig-node


SIG Node acked the KEP at the 2022-01-25 meeting.

dashpole · 2022-01-26T20:12:09Z

Once the comment about passthrough for trace context above is resolved, i'll lgtm

ddebroy

Will be great if we can call out support for tracing volume attach+mount related operations between Kubelet and the in-tree volume plugins + CSI node plugins.

Would also love to know if tracing from the perspective of individual PVs/Volumes across Kubelet/Attach-Detach controller and PV controller exists or is called out somewhere.

derekwaynecarr

the kep generally lgtm for sig-node.

defer to @dashpole for final review who has good understanding of kubelet as well.

k8s-ci-robot · 2022-02-02T22:21:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dashpole, derekwaynecarr, ehashman, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~keps/prod-readiness/OWNERS~~ [ehashman]
~~keps/sig-instrumentation/OWNERS~~ [dashpole,derekwaynecarr,ehashman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Sally O'Malley <somalley@redhat.com> Co-authored-by: husky-parul <parsingh@redhat.com>

Co-authored-by: David Ashpole <dashpole@google.com>

dashpole · 2022-02-03T17:32:27Z

/lgtm

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2021

k8s-ci-robot requested review from ehashman and logicalhan July 21, 2021 03:32

k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2021

sallyom force-pushed the tracing-kubelet-kep branch from ed71587 to 7142e9a Compare July 21, 2021 03:44

sallyom mentioned this pull request Jul 21, 2021

Kubelet OpenTelemetry Tracing #2831

Closed

12 tasks

sallyom force-pushed the tracing-kubelet-kep branch from 7142e9a to 1bf3d00 Compare July 21, 2021 15:38

logicalhan reviewed Jul 21, 2021

View reviewed changes

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md Outdated

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md Outdated

sallyom force-pushed the tracing-kubelet-kep branch from 1bf3d00 to ccfca15 Compare July 21, 2021 19:23

dashpole reviewed Jul 28, 2021

View reviewed changes

sallyom force-pushed the tracing-kubelet-kep branch 3 times, most recently from 6013bf0 to ed06666 Compare August 5, 2021 03:00

sallyom force-pushed the tracing-kubelet-kep branch from ed06666 to c6f127e Compare August 5, 2021 19:10

sallyom force-pushed the tracing-kubelet-kep branch from c6f127e to 6d03584 Compare August 16, 2021 17:09

sallyom force-pushed the tracing-kubelet-kep branch from 6d03584 to 44e50f9 Compare September 8, 2021 16:38

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Sep 8, 2021

ehashman reviewed Sep 8, 2021

View reviewed changes

sallyom force-pushed the tracing-kubelet-kep branch from 44e50f9 to c165872 Compare September 9, 2021 15:44

sallyom force-pushed the tracing-kubelet-kep branch from c165872 to 5885e52 Compare September 9, 2021 15:48

dashpole reviewed Sep 9, 2021

View reviewed changes

sallyom force-pushed the tracing-kubelet-kep branch from 5885e52 to bca704f Compare September 10, 2021 16:54

sallyom force-pushed the tracing-kubelet-kep branch from bca704f to f71b8d4 Compare October 10, 2021 01:03

dashpole approved these changes Jan 6, 2022

View reviewed changes

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md Outdated

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/kep.yaml Outdated

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/kep.yaml Outdated

sallyom force-pushed the tracing-kubelet-kep branch from 8eee33b to 868a441 Compare January 20, 2022 15:29

sallyom force-pushed the tracing-kubelet-kep branch from 868a441 to f61a344 Compare January 20, 2022 16:32

ehashman reviewed Jan 20, 2022

View reviewed changes

dashpole reviewed Jan 20, 2022

View reviewed changes

sallyom force-pushed the tracing-kubelet-kep branch from f61a344 to 5cca408 Compare January 25, 2022 18:03

ehashman reviewed Jan 26, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2022

ehashman reviewed Jan 26, 2022

View reviewed changes

ddebroy reviewed Feb 1, 2022

View reviewed changes

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md Outdated

ddebroy reviewed Feb 1, 2022

View reviewed changes

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md

sallyom force-pushed the tracing-kubelet-kep branch 2 times, most recently from 51938bc to 63f8691 Compare February 1, 2022 21:47

ddebroy reviewed Feb 2, 2022

View reviewed changes

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md

dashpole reviewed Feb 2, 2022

View reviewed changes

derekwaynecarr approved these changes Feb 2, 2022

View reviewed changes

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md Outdated

sallyom force-pushed the tracing-kubelet-kep branch from 63f8691 to b465d40 Compare February 3, 2022 00:33

kubelet tracing

34e9f59

Signed-off-by: Sally O'Malley <somalley@redhat.com> Co-authored-by: husky-parul <parsingh@redhat.com>

sallyom force-pushed the tracing-kubelet-kep branch from b465d40 to 34e9f59 Compare February 3, 2022 00:41

dashpole reviewed Feb 3, 2022

View reviewed changes

Comment thread keps/sig-instrumentation/2831-kubelet-tracing/README.md Outdated

Update keps/sig-instrumentation/2831-kubelet-tracing/README.md

2ef3e9a

Co-authored-by: David Ashpole <dashpole@google.com>

k8s-ci-robot assigned dashpole Feb 3, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2022

k8s-ci-robot merged commit 7e55759 into kubernetes:master Feb 3, 2022

k8s-ci-robot added this to the v1.24 milestone Feb 3, 2022

sallyom mentioned this pull request Jul 18, 2022

Add docs for KubeletTracing feature gate 1.25 kubernetes/website#35137

Merged

swagatbora90 mentioned this pull request Sep 23, 2022

Support otel tracing in cri remote image service kubernetes/kubernetes#112709

Merged

Conversation

sallyom commented Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dashpole commented Aug 10, 2021

Uh oh!

ehashman commented Sep 8, 2021

Uh oh!

ehashman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sallyom commented Sep 9, 2021

Uh oh!

dashpole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sallyom commented Oct 10, 2021

Uh oh!

dashpole left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sallyom commented Jan 20, 2022

Uh oh!

ehashman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ehashman left a comment

Choose a reason for hiding this comment

Uh oh!

ehashman Jan 26, 2022

Choose a reason for hiding this comment

Uh oh!

dashpole commented Jan 26, 2022

Uh oh!

ddebroy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sallyom commented Jul 21, 2021 •

edited

Loading

ddebroy left a comment •

edited

Loading