Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Portworx CSI migration to Beta in v1.25 #3345

Merged
merged 1 commit into from Jun 15, 2022
Merged

Promote Portworx CSI migration to Beta in v1.25 #3345

merged 1 commit into from Jun 15, 2022

Conversation

trierra
Copy link
Contributor

@trierra trierra commented Jun 7, 2022

This commit adds the details to the KEP for promoting Portworx CSI migration from alpha to beta in v1.25

One-line PR description: Update KEP for Portworx CSI Migration

Issue link: Portworx file in-tree to CSI driver migration ##2589

Other comments:

/sig storage

  • One-line PR description:
  • Issue link:
  • Other comments:

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @trierra. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 7, 2022
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 8, 2022
@xing-yang
Copy link
Contributor

xing-yang commented Jun 8, 2022 •
edited

Can you add a Test Plan?
a86942e

See this example: https://github.com/kubernetes/enhancements/pull/3351/files
It's just that the Test Plan should be under Design Details.

@Priyankasaggu11929 Priyankasaggu11929 mentioned this pull request Jun 9, 2022
Open
8 tasks
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2022
@trierra
Copy link
Contributor Author

trierra commented Jun 9, 2022

@xing-yang done

@trierra
Copy link
Contributor Author

trierra commented Jun 9, 2022

/retest

xing-yang
xing-yang reviewed Jun 12, 2022
View reviewed changes
keps/sig-storage/2589-csi-migration-portworx/README.md Outdated

##### Unit tests

N/A
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this one: https://github.com/kubernetes/csi-translation-lib/blob/master/plugins/portworx_test.go

keps/sig-storage/2589-csi-migration-portworx/README.md Outdated

##### e2e tests

To ensure the implementation correctness, I/we have manually run the e2e tests, located in the main k8s repository. Test results are attached to the pull requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the in-tree e2e tests for CSI migration here: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/drivers/in_tree.go

Copy link
Contributor Author

@trierra trierra Jun 13, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you want me to add this link to the e2e test section, correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@xing-yang
Copy link
Contributor

/milestone v1.25

@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 14, 2022
@trierra
Copy link
Contributor Author

trierra commented Jun 14, 2022

done

@xing-yang
Copy link
Contributor

Can you fix the CI? I think you just need to update the TOC.

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trierra, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit 09ab36a into kubernetes:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trierra @k8s-ci-robot @xing-yang