-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-3935: newest control planes support oldest nodes #3936
Conversation
keps/sig-architecture/3935-oldest-node-newest-control-plane/README.md
Outdated
Show resolved
Hide resolved
313e86a
to
db7fed8
Compare
/cc |
/lgtm from sig-scheduling |
/approve |
From a cloud provider perspective, the CCM needs to be compatible with node annotations like Overall this seems like a good idea. |
Thanks for the list of all features. looks like 1.28 got lucky :) /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, deads2k, dims, liggitt, neolit123, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That's a good call-out, I added that KEP as needing an update with an explicit timeline for the "The cloud provider will only look at the new annotation." item that accommodates n-3 nodes |
LGTM for sig-windows |
/lgtm |
Thanks for all the reviews and feedback. I think the open questions are resolved and work for this KEP and related work is captured in the document. I'll leave this for a day or so in case anyone has follow-up questions/comments, and plan to drop the hold Friday. |
+100 |
/lgtm |
lgtm from storage POV. |
/hold cancel |
Issue link: Support Oldest Node With Newest Control Plane #3935
Preview at https://github.com/liggitt/enhancements/tree/kep-3935/keps/sig-architecture/3935-oldest-node-newest-control-plane#summary with images rendered
Approvers: